pgsql: Fix incorrect output from pgoutput when using column lists.

2022-12-01 Thread Amit Kapila
Fix incorrect output from pgoutput when using column lists. For Updates and Deletes, we were not honoring the columns list for old tuple values while sending tuple data via pgoutput. This results in pgoutput emitting more columns than expected. This is not a problem for built-in logical replicati

pgsql: Fix incorrect output from pgoutput when using column lists.

2022-12-01 Thread Amit Kapila
Fix incorrect output from pgoutput when using column lists. For Updates and Deletes, we were not honoring the columns list for old tuple values while sending tuple data via pgoutput. This results in pgoutput emitting more columns than expected. This is not a problem for built-in logical replicati

pgsql: autoconf: Don't AC_SUBST() LD in configure

2022-12-01 Thread Andres Freund
autoconf: Don't AC_SUBST() LD in configure The only use of $(LD) in Makefiles is for AIX, to generate the export file for the backend. We only support the system linker on AIX and we already hardcode the path to a number of other binaries. Removing LD substitution will simplify the upcoming meson

pgsql: autoconf: Unify CFLAGS_SSE42 and CFLAGS_ARMV8_CRC32C

2022-12-01 Thread Andres Freund
autoconf: Unify CFLAGS_SSE42 and CFLAGS_ARMV8_CRC32C Until now we emitted the cflags to build the CRC objects into architecture specific variables. That doesn't make a whole lot of sense to me - we're never going to target x86 and arm at the same time, so they don't need to be separate variables.

Re: pgsql: Expand AclMode to 64 bits

2022-12-01 Thread Andrew Dunstan
On 2022-12-01 Th 19:54, Thomas Munro wrote: > On Sat, Nov 26, 2022 at 3:00 AM Andrew Dunstan wrote: > crake is complaining for the upgrades from v12: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-11-23%2023%3A32%3A04 > > It seems that there are some tabl

pgsql: Switch pg_dump to use compression specifications

2022-12-01 Thread Michael Paquier
Switch pg_dump to use compression specifications Compression specifications are currently used by pg_basebackup and pg_receivewal, and are able to let the user control in an extended way the method and level of compression used. As an effect of this commit, pg_dump's -Z/--compress is now able to

Re: pgsql: Expand AclMode to 64 bits

2022-12-01 Thread Thomas Munro
On Sat, Nov 26, 2022 at 3:00 AM Andrew Dunstan wrote: > >>> crake is complaining for the upgrades from v12: > >>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-11-23%2023%3A32%3A04 > >>> > >>> It seems that there are some tables dependent on aclitem, bumping on > >>> your i

pgsql: Fix memory leak for hashing with nondeterministic collations.

2022-12-01 Thread Jeff Davis
Fix memory leak for hashing with nondeterministic collations. Backpatch through 12, where nondeterministic collations were introduced (5e1963fb76). Backpatch-through: 12 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f98c4fb1dd8d117b719963677f0be002cbc5129b

pgsql: Fix memory leak for hashing with nondeterministic collations.

2022-12-01 Thread Jeff Davis
Fix memory leak for hashing with nondeterministic collations. Backpatch through 12, where nondeterministic collations were introduced (5e1963fb76). Backpatch-through: 12 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a844052b5d97c351ba800e51e37b833f93863c29

pgsql: Fix memory leak for hashing with nondeterministic collations.

2022-12-01 Thread Jeff Davis
Fix memory leak for hashing with nondeterministic collations. Backpatch through 12, where nondeterministic collations were introduced (5e1963fb76). Backpatch-through: 12 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9377b4f30a14e1c79183b3138fa88fc99d4a872a

pgsql: Fix memory leak for hashing with nondeterministic collations.

2022-12-01 Thread Jeff Davis
Fix memory leak for hashing with nondeterministic collations. Backpatch through 12, where nondeterministic collations were introduced (5e1963fb76). Backpatch-through: 12 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/47e1224d590ccbc0d745e812dffe2fa913201776

pgsql: Fix memory leak for hashing with nondeterministic collations.

2022-12-01 Thread Jeff Davis
Fix memory leak for hashing with nondeterministic collations. Backpatch through 12, where nondeterministic collations were introduced (5e1963fb76). Backpatch-through: 12 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/edf12e7bbd0f5cf6b3c4f4d6b2dad8586b10dcc6 Modif

pgsql: Doc: add example of round(v, s) with negative s.

2022-12-01 Thread Tom Lane
Doc: add example of round(v, s) with negative s. This has always worked, but you'd be unlikely to guess it from the documentation. Add an example showing it. Lack of docs noted by David Johnston. Back-patch to v13; the documentation layout we used before that was not very amenable to squeezing

pgsql: Doc: add example of round(v, s) with negative s.

2022-12-01 Thread Tom Lane
Doc: add example of round(v, s) with negative s. This has always worked, but you'd be unlikely to guess it from the documentation. Add an example showing it. Lack of docs noted by David Johnston. Back-patch to v13; the documentation layout we used before that was not very amenable to squeezing

pgsql: Doc: add example of round(v, s) with negative s.

2022-12-01 Thread Tom Lane
Doc: add example of round(v, s) with negative s. This has always worked, but you'd be unlikely to guess it from the documentation. Add an example showing it. Lack of docs noted by David Johnston. Back-patch to v13; the documentation layout we used before that was not very amenable to squeezing

pgsql: Doc: add example of round(v, s) with negative s.

2022-12-01 Thread Tom Lane
Doc: add example of round(v, s) with negative s. This has always worked, but you'd be unlikely to guess it from the documentation. Add an example showing it. Lack of docs noted by David Johnston. Back-patch to v13; the documentation layout we used before that was not very amenable to squeezing

pgsql: Doc: word-smith the discussion of secure schema usage patterns.

2022-12-01 Thread Tom Lane
Doc: word-smith the discussion of secure schema usage patterns. Rearrange the discussion of user-private schemas so that details applying only to upgraded-from-pre-v15 databases are in a follow-on paragraph, not in the main description of how to set up this pattern. This seems a little clearer eve

pgsql: Doc: word-smith the discussion of secure schema usage patterns.

2022-12-01 Thread Tom Lane
Doc: word-smith the discussion of secure schema usage patterns. Rearrange the discussion of user-private schemas so that details applying only to upgraded-from-pre-v15 databases are in a follow-on paragraph, not in the main description of how to set up this pattern. This seems a little clearer eve

pgsql: Fix under-parenthesized display of AT TIME ZONE constructs.

2022-12-01 Thread Tom Lane
Fix under-parenthesized display of AT TIME ZONE constructs. In commit 40c24bfef, I forgot to use get_rule_expr_paren() for the arguments of AT TIME ZONE, resulting in possibly not printing parens for expressions that need it. But get_rule_expr_paren() wouldn't have gotten it right anyway, because

pgsql: Fix under-parenthesized display of AT TIME ZONE constructs.

2022-12-01 Thread Tom Lane
Fix under-parenthesized display of AT TIME ZONE constructs. In commit 40c24bfef, I forgot to use get_rule_expr_paren() for the arguments of AT TIME ZONE, resulting in possibly not printing parens for expressions that need it. But get_rule_expr_paren() wouldn't have gotten it right anyway, because

pgsql: Fix under-parenthesized display of AT TIME ZONE constructs.

2022-12-01 Thread Tom Lane
Fix under-parenthesized display of AT TIME ZONE constructs. In commit 40c24bfef, I forgot to use get_rule_expr_paren() for the arguments of AT TIME ZONE, resulting in possibly not printing parens for expressions that need it. But get_rule_expr_paren() wouldn't have gotten it right anyway, because

pgsql: revert: add transaction processing chapter with internals info

2022-12-01 Thread Bruce Momjian
revert: add transaction processing chapter with internals info This doc patch (master hash 66bc9d2d3e) was decided to be too significant for backpatching, so reverted in all but master. Also fix SGML file header comment in master. Reported-by:Peter Eisentraut Discussion: https://postgr.es

pgsql: revert: add transaction processing chapter with internals info

2022-12-01 Thread Bruce Momjian
revert: add transaction processing chapter with internals info This doc patch (master hash 66bc9d2d3e) was decided to be too significant for backpatching, so reverted in all but master. Also fix SGML file header comment in master. Reported-by:Peter Eisentraut Discussion: https://postgr.es

pgsql: revert: add transaction processing chapter with internals info

2022-12-01 Thread Bruce Momjian
revert: add transaction processing chapter with internals info This doc patch (master hash 66bc9d2d3e) was decided to be too significant for backpatching, so reverted in all but master. Also fix SGML file header comment in master. Reported-by:Peter Eisentraut Discussion: https://postgr.es

pgsql: revert: add transaction processing chapter with internals info

2022-12-01 Thread Bruce Momjian
revert: add transaction processing chapter with internals info This doc patch (master hash 66bc9d2d3e) was decided to be too significant for backpatching, so reverted in all but master. Also fix SGML file header comment in master. Reported-by:Peter Eisentraut Discussion: https://postgr.es

pgsql: revert: add transaction processing chapter with internals info

2022-12-01 Thread Bruce Momjian
revert: add transaction processing chapter with internals info This doc patch (master hash 66bc9d2d3e) was decided to be too significant for backpatching, so reverted in all but master. Also fix SGML file header comment in master. Reported-by:Peter Eisentraut Discussion: https://postgr.es

pgsql: revert: add transaction processing chapter with internals info

2022-12-01 Thread Bruce Momjian
revert: add transaction processing chapter with internals info This doc patch (master hash 66bc9d2d3e) was decided to be too significant for backpatching, so reverted in all but master. Also fix SGML file header comment in master. Reported-by:Peter Eisentraut Discussion: https://postgr.es

pgsql: doc: Add installation instructions for building with meson

2022-12-01 Thread Peter Eisentraut
doc: Add installation instructions for building with meson Author: samay sharma Reviewed-by: Justin Pryzby Reviewed-by: Andres Freund Reviewed-by: Nazir Bilal Yavuz Reviewed-by: Peter Eisentraut Discussion: https://www.postgresql.org/message-id/flat/cajxrbywfpcgc4np_v+hhphayswx2jl8fzxy2afozx

pgsql: Move PartitioPruneInfo out of plan nodes into PlannedStmt

2022-12-01 Thread Alvaro Herrera
Move PartitioPruneInfo out of plan nodes into PlannedStmt The planner will now add a given PartitioPruneInfo to PlannedStmt.partPruneInfos instead of directly to the Append/MergeAppend plan node. What gets set instead in the latter is an index field which points to the list element of PlannedStmt

pgsql: doc: Remove note about disk space from installation instructions

2022-12-01 Thread Peter Eisentraut
doc: Remove note about disk space from installation instructions Seems quite outdated and no longer relevant. Author: samay sharma Discussion: https://www.postgresql.org/message-id/flat/cajxrbywfpcgc4np_v+hhphayswx2jl8fzxy2afozxxxtktj...@mail.gmail.com Branch -- master Details --- htt

pgsql: doc: Add missing comma

2022-12-01 Thread Peter Eisentraut
doc: Add missing comma Author: Justin Pryzby Discussion: https://www.postgresql.org/message-id/20221020024312.GH16921%40telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/148e0bd4d6177cdac0a2f3dd4a20190178333c0d Modified Files -- doc/src/sg