pgsql: doc: Add missing markups for developer GUCs

2022-12-04 Thread Michael Paquier
doc: Add missing markups for developer GUCs Missing such markups makes it impossible to create links back to these GUCs, and all the other parameters have one already. Author: Ian Lawrence Barwick Discussion: https://postgr.es/m/CAB8KJ=jx=6dfb_en3j0ukuvg3cpu5omqim-zkraz+fkvs+u...@mail.gmail.com

pgsql: doc: Add missing markups for developer GUCs

2022-12-04 Thread Michael Paquier
doc: Add missing markups for developer GUCs Missing such markups makes it impossible to create links back to these GUCs, and all the other parameters have one already. Author: Ian Lawrence Barwick Discussion: https://postgr.es/m/CAB8KJ=jx=6dfb_en3j0ukuvg3cpu5omqim-zkraz+fkvs+u...@mail.gmail.com

pgsql: doc: Add missing markups for developer GUCs

2022-12-04 Thread Michael Paquier
doc: Add missing markups for developer GUCs Missing such markups makes it impossible to create links back to these GUCs, and all the other parameters have one already. Author: Ian Lawrence Barwick Discussion: https://postgr.es/m/CAB8KJ=jx=6dfb_en3j0ukuvg3cpu5omqim-zkraz+fkvs+u...@mail.gmail.com

pgsql: doc: Add missing markups for developer GUCs

2022-12-04 Thread Michael Paquier
doc: Add missing markups for developer GUCs Missing such markups makes it impossible to create links back to these GUCs, and all the other parameters have one already. Author: Ian Lawrence Barwick Discussion: https://postgr.es/m/CAB8KJ=jx=6dfb_en3j0ukuvg3cpu5omqim-zkraz+fkvs+u...@mail.gmail.com

pgsql: doc: Add missing markups for developer GUCs

2022-12-04 Thread Michael Paquier
doc: Add missing markups for developer GUCs Missing such markups makes it impossible to create links back to these GUCs, and all the other parameters have one already. Author: Ian Lawrence Barwick Discussion: https://postgr.es/m/CAB8KJ=jx=6dfb_en3j0ukuvg3cpu5omqim-zkraz+fkvs+u...@mail.gmail.com

pgsql: doc: Add missing markups for developer GUCs

2022-12-04 Thread Michael Paquier
doc: Add missing markups for developer GUCs Missing such markups makes it impossible to create links back to these GUCs, and all the other parameters have one already. Author: Ian Lawrence Barwick Discussion: https://postgr.es/m/CAB8KJ=jx=6dfb_en3j0ukuvg3cpu5omqim-zkraz+fkvs+u...@mail.gmail.com

pgsql: Add LSN location in some error messages related to WAL pages

2022-12-04 Thread Michael Paquier
Add LSN location in some error messages related to WAL pages The error messages reported during any failures while reading or validating the header of a WAL currently includes only the offset of the page but not the compiled LSN referring to the page, requiring an extra step to compile it if looki

pgsql: Fix thinko introduced in 6b423ec67

2022-12-04 Thread David Rowley
Fix thinko introduced in 6b423ec67 As pointed out by Dean Rasheed, we really should be using tmp > -(PG_INTNN_MIN / 10) rather than tmp > (PG_INTNN_MAX / 10) for checking for overflows in the accumulation in the pg_strtointNN functions. This does happen to be the same number when dividing by 10,

pgsql: Update top-level .gitignore.

2022-12-04 Thread Tom Lane
Update top-level .gitignore. Add a comment explaining our policy that we don't put excludes for nonstandard tools into committed .gitignore files. Also, remove the entries about libraries with .sl extensions, since that convention was only used on now-desupported HP-UX. Discussion: https://post

pgsql: Re-pgindent a few files.

2022-12-04 Thread Tom Lane
Re-pgindent a few files. Just because I'm a neatnik, and I'm currently working on code in this area. It annoys me to not be able to pgindent my patches without working around unrelated changes. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/92c4dafe1eed511c5af92bc

pgsql: Fix broken MemoizePath support in reparameterize_path().

2022-12-04 Thread Tom Lane
Fix broken MemoizePath support in reparameterize_path(). It neglected to recurse to the subpath, meaning you'd get back a path identical to the input. This could produce wrong query results if the omission meant that the subpath fails to enforce some join clause it should be enforcing. We don't

pgsql: Fix generate_partitionwise_join_paths() to tolerate failure.

2022-12-04 Thread Tom Lane
Fix generate_partitionwise_join_paths() to tolerate failure. We might fail to generate a partitionwise join, because reparameterize_path_by_child() does not support all path types. This should not be a hard failure condition: we should just fall back to a non-partitioned join. However, generate_p

pgsql: Fix broken MemoizePath support in reparameterize_path().

2022-12-04 Thread Tom Lane
Fix broken MemoizePath support in reparameterize_path(). It neglected to recurse to the subpath, meaning you'd get back a path identical to the input. This could produce wrong query results if the omission meant that the subpath fails to enforce some join clause it should be enforcing. We don't

pgsql: Fix broken MemoizePath support in reparameterize_path().

2022-12-04 Thread Tom Lane
Fix broken MemoizePath support in reparameterize_path(). It neglected to recurse to the subpath, meaning you'd get back a path identical to the input. This could produce wrong query results if the omission meant that the subpath fails to enforce some join clause it should be enforcing. We don't

pgsql: Fix generate_partitionwise_join_paths() to tolerate failure.

2022-12-04 Thread Tom Lane
Fix generate_partitionwise_join_paths() to tolerate failure. We might fail to generate a partitionwise join, because reparameterize_path_by_child() does not support all path types. This should not be a hard failure condition: we should just fall back to a non-partitioned join. However, generate_p

pgsql: Fix generate_partitionwise_join_paths() to tolerate failure.

2022-12-04 Thread Tom Lane
Fix generate_partitionwise_join_paths() to tolerate failure. We might fail to generate a partitionwise join, because reparameterize_path_by_child() does not support all path types. This should not be a hard failure condition: we should just fall back to a non-partitioned join. However, generate_p

pgsql: Fix generate_partitionwise_join_paths() to tolerate failure.

2022-12-04 Thread Tom Lane
Fix generate_partitionwise_join_paths() to tolerate failure. We might fail to generate a partitionwise join, because reparameterize_path_by_child() does not support all path types. This should not be a hard failure condition: we should just fall back to a non-partitioned join. However, generate_p

pgsql: Add missing MaterialPath support in reparameterize_path[_by_chil

2022-12-04 Thread Tom Lane
Add missing MaterialPath support in reparameterize_path[_by_child]. These two functions failed to cover MaterialPath. That's not a fatal problem, but we can generate better plans in some cases if we support it. Tom Lane and Richard Guo Discussion: https://postgr.es/m/1854233.1669949...@sss.pgh.

pgsql: Fix generate_partitionwise_join_paths() to tolerate failure.

2022-12-04 Thread Tom Lane
Fix generate_partitionwise_join_paths() to tolerate failure. We might fail to generate a partitionwise join, because reparameterize_path_by_child() does not support all path types. This should not be a hard failure condition: we should just fall back to a non-partitioned join. However, generate_p

pgsql: Fix generate_partitionwise_join_paths() to tolerate failure.

2022-12-04 Thread Tom Lane
Fix generate_partitionwise_join_paths() to tolerate failure. We might fail to generate a partitionwise join, because reparameterize_path_by_child() does not support all path types. This should not be a hard failure condition: we should just fall back to a non-partitioned join. However, generate_p