Re: pgsql: meson: Add 'running' test setup, as a replacement for installche

2022-12-15 Thread Andres Freund
Hi, On 2022-12-16 19:52:41 +1300, Thomas Munro wrote: > On Thu, Dec 8, 2022 at 9:48 AM Andres Freund wrote: > > meson: Add 'running' test setup, as a replacement for installcheck > > The -running tests don't seem to be completely stable on CI. I don't > know why (smells like plan changes?) but

Re: pgsql: meson: Add 'running' test setup, as a replacement for installche

2022-12-15 Thread Thomas Munro
On Thu, Dec 8, 2022 at 9:48 AM Andres Freund wrote: > meson: Add 'running' test setup, as a replacement for installcheck The -running tests don't seem to be completely stable on CI. I don't know why (smells like plan changes?) but see cfbot.cputube.org for some flapping on FreeBSD (the only OS

pgsql: Fix typo in reference to __FreeBSD__.

2022-12-15 Thread Thomas Munro
Fix typo in reference to __FreeBSD__. Commit a2a8acd152 introduced a platform-dependent mechanism to prevent developers from referencing errno in the argument list of elog()/ereport(), but didn't use the right macro to detect FreeBSD, so it didn't actually work there. Reported-by: Japin Li

pgsql: Remove pessimistic cost penalization from Incremental Sort

2022-12-15 Thread David Rowley
Remove pessimistic cost penalization from Incremental Sort When incremental sorts were added in v13 a 1.5x pessimism factor was added to the cost modal. Seemingly this was done because the cost modal only has an estimate of the total number of input rows and the number of presorted groups. It

pgsql: Re-adjust drop-index-concurrently-1 isolation test

2022-12-15 Thread David Rowley
Re-adjust drop-index-concurrently-1 isolation test It seems that drop-index-concurrently-1 has started to forget what it was originally meant to be testing. d2d8a229b, which added incremental sorts changed the expected plan to be an Index Scan plan instead of a Seq Scan plan. This occurred as

pgsql: Re-adjust drop-index-concurrently-1 isolation test

2022-12-15 Thread David Rowley
Re-adjust drop-index-concurrently-1 isolation test It seems that drop-index-concurrently-1 has started to forget what it was originally meant to be testing. d2d8a229b, which added incremental sorts changed the expected plan to be an Index Scan plan instead of a Seq Scan plan. This occurred as

pgsql: Re-adjust drop-index-concurrently-1 isolation test

2022-12-15 Thread David Rowley
Re-adjust drop-index-concurrently-1 isolation test It seems that drop-index-concurrently-1 has started to forget what it was originally meant to be testing. d2d8a229b, which added incremental sorts changed the expected plan to be an Index Scan plan instead of a Seq Scan plan. This occurred as

pgsql: Re-adjust drop-index-concurrently-1 isolation test

2022-12-15 Thread David Rowley
Re-adjust drop-index-concurrently-1 isolation test It seems that drop-index-concurrently-1 has started to forget what it was originally meant to be testing. d2d8a229b, which added incremental sorts changed the expected plan to be an Index Scan plan instead of a Seq Scan plan. This occurred as

pgsql: Speed up creation of command completion tags

2022-12-15 Thread David Rowley
Speed up creation of command completion tags The building of command completion tags could often be seen showing up in profiles when running high tps workloads. The query completion tags were being built with snprintf, which is slow at the best of times when compared with more manual ways of

pgsql: Convert range_in and multirange_in to report errors softly.

2022-12-15 Thread Tom Lane
Convert range_in and multirange_in to report errors softly. This is mostly straightforward, except that if the range type has a canonical function, that might throw an error during range input. (Such errors probably only occur for edge cases: in the in-core canonical functions, it happens only

pgsql: postgres_fdw: Fix assertion in estimate_path_cost_size().

2022-12-15 Thread Etsuro Fujita
postgres_fdw: Fix assertion in estimate_path_cost_size(). Commit 08d2d58a2 added this assertion assuming that the retrieved_rows estimate for a foreign relation is set to at least one row in estimate_path_cost_size(), but the assumption isn't correct because if the relation is a foreign table

pgsql: Static assertions cleanup

2022-12-15 Thread Peter Eisentraut
Static assertions cleanup Because we added StaticAssertStmt() first before StaticAssertDecl(), some uses as well as the instructions in c.h are now a bit backwards from the "native" way static assertions are meant to be used in C. This updates the guidance and moves some static assertions to