pgsql: Remove useless casts to (void *) in arguments of some system fun

2023-02-06 Thread Peter Eisentraut
Remove useless casts to (void *) in arguments of some system functions The affected functions are: bsearch, memcmp, memcpy, memset, memmove, qsort, repalloc Reviewed-by: Corey Huinker Discussion: https://www.postgresql.org/message-id/flat/fd9adf5d-b1aa-e82f-e4c7-263c30145807%40enterprisedb.com

pgsql: Use appropriate wait event when sending data in the apply worker

2023-02-06 Thread Amit Kapila
Use appropriate wait event when sending data in the apply worker. Currently, we reuse WAIT_EVENT_LOGICAL_PARALLEL_APPLY_STATE_CHANGE in the apply worker while sending data to the parallel apply worker via a shared memory queue. This is not appropriate as one won't be able to distinguish whether

pgsql: More refactoring of heapgettup() and heapgettup_pagemode()

2023-02-06 Thread David Rowley
More refactoring of heapgettup() and heapgettup_pagemode() Here we further simplify the code in heapgettup() and heapgettup_pagemode() to make better use of the helper functions added in the previous recent refactors in this area. In passing, remove an unneeded cast added in 8ca6d49f6. Author:

pgsql: Include values of A_Const nodes in query jumbling

2023-02-06 Thread Michael Paquier
Include values of A_Const nodes in query jumbling Like the implementation for node copy, write and read, this node requires a custom implementation so as the query jumbling is able to consider the correct value assigned to it, depending on its type (int, float, bool, string, bitstring). Based on

pgsql: ci: freebsd: stop postgres instance on failure, to prevent log u

2023-02-06 Thread Andres Freund
ci: freebsd: stop postgres instance on failure, to prevent log upload failures Discussion: https://postgr.es/m/20230205233057.e2243nl44agf7...@alap3.anarazel.de Discussion: https://postgr.es/m/20230206221422.ykidlne7pmywu...@awork3.anarazel.de Branch -- master Details ---

pgsql: Fix more outdated comments

2023-02-06 Thread Peter Eisentraut
Fix more outdated comments Same as in f5da3d8 but for write_relcache_init_file(), the comments had gotten a bit wrong due to code added over time. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6c14fb17e4be70e0f3c03d2f9f6c540b6d5bdcbe Modified Files

pgsql: Fix up outdated comments

2023-02-06 Thread Peter Eisentraut
Fix up outdated comments The existing comments in load_relcache_init_file() were not flexible when new entries were added at the end, so they ended up a bit wrong. Simplify the comments to avoid this issue. Branch -- master Details ---

pgsql: Stamp 11.19.

2023-02-06 Thread Tom Lane
Stamp 11.19. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0da63ea07a3b610a5f0c4fc43595d76f3d8fa0d7 Modified Files -- configure| 18 +- configure.in | 2 +- doc/bug.template

pgsql: Stamp 12.14.

2023-02-06 Thread Tom Lane
Stamp 12.14. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/533cc39b750bd7600e8e2e5cab819a27f1717960 Modified Files -- configure| 18 +- configure.in | 2 +-

pgsql: Stamp 13.10.

2023-02-06 Thread Tom Lane
Stamp 13.10. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/20aba55fae83cd0b6f7511365d172da8cd7e0135 Modified Files -- configure| 18 +- configure.in | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-)

pgsql: Stamp 14.7.

2023-02-06 Thread Tom Lane
Stamp 14.7. Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e4c4e6258c747d440e161f387d2eff84a835ca08 Modified Files -- configure| 18 +- configure.ac | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-)

pgsql: Stamp 15.2.

2023-02-06 Thread Tom Lane
Stamp 15.2. Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/78ec02d612a9b69039ec2610740f738968fe144d Modified Files -- configure| 18 +- configure.ac | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-)

pgsql: Fix up join removal's interaction with PlaceHolderVars.

2023-02-06 Thread Tom Lane
Fix up join removal's interaction with PlaceHolderVars. The portion of join_is_removable() that checks PlaceHolderVars can be made a little more accurate and intelligible than it was. The key point is that we can allow join removal even if a PHV mentions the target rel in ph_eval_at, if that

pgsql: doc: Fix SQL keywords lists

2023-02-06 Thread Peter Eisentraut
doc: Fix SQL keywords lists Some keywords were listed as both reserved and nonreserved. Fix as appropriate. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7ba09efe248fe5e15bd6d4c4d0612ea63b66a860 Modified Files --

pgsql: Revert "Disable STARTUP_PROGRESS_TIMEOUT in standby mode."

2023-02-06 Thread Robert Haas
Revert "Disable STARTUP_PROGRESS_TIMEOUT in standby mode." This reverts commit 98e7234242a652497c99d4d0d6f2bf9a75d4e921. I forgot that we're about to wrap a release, and this fix isn't critical enough to justify committing it right before we wrap a release. Discussion:

pgsql: Disable STARTUP_PROGRESS_TIMEOUT in standby mode.

2023-02-06 Thread Robert Haas
Disable STARTUP_PROGRESS_TIMEOUT in standby mode. In standby mode, we don't actually report progress of recovery, but up until now, startup_progress_timeout_handler() nevertheless got called every log_startup_progress_interval seconds. That's an unnecessary expense, so avoid it. Report by Thomas

pgsql: Disable STARTUP_PROGRESS_TIMEOUT in standby mode.

2023-02-06 Thread Robert Haas
Disable STARTUP_PROGRESS_TIMEOUT in standby mode. In standby mode, we don't actually report progress of recovery, but up until now, startup_progress_timeout_handler() nevertheless got called every log_startup_progress_interval seconds. That's an unnecessary expense, so avoid it. Report by Thomas

pgsql: doc: Fix description of SQL standard parts

2023-02-06 Thread Peter Eisentraut
doc: Fix description of SQL standard parts The splitting into parts actually started earlier than the text had claimed, but that is ancient history anyway by now and does not need to be mentioned. Update that and tweak the text a bit. Branch -- master Details ---

pgsql: Translation updates

2023-02-06 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: a7bebd06a02093ea07899fc0804adeb372126620 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/07113f15cd123aa2279cb37e0e848766e050225b Modified Files

pgsql: Translation updates

2023-02-06 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 8ae33814b61e2eabfaac363c777e0cbf346761de Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/28ac6d0a99d57375dbd9bc2acd16fd1127502ef7 Modified Files

pgsql: Translation updates

2023-02-06 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 0a5723fd9be9be6300531a4cb0cf34eab22b66b3 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f280ad2ca2d808a8cee6489dbbe2ec1e9ca02434 Modified Files

pgsql: Translation updates

2023-02-06 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: c0b6943fdf3e16682c81db112bff4cb0f67b71fc Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bc9edc6b59aceee6fa40fbd74a1ee2b5f1546073 Modified Files

pgsql: Translation updates

2023-02-06 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 3748d8972214a3d1e316cffc19824cd948e9e2d8 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ec16eac8dabcd80559dcc6aeec48c0b57fb8b2bd Modified Files

pgsql: Remove useless casts to (void *) in hash_search() calls

2023-02-06 Thread Peter Eisentraut
Remove useless casts to (void *) in hash_search() calls Some of these appear to be leftovers from when hash_search() took a char * argument (changed in 5999e78fc45dcb91784b64b6e9ae43f4e4f68ca2). Since after this there is some more horizontal space available, do some light reformatting where