pgsql: Fix various typos in code and tests

2023-02-08 Thread Michael Paquier
Fix various typos in code and tests Most of these are recent, and the documentation portions are new as of v16 so there is no need for a backpatch. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgres

pgsql: Remove uses of AssertVariableIsOfType() obsoleted by f2b73c8

2023-02-08 Thread Andres Freund
Remove uses of AssertVariableIsOfType() obsoleted by f2b73c8 Author: Nathan Bossart Discussion: https://postgr.es/m/20230208172705.GA451849@nathanxps13 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/30b789eafed2cbbc3de9c9025a30eefdffacb79c Modified Files

pgsql: pgstat: Infrastructure for more detailed IO statistics

2023-02-08 Thread Andres Freund
pgstat: Infrastructure for more detailed IO statistics This commit adds the infrastructure for more detailed IO statistics. The calls to actually count IOs, a system view to access the new statistics, documentation and tests will be added in subsequent commits, to make review easier. While we alr

pgsql: Fix bugs in GetSafeSnapshotBlockingPids(), introduced in 9600371

2023-02-08 Thread Andres Freund
Fix bugs in GetSafeSnapshotBlockingPids(), introduced in 96003717645 While removing the use of SHM_QUEUE from predicate.c, in 96003717645, I made two mistakes in GetSafeSnapshotBlockingPids(): - Removed the check for output_size - Previously, when the first loop didn't find a matching proc, sxact

pgsql: Stop recommending auto-download of DTD files, and indeed disable

2023-02-08 Thread Tom Lane
Stop recommending auto-download of DTD files, and indeed disable it. It appears no longer possible to build the SGML docs without a local installation of the DocBook DTD, because sourceforge.net now only permits HTTPS access, and no common version of xsltproc supports that. Hence, remove the bits

pgsql: Stop recommending auto-download of DTD files, and indeed disable

2023-02-08 Thread Tom Lane
Stop recommending auto-download of DTD files, and indeed disable it. It appears no longer possible to build the SGML docs without a local installation of the DocBook DTD, because sourceforge.net now only permits HTTPS access, and no common version of xsltproc supports that. Hence, remove the bits

pgsql: Stop recommending auto-download of DTD files, and indeed disable

2023-02-08 Thread Tom Lane
Stop recommending auto-download of DTD files, and indeed disable it. It appears no longer possible to build the SGML docs without a local installation of the DocBook DTD, because sourceforge.net now only permits HTTPS access, and no common version of xsltproc supports that. Hence, remove the bits

pgsql: Stop recommending auto-download of DTD files, and indeed disable

2023-02-08 Thread Tom Lane
Stop recommending auto-download of DTD files, and indeed disable it. It appears no longer possible to build the SGML docs without a local installation of the DocBook DTD, because sourceforge.net now only permits HTTPS access, and no common version of xsltproc supports that. Hence, remove the bits

pgsql: Stop recommending auto-download of DTD files, and indeed disable

2023-02-08 Thread Tom Lane
Stop recommending auto-download of DTD files, and indeed disable it. It appears no longer possible to build the SGML docs without a local installation of the DocBook DTD, because sourceforge.net now only permits HTTPS access, and no common version of xsltproc supports that. Hence, remove the bits

pgsql: Stop recommending auto-download of DTD files, and indeed disable

2023-02-08 Thread Tom Lane
Stop recommending auto-download of DTD files, and indeed disable it. It appears no longer possible to build the SGML docs without a local installation of the DocBook DTD, because sourceforge.net now only permits HTTPS access, and no common version of xsltproc supports that. Hence, remove the bits

pgsql: pgindent: more ways to find files to indent

2023-02-08 Thread Andrew Dunstan
pgindent: more ways to find files to indent A new --commit option will add all the files in a commit to the file list. The option can be specified more than once. Also, if a directory is given on the command line, all the files in that directory tree will be added to the file list. Per suggestio

pgsql: Backpatch OpenSSL 3.0.0 compatibility in tests

2023-02-08 Thread Andrew Dunstan
Backpatch OpenSSL 3.0.0 compatibility in tests backport of commit f0d2c65f17 to releases 11 and 12 This means the SSL tests will fail on machines with extremely old versions of OpenSSL, but we don't know of anything trying to run such tests. The ability to build is not affected. Discussion: htt

pgsql: Backpatch OpenSSL 3.0.0 compatibility in tests

2023-02-08 Thread Andrew Dunstan
Backpatch OpenSSL 3.0.0 compatibility in tests backport of commit f0d2c65f17 to releases 11 and 12 This means the SSL tests will fail on machines with extremely old versions of OpenSSL, but we don't know of anything trying to run such tests. The ability to build is not affected. Discussion: htt

pgsql: remove_rel_from_query() must clean up PlaceHolderVar.phrels fiel

2023-02-08 Thread Tom Lane
remove_rel_from_query() must clean up PlaceHolderVar.phrels fields. While we got away with this sloppiness before, it's not okay now that fee7b77b9 caused build_joinrel_tlist() to make use of phrels. Per report from Robins Tharakan. Richard Guo (some cosmetic tweaks by me) Discussion: https://p

pgsql: Further tighten nullingrel marking rules in build_joinrel_tlist(

2023-02-08 Thread Tom Lane
Further tighten nullingrel marking rules in build_joinrel_tlist(). The code I added in fee7b77b9 could misbehave if commute_above_r contains multiple relids. While adding too many relids here is probably harmless (pre-fee7b77b9, we did it all the time), it's not very expensive to be accurate: we