pgsql: Drop test view when done with it.

2023-02-27 Thread Tom Lane
Drop test view when done with it. The view just added by commit 53fe7e6cb decompiles differently in v15 than HEAD (presumably as a consequence of 47bb9db75). That causes failures in cross-version upgrade testing. We could teach AdjustUpgrade.pm to compensate for that, but it seems less painful to

pgsql: Drop test view when done with it.

2023-02-27 Thread Tom Lane
Drop test view when done with it. The view just added by commit 53fe7e6cb decompiles differently in v15 than HEAD (presumably as a consequence of 47bb9db75). That causes failures in cross-version upgrade testing. We could teach AdjustUpgrade.pm to compensate for that, but it seems less painful to

pgsql: Fix expected output of xml_2.out

2023-02-27 Thread Michael Paquier
Fix expected output of xml_2.out Per buildfarm members snakefly, parula and prion, that reflect the results coming from the latest versions of libxml2. Oversight in b8da37b in the shape of an incorrect copy-paste. The CI was green, but it does not stress this expected output. Branch -- mast

pgsql: Rework pg_input_error_message(), now renamed pg_input_error_info

2023-02-27 Thread Michael Paquier
Rework pg_input_error_message(), now renamed pg_input_error_info() pg_input_error_info() is now a SQL function able to return a row with more than just the error message generated for incorrect data type inputs when these are able to handle soft failures, returning more contents of ErrorData, as o

pgsql: Suppress compiler warnings in new pgstats code.

2023-02-27 Thread Tom Lane
Suppress compiler warnings in new pgstats code. Some clang versions whine about comparing an enum variable to a value outside the range of the enum, on the grounds that the result must be constant. In the cases we fix here, the loops will terminate only if the enum variable can in fact hold a val

pgsql: Harden postgres_fdw tests against unexpected cache flushes.

2023-02-27 Thread Tom Lane
Harden postgres_fdw tests against unexpected cache flushes. postgres_fdw will close its remote session if an sinval cache reset occurs, since it's possible that that means some FDW parameters changed. We had two tests that were trying to ensure that the session remains alive by setting debug_disc

pgsql: Harden postgres_fdw tests against unexpected cache flushes.

2023-02-27 Thread Tom Lane
Harden postgres_fdw tests against unexpected cache flushes. postgres_fdw will close its remote session if an sinval cache reset occurs, since it's possible that that means some FDW parameters changed. We had two tests that were trying to ensure that the session remains alive by setting debug_disc

pgsql: Harden postgres_fdw tests against unexpected cache flushes.

2023-02-27 Thread Tom Lane
Harden postgres_fdw tests against unexpected cache flushes. postgres_fdw will close its remote session if an sinval cache reset occurs, since it's possible that that means some FDW parameters changed. We had two tests that were trying to ensure that the session remains alive by setting debug_disc

pgsql: Replace single-quotes with double-quotes in a few SGML attribute

2023-02-27 Thread Heikki Linnakangas
Replace single-quotes with double-quotes in a few SGML attributes. Both are valid SGML, but let's be consistent. Author: Peter Smith Discussion: https://www.postgresql.org/message-id/CAHut%2BPtghjg0SBUTv%3D4Bpcy68d1zD3VAnZ3wX1DQSp39XKD9Sw%40mail.gmail.com Branch -- master Details --- h