pgsql: Remove PgStat_BackendFunctionEntry

2023-03-15 Thread Michael Paquier
Remove PgStat_BackendFunctionEntry This structure included only PgStat_FunctionCounts, and removing it facilitates some upcoming refactoring for pgstatfuncs.c to use more macros rather that mostly-duplicated functions. Author: Bertrand Drouvot Reviewed-by: Nathan Bossart Discussion: https://postg

pgsql: Tweak regression test of pg_walinspect to be less collation-sens

2023-03-15 Thread Michael Paquier
Tweak regression test of pg_walinspect to be less collation-sensitive \dx was used on pg_walinspect to list its objects in 1.0 but the names of the objects in this version do not have an order that is always guaranteed depending on the collation used. Rather than append a COLLATE clause in the qu

pgsql: Add .gitignore to ldap_password_func

2023-03-15 Thread Michael Paquier
Add .gitignore to ldap_password_func This bit has been forgotten in 419a8dd. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c9a272daaa43a29cbfca44f4823cab65cb9725bd Modified Files -- src/test/modules/ldap_password_func/.gitignore | 4 1 file change

pgsql: Improve handling of psql \watch's interval argument

2023-03-15 Thread Michael Paquier
Improve handling of psql \watch's interval argument A failure in parsing the interval value defined in the \watch command was silently switched to 1s of interval between two queries, which can be confusing. This commit improves the error handling, and a couple of tests are added to check after: -

pgsql: MSVC: Don't build ldap_password_func if not building with ldap

2023-03-15 Thread Andrew Dunstan
MSVC: Don't build ldap_password_func if not building with ldap Blind attempt to fix issue with 419a8dd814 found on drongo. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/dccb4d1c039194a57bfb9b39f0412a2b7f7c5104 Modified Files -- src/tools/msvc/Mkvcbuil

pgsql: Don't try to read default for a non-existent attribute

2023-03-15 Thread Andrew Dunstan
Don't try to read default for a non-existent attribute Oversight in commit 9f8377f7a2 for COPY .. DEFAULT per report from Alexander Lakhin Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b85e91023bf3fd5b4dbd35dc3eddbf0dc291c8ad Modified Files -- src/ba

pgsql: Support [NO] INDENT option in XMLSERIALIZE().

2023-03-15 Thread Tom Lane
Support [NO] INDENT option in XMLSERIALIZE(). This adds the ability to pretty-print XML documents ... according to libxml's somewhat idiosyncratic notions of what's pretty, anyway. One notable divergence from a strict reading of the spec is that libxml is willing to collapse empty nodes "" to just

pgsql: Add a hook for modifying the ldapbind password

2023-03-15 Thread Andrew Dunstan
Add a hook for modifying the ldapbind password The hook can be installed by a shared_preload library. A similar mechanism could be used for radius paswords, for example, and the type name auth_password_hook_typ has been shosen with that in mind. John Naylor and Andrew Dunstan Discussion: https

pgsql: Support PlaceHolderVars in MERGE actions.

2023-03-15 Thread Tom Lane
Support PlaceHolderVars in MERGE actions. preprocess_targetlist thought PHVs couldn't appear here. It was mistaken, as per report from Önder Kalacı. Surveying other pull_var_clause calls, I noted no similar errors, but I did notice that qual_is_pushdown_safe's assertion about !contain_window_func

pgsql: Support PlaceHolderVars in MERGE actions.

2023-03-15 Thread Tom Lane
Support PlaceHolderVars in MERGE actions. preprocess_targetlist thought PHVs couldn't appear here. It was mistaken, as per report from Önder Kalacı. Surveying other pull_var_clause calls, I noted no similar errors, but I did notice that qual_is_pushdown_safe's assertion about !contain_window_func

pgsql: doc: Add lists of modules trusted/obsolete

2023-03-15 Thread Alvaro Herrera
doc: Add lists of modules trusted/obsolete Author: Karl Pinc Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a0137388cb642bcc1ba10fb906b88658653c589d Modified Files -- doc/src/s