pgsql: Fix a couple of typos

2023-03-21 Thread Michael Paquier
Fix a couple of typos PL/pgSQL was misspelled in a few places, so fix these. Author: Zhang Mingli Reviewed-by: Richard Guo Discussion: https://postgr.es/m/1bd41572-9cd9-465e-9f59-ee45385e51b4@Spark Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/88199b9d5fda605360a

pgsql: Support language tags in older ICU versions (53 and earlier).

2023-03-21 Thread Jeff Davis
Support language tags in older ICU versions (53 and earlier). By calling uloc_canonicalize() before parsing the attributes, the existing locale attribute parsing logic works on language tags as well. Fix a small memory leak, too. Discussion: http://postgr.es/m/60da0cecfb512a78b8666b31631a636215

pgsql: Fix make maintainer-clean with queryjumblefuncs.*.c files in src

2023-03-21 Thread Michael Paquier
Fix make maintainer-clean with queryjumblefuncs.*.c files in src/backend/nodes/ The files generated by gen_node_support.pl for query jumbling (queryjumblefuncs.funcs.c and queryjumblefuncs.switch.c) were not being removed on make maintainer-clean (they need to remain around after a simple "clean")

pgsql: Fix incorrect comment in preptlist.c

2023-03-21 Thread David Rowley
Fix incorrect comment in preptlist.c Author: Etsuro Fujita Reviewed-by: Richard Guo, Tom Lane Discussion: https://postgr.es/m/capmgk15v8dcvxl9vcgvwphv6pw1qzm42lzoukqdb7-e+1on...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b94c671648a6b2141f330938

pgsql: Correct Memoize's estimated cache hit ratio calculation

2023-03-21 Thread David Rowley
Correct Memoize's estimated cache hit ratio calculation As demonstrated by David Johnston, the Memoize cache hit ratio calculation wasn't quite correct. This change only affects the estimated hit ratio when the estimated number of entries to cache is estimated not to fit inside the cache. For ex

pgsql: Add SHELL_ERROR and SHELL_EXIT_CODE magic variables to psql.

2023-03-21 Thread Tom Lane
Add SHELL_ERROR and SHELL_EXIT_CODE magic variables to psql. These are set after a \! command or a backtick substitution. SHELL_ERROR is just "true" for error (nonzero exit status) or "false" for success, while SHELL_EXIT_CODE records the actual exit status following standard shell/system(3) conve

pgsql: docs: use consistent markup for PostgreSQL

2023-03-21 Thread Daniel Gustafsson
docs: use consistent markup for PostgreSQL "PostgreSQL" should use markup consistenktly, so that if we do apply styling on it it will be consistently applied. Fix by renaming the one exception to the rule. Discussion: https://postgr.es/m/f2ef5217-27a3-4962-9ae5-2e6c2cb3d...@yesql.se Branch ---

pgsql: Avoid using atooid for numerical comparisons which arent Oids

2023-03-21 Thread Daniel Gustafsson
Avoid using atooid for numerical comparisons which arent Oids The check for the number of roles in the target cluster for an upgrade selects the existing roles and performs a COUNT(*) over the result. A value of one is the expected query result value indicating that only the install user is prese

pgsql: pg_waldump: Allow hexadecimal values for -t/--timeline option

2023-03-21 Thread Peter Eisentraut
pg_waldump: Allow hexadecimal values for -t/--timeline option This makes it easier to specify values taken directly from WAL file names. The option parsing is arranged in the style of option_parse_int() (but we need to parse unsigned int), to allow future refactoring in the same manner. Reviewed