pgsql: pg_walinspect: Adjust memory context name.

2023-03-27 Thread Peter Geoghegan
pg_walinspect: Adjust memory context name. Correct the name of the memory context used by the pg_get_wal_block_info() SQL-callable function. Oversight in commit 9ecb134a93. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/637dce2254245321283ade9db1b7cc8d1f8cf308

pgsql: Generate a few more functions of pgstatfuncs.c with macros

2023-03-27 Thread Michael Paquier
Generate a few more functions of pgstatfuncs.c with macros Two new macros are added with their respective functions switched to use them. These are for functions with millisecond stats, with and without "xact" in their names (for the stats that can be tracked within a transaction). While on it,

pgsql: doc: Fix XML_CATALOG_FILES env var for Apple Silicon machines

2023-03-27 Thread Daniel Gustafsson
doc: Fix XML_CATALOG_FILES env var for Apple Silicon machines Homebrew changed the prefix for Apple Silicon based machines, so our advice for XML_CATALOG_FILES needs to mention both. More info on the Homebrew change can be found at: https://github.com/Homebrew/brew/issues/9177 This is

pgsql: doc: Fix XML_CATALOG_FILES env var for Apple Silicon machines

2023-03-27 Thread Daniel Gustafsson
doc: Fix XML_CATALOG_FILES env var for Apple Silicon machines Homebrew changed the prefix for Apple Silicon based machines, so our advice for XML_CATALOG_FILES needs to mention both. More info on the Homebrew change can be found at: https://github.com/Homebrew/brew/issues/9177 This is

pgsql: doc: Fix XML_CATALOG_FILES env var for Apple Silicon machines

2023-03-27 Thread Daniel Gustafsson
doc: Fix XML_CATALOG_FILES env var for Apple Silicon machines Homebrew changed the prefix for Apple Silicon based machines, so our advice for XML_CATALOG_FILES needs to mention both. More info on the Homebrew change can be found at: https://github.com/Homebrew/brew/issues/9177 This is

pgsql: doc: Fix XML_CATALOG_FILES env var for Apple Silicon machines

2023-03-27 Thread Daniel Gustafsson
doc: Fix XML_CATALOG_FILES env var for Apple Silicon machines Homebrew changed the prefix for Apple Silicon based machines, so our advice for XML_CATALOG_FILES needs to mention both. More info on the Homebrew change can be found at: https://github.com/Homebrew/brew/issues/9177 This is

pgsql: doc: Fix XML_CATALOG_FILES env var for Apple Silicon machines

2023-03-27 Thread Daniel Gustafsson
doc: Fix XML_CATALOG_FILES env var for Apple Silicon machines Homebrew changed the prefix for Apple Silicon based machines, so our advice for XML_CATALOG_FILES needs to mention both. More info on the Homebrew change can be found at: https://github.com/Homebrew/brew/issues/9177 This is

pgsql: Reject attempts to alter composite types used in indexes.

2023-03-27 Thread Tom Lane
Reject attempts to alter composite types used in indexes. find_composite_type_dependencies() ignored indexes, which is a poor decision because an expression index could have a stored column of a composite (or other container) type even when the underlying table does not. Teach it to detect such

pgsql: Reject attempts to alter composite types used in indexes.

2023-03-27 Thread Tom Lane
Reject attempts to alter composite types used in indexes. find_composite_type_dependencies() ignored indexes, which is a poor decision because an expression index could have a stored column of a composite (or other container) type even when the underlying table does not. Teach it to detect such

pgsql: Reject attempts to alter composite types used in indexes.

2023-03-27 Thread Tom Lane
Reject attempts to alter composite types used in indexes. find_composite_type_dependencies() ignored indexes, which is a poor decision because an expression index could have a stored column of a composite (or other container) type even when the underlying table does not. Teach it to detect such

pgsql: Reject attempts to alter composite types used in indexes.

2023-03-27 Thread Tom Lane
Reject attempts to alter composite types used in indexes. find_composite_type_dependencies() ignored indexes, which is a poor decision because an expression index could have a stored column of a composite (or other container) type even when the underlying table does not. Teach it to detect such

pgsql: Reject attempts to alter composite types used in indexes.

2023-03-27 Thread Tom Lane
Reject attempts to alter composite types used in indexes. find_composite_type_dependencies() ignored indexes, which is a poor decision because an expression index could have a stored column of a composite (or other container) type even when the underlying table does not. Teach it to detect such

pgsql: Reject attempts to alter composite types used in indexes.

2023-03-27 Thread Tom Lane
Reject attempts to alter composite types used in indexes. find_composite_type_dependencies() ignored indexes, which is a poor decision because an expression index could have a stored column of a composite (or other container) type even when the underlying table does not. Teach it to detect such

pgsql: amcheck: Generalize one of the recently-added update chain check

2023-03-27 Thread Robert Haas
amcheck: Generalize one of the recently-added update chain checks. Commit bbc1376b39627c6bddd8a0dc0a7dda24c91a97a0 checked that if a redirected line pointer pointed to a tuple, the tuple should be marked both HEAP_ONLY_TUPLE and HEAP_UPDATED. But Andres Freund pointed out that *any* tuple that is

pgsql: amcheck: Tighten up validation of redirect line pointers.

2023-03-27 Thread Robert Haas
amcheck: Tighten up validation of redirect line pointers. Commit bbc1376b39627c6bddd8a0dc0a7dda24c91a97a0 added a new lp_valid[] array which records whether or not a line pointer was thought to be valid, but entries could sometimes get set to true in cases where that wasn't actually safe. Fix

pgsql: doc: fix Apple Silicon Homebrew prefix change documentation

2023-03-27 Thread Daniel Gustafsson
doc: fix Apple Silicon Homebrew prefix change documentation Commit 4c8d65408 incorrectly stated that Homebrew has changed its prefix for Apple M1 machines, but the prefix change applies to all Apple Silicon based machines. Fix by writing Apple Silicon instead of Apple M1. Reported-by: Dagfinn

pgsql: doc: Fix XML_CATALOG_FILES env var for Apple M1 machines

2023-03-27 Thread Daniel Gustafsson
doc: Fix XML_CATALOG_FILES env var for Apple M1 machines Homebrew changed the prefix for Apple M1 based machines, so our advice for XML_CATALOG_FILES needs to mention both. More info on the Homebrew change can be found at: https://github.com/Homebrew/brew/issues/9177 Author: Julien Rouhaud

pgsql: Make SCRAM iteration count configurable

2023-03-27 Thread Daniel Gustafsson
Make SCRAM iteration count configurable Replace the hardcoded value with a GUC such that the iteration count can be raised in order to increase protection against brute-force attacks. The hardcoded value for SCRAM iteration count was defined to be 4096, which is taken from RFC 7677, so set the

pgsql: meson: Fix support for empty darwin sysroot

2023-03-27 Thread Peter Eisentraut
meson: Fix support for empty darwin sysroot The -isysroot options should only be added if the sysroot resolved to a nonempty string. This matches the behavior in src/template/darwin (also documented in installation.sgml). Discussion: