pgsql: doc: Update SQL keywords list to SQL:2023

2023-04-04 Thread Peter Eisentraut
doc: Update SQL keywords list to SQL:2023 Per previous convention (see ace397e9d24eddc56e7dffa921f506117b602d78), drop SQL:2011 and only keep the latest two standards and SQL-92. Discussion: https://www.postgresql.org/message-id/flat/[email protected] Branch

pgsql: Fix minor signed/unsigned mixup

2023-04-04 Thread Peter Eisentraut
Fix minor signed/unsigned mixup The chunk header is unsigned, and the output format takes unsigned, so casting it to signed in between is incorrect. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c209d317e9b818e25b30703c60113875acb73008 Modified Files

pgsql: docs: html: copy images to output as part of xslt build

2023-04-04 Thread Andres Freund
docs: html: copy images to output as part of xslt build Until now the meson built HTML docs had non-working references to images. They were copied in the make target. Instead of duplicating that for meson, copy them as part of the xslt stylesheet. Reported-by: Peter Eisentraut Discussion: https

pgsql: docs: html: load stylesheet via custom.css.source

2023-04-04 Thread Andres Freund
docs: html: load stylesheet via custom.css.source Until now the meson built docs did not have a working reference to the css stylesheet, it was copied in the make target. Instead of duplicating that for meson, use the docbook-xsl parameter custom.css.source to reference it. An additional benefit o

pgsql: meson: docs: Allow configuring simple/website style

2023-04-04 Thread Andres Freund
meson: docs: Allow configuring simple/website style The meson docs generation hardcoded using the website style so far. Make it configurable via a meson option. Reviewed-by: Justin Pryzby Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/3fc3bb9b-f7f8-d442-35c1-ec82280c5...@enterpr

pgsql: meson: docs: Preparatory cleanups

2023-04-04 Thread Andres Freund
meson: docs: Preparatory cleanups These are just minor prerequisite changes for later commits. Kept separate for easier review. Discussion: https://postgr.es/m/[email protected] Discussion: https://postgr.es/m/[email protected]

pgsql: meson: add docs, docs_pdf options

2023-04-04 Thread Andres Freund
meson: add docs, docs_pdf options Detect and report if the tools necessary to build documentation are available during configure. This is represented as two new options 'docs' and 'docs_pdf', both defaulting to 'auto'. This should also fix a meson error about the installdocs target, when none of

pgsql: Add Copyright notice in 001_basic.pl and 002_pg_upgrade.pl.

2023-04-04 Thread Amit Kapila
Add Copyright notice in 001_basic.pl and 002_pg_upgrade.pl. Author: Kuroda Hayato Discussion: https://postgr.es/m/tycpr01mb587073d91e372b8ef719931ef5...@tycpr01mb5870.jpnprd01.prod.outlook.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8df0d3d5303fa62d169985b8

pgsql: docs: Remove support for 'htmlhelp' format

2023-04-04 Thread Andres Freund
docs: Remove support for 'htmlhelp' format We had partial support for generating documentation suitable for .chm files. However, we only had wired up generating the input files using docbook-xsl, not generating an actual .chm file. Nor did we document how to do so. Additionally, it was very slow

pgsql: sequences: Lock buffer before initializing page

2023-04-04 Thread Andres Freund
sequences: Lock buffer before initializing page fill_seq_fork_with_data(), used to initialize a new sequence relation, only locked the buffer after calling PageInit(), even though PageInit() modifies page contents. This is unlikely to cause real-world issues, as the relation is exclusively locked

pgsql: doc: Add more details about pg_stat_get_xact_blocks_{fetched,hit

2023-04-04 Thread Michael Paquier
doc: Add more details about pg_stat_get_xact_blocks_{fetched,hit} The explanation describing the dependency to system read() calls for these two functions has been removed in ddfc2d9. And after more discussion about d69c404, we have concluded that adding more details makes them easier to understa

pgsql: doc: Add more details about pg_stat_get_xact_blocks_{fetched,hit

2023-04-04 Thread Michael Paquier
doc: Add more details about pg_stat_get_xact_blocks_{fetched,hit} The explanation describing the dependency to system read() calls for these two functions has been removed in ddfc2d9. And after more discussion about d69c404, we have concluded that adding more details makes them easier to understa

pgsql: doc: Add more details about pg_stat_get_xact_blocks_{fetched,hit

2023-04-04 Thread Michael Paquier
doc: Add more details about pg_stat_get_xact_blocks_{fetched,hit} The explanation describing the dependency to system read() calls for these two functions has been removed in ddfc2d9. And after more discussion about d69c404, we have concluded that adding more details makes them easier to understa

pgsql: doc: Add more details about pg_stat_get_xact_blocks_{fetched,hit

2023-04-04 Thread Michael Paquier
doc: Add more details about pg_stat_get_xact_blocks_{fetched,hit} The explanation describing the dependency to system read() calls for these two functions has been removed in ddfc2d9. And after more discussion about d69c404, we have concluded that adding more details makes them easier to understa

pgsql: doc: Add more details about pg_stat_get_xact_blocks_{fetched,hit

2023-04-04 Thread Michael Paquier
doc: Add more details about pg_stat_get_xact_blocks_{fetched,hit} The explanation describing the dependency to system read() calls for these two functions has been removed in ddfc2d9. And after more discussion about d69c404, we have concluded that adding more details makes them easier to understa

pgsql: doc: Add more details about pg_stat_get_xact_blocks_{fetched,hit

2023-04-04 Thread Michael Paquier
doc: Add more details about pg_stat_get_xact_blocks_{fetched,hit} The explanation describing the dependency to system read() calls for these two functions has been removed in ddfc2d9. And after more discussion about d69c404, we have concluded that adding more details makes them easier to understa

pgsql: Fix MSVC warning introduced in ea1db8ae70.

2023-04-04 Thread Jeff Davis
Fix MSVC warning introduced in ea1db8ae70. Discussion: https://postgr.es/m/ca+hukgjr1bhcora5wdvwxztd3arhencwan1zeq1upg20bwj...@mail.gmail.com Reported-by: Thomas Munro Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/36320cbc164a8bc069f7a2d3990f47f5629f2020 Modifie

pgsql: Remove comment obsoleted by 11c2d6fd.

2023-04-04 Thread Thomas Munro
Remove comment obsoleted by 11c2d6fd. Reported-by: Tom Lane Discussion: https://postgr.es/m/1604497.1680637072%40sss.pgh.pa.us Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f303ec6210c4b858fd68531c92b8f0d490c91db5 Modified Files -- src/backend/optimi

pgsql: Canonicalize ICU locale names to language tags.

2023-04-04 Thread Jeff Davis
Canonicalize ICU locale names to language tags. Convert to BCP47 language tags before storing in the catalog, except during binary upgrade or when the locale comes from an existing collation or template database. The resulting language tags can vary slightly between ICU versions. For instance, "@

pgsql: Add a way to get the current function's OID in pl/pgsql.

2023-04-04 Thread Tom Lane
Add a way to get the current function's OID in pl/pgsql. Invent "GET DIAGNOSTICS oid_variable = PG_ROUTINE_OID". This is useful for avoiding the maintenance nuisances that come with embedding a function's name in its body, as one might do for logging purposes for example. Typically users would ca

pgsql: Add a run_as_owner option to subscriptions.

2023-04-04 Thread Robert Haas
Add a run_as_owner option to subscriptions. This option is normally false, but can be set to true to obtain the legacy behavior where the subscription runs with the permissions of the subscription owner rather than the permissions of the table owner. The advantages of this mode are (1) it doesn't

pgsql: Perform logical replication actions as the table owner.

2023-04-04 Thread Robert Haas
Perform logical replication actions as the table owner. Up until now, logical replication actions have been performed as the subscription owner, who will generally be a superuser. Commit cec57b1a0fbcd3833086ba686897c5883e0a2afc documented hazards associated with that situation, namely, that any u

pgsql: Add missing XML ID attributes

2023-04-04 Thread Peter Eisentraut
Add missing XML ID attributes Author: Brar Piening Discussion: https://www.postgresql.org/message-id/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3077324b03e81ab9894f1f510952273b78d98569 Modified Files --

pgsql: Code review for recent SQL/JSON commits

2023-04-04 Thread Alvaro Herrera
Code review for recent SQL/JSON commits - At the last minute and for no particularly good reason, I changed the WITHOUT token to be marked especially for lookahead, from the one in WITHOUT TIME to the one in WITHOUT UNIQUE. Study of upcoming patches (where a new WITHOUT ARRAY WRAPPER clause