pgsql: Skip the 004_io_direct.pl test if a pre-flight check fails.

2023-04-12 Thread Thomas Munro
Skip the 004_io_direct.pl test if a pre-flight check fails. The test previously had a list of OSes that direct I/O was expected to work on. That worked well enough for the systems in our build farm, but didn't survive contact with the Debian build bots running on tmpfs via overlayfs. tmpfs does

pgsql: Remove overzealous assertion from PHJ.

2023-04-12 Thread Thomas Munro
Remove overzealous assertion from PHJ. We can't assert that we're the only process attached to a barrier after BarrierArriveAndDetachExceptLast(). Although that'll be true almost always, a late-starting parallel worker can attach very briefly (that is, immediately detach after checking the phase)

pgsql: Revert "Adjust contrib/sepgsql regression test expected outputs.

2023-04-12 Thread Alvaro Herrera
Revert "Adjust contrib/sepgsql regression test expected outputs." This reverts commit 76c111a7f166; should have been included in 9ce04b50e120. Noted by Joe Conway Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/21e6bf4ddd045bc718c99ae551f25957ae91cb4d Modified Fil

Re: pgsql: Revert "Catalog NOT NULL constraints" and fallout

2023-04-12 Thread Alvaro Herrera
On 2023-Apr-12, Joe Conway wrote: > On 4/12/23 13:44, Alvaro Herrera wrote: > > Revert "Catalog NOT NULL constraints" and fallout > > > > This reverts commit e056c557aef4 and minor later fixes thereof. > > Seems 76c111a7f1 (as well as some other maybe) needs to be reverted as > well. Damn. Doi

Re: pgsql: Revert "Catalog NOT NULL constraints" and fallout

2023-04-12 Thread Joe Conway
On 4/12/23 13:44, Alvaro Herrera wrote: Revert "Catalog NOT NULL constraints" and fallout This reverts commit e056c557aef4 and minor later fixes thereof. Seems 76c111a7f1 (as well as some other maybe) needs to be reverted as well. -- Joe Conway PostgreSQL Contributors Team RDS Open Source D

Re: pgsql: Allow logical decoding on standbys

2023-04-12 Thread Andres Freund
Hi, On 2023-04-12 10:42:44 -0700, Andres Freund wrote: > On 2023-04-11 12:02:53 +0900, Kyotaro Horiguchi wrote: > > > Allow logical decoding on standbys > > > > This adds the following error message. > > > > + errmsg("logical decoding on a standby requires wal_level to be at least > > logical

pgsql: Improve error messages introduced in be87200efd9 and 0fdab27ad68

2023-04-12 Thread Andres Freund
Improve error messages introduced in be87200efd9 and 0fdab27ad68 Author: Kyotaro Horiguchi Discussion: https://postgr.es/m/[email protected] Discussion: https://postgr.es/m/[email protected] Branch -- master Details

pgsql: Revert "Catalog NOT NULL constraints" and fallout

2023-04-12 Thread Alvaro Herrera
Revert "Catalog NOT NULL constraints" and fallout This reverts commit e056c557aef4 and minor later fixes thereof. There's a few problems in this new feature -- most notably regarding pg_upgrade behavior, but others as well. This new feature is not in any way critical on its own, so instead of sc

Re: pgsql: Allow logical decoding on standbys

2023-04-12 Thread Andres Freund
Hi, On 2023-04-11 12:02:53 +0900, Kyotaro Horiguchi wrote: > > Allow logical decoding on standbys > > This adds the following error message. > > + errmsg("logical decoding on a standby requires wal_level to be at least > logical on the primary"))); > > We alredy have a nearly identical mes

pgsql: basebackup_to_shell: Check for a NULL return from OpenPipeStream

2023-04-12 Thread Robert Haas
basebackup_to_shell: Check for a NULL return from OpenPipeStream. Per complaint from Peter Eisentraut. Discussion: http://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8e82db97b0a474008d8212a63f34

pgsql: basebackup_to_shell: Check for a NULL return from OpenPipeStream

2023-04-12 Thread Robert Haas
basebackup_to_shell: Check for a NULL return from OpenPipeStream. Per complaint from Peter Eisentraut. Discussion: http://postgr.es/m/[email protected] Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fa83e9e23ca2542d04046

pgsql: Document BaseBackupSync and BaseBackupWrite wait events.

2023-04-12 Thread Robert Haas
Document BaseBackupSync and BaseBackupWrite wait events. Commit 3500ccc39b0dadd1068a03938e4b8ff562587ccc should have done this, but I overlooked it. Per complaint from Thomas Munro. Discussion: http://postgr.es/m/CA+hUKGJixAHc860Ej9Qzd_z96Z6aoajAgJ18bYfV3Lfn6t9=+q...@mail.gmail.com Branch

pgsql: Document BaseBackupSync and BaseBackupWrite wait events.

2023-04-12 Thread Robert Haas
Document BaseBackupSync and BaseBackupWrite wait events. Commit 3500ccc39b0dadd1068a03938e4b8ff562587ccc should have done this, but I overlooked it. Per complaint from Thomas Munro. Discussion: http://postgr.es/m/CA+hUKGJixAHc860Ej9Qzd_z96Z6aoajAgJ18bYfV3Lfn6t9=+q...@mail.gmail.com Branch

pgsql: Fix parallel-safety marking when moving initplans to another nod

2023-04-12 Thread Tom Lane
Fix parallel-safety marking when moving initplans to another node. Our policy since commit ab77a5a45 has been that a plan node having any initplans is automatically not parallel-safe. (This could be relaxed, but not today.) clean_up_removed_plan_level neglected this, and could attach initplans t

pgsql: Fix parallel-safety marking when moving initplans to another nod

2023-04-12 Thread Tom Lane
Fix parallel-safety marking when moving initplans to another node. Our policy since commit ab77a5a45 has been that a plan node having any initplans is automatically not parallel-safe. (This could be relaxed, but not today.) clean_up_removed_plan_level neglected this, and could attach initplans t

pgsql: Fix parallel-safety marking when moving initplans to another nod

2023-04-12 Thread Tom Lane
Fix parallel-safety marking when moving initplans to another node. Our policy since commit ab77a5a45 has been that a plan node having any initplans is automatically not parallel-safe. (This could be relaxed, but not today.) clean_up_removed_plan_level neglected this, and could attach initplans t

pgsql: Fix parallel-safety marking when moving initplans to another nod

2023-04-12 Thread Tom Lane
Fix parallel-safety marking when moving initplans to another node. Our policy since commit ab77a5a45 has been that a plan node having any initplans is automatically not parallel-safe. (This could be relaxed, but not today.) clean_up_removed_plan_level neglected this, and could attach initplans t

pgsql: Fix parallel-safety marking when moving initplans to another nod

2023-04-12 Thread Tom Lane
Fix parallel-safety marking when moving initplans to another node. Our policy since commit ab77a5a45 has been that a plan node having any initplans is automatically not parallel-safe. (This could be relaxed, but not today.) clean_up_removed_plan_level neglected this, and could attach initplans t

pgsql: Fix parallel-safety marking when moving initplans to another nod

2023-04-12 Thread Tom Lane
Fix parallel-safety marking when moving initplans to another node. Our policy since commit ab77a5a45 has been that a plan node having any initplans is automatically not parallel-safe. (This could be relaxed, but not today.) clean_up_removed_plan_level neglected this, and could attach initplans t

pgsql: doc: Reword unexplained abbreviation

2023-04-12 Thread Daniel Gustafsson
doc: Reword unexplained abbreviation The previous wording used MVF to indicate the Most Common Values' Frequencies, but the abbreviation was never explained or defined. Reword to mcv_freqs to make the use clearer. Also add MCF and MCV as acronyms as they were using markup but were missing from t

pgsql: Fix incorrect format placeholders

2023-04-12 Thread Peter Eisentraut
Fix incorrect format placeholders Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5f38a2034e4f18ad3a57421f070ae01c32137ef1 Modified Files -- src/backend/access/rmgrdesc/heapdesc.c | 2 +- src/backend/access/transam/xloginsert.c | 4 ++-- src/backend/utils

pgsql: Update config.guess and config.sub

2023-04-12 Thread Peter Eisentraut
Update config.guess and config.sub Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/906116ace1b8bc07161ee960015eb2b2d2a40118 Modified Files -- config/config.guess | 46 +- config/config.sub | 35 +++