pgsql: Restart the apply worker if the 'password_required' option is ch

2023-04-19 Thread Amit Kapila
Restart the apply worker if the 'password_required' option is changed. The apply worker is restarted if any subscription option that affects the remote connection was changed. In commit c3afe8cf5a, we added the option 'password_required' which can affect the remote connection, so we should

pgsql: Remove obsolete defense against strxfrm() bugs.

2023-04-19 Thread Thomas Munro
Remove obsolete defense against strxfrm() bugs. Old versions of Solaris and illumos had buffer overrun bugs in their strxfrm() implementations. The bugs were fixed more than a decade ago and the relevant releases are long out of vendor support. It's time to remove the defense added by commit

pgsql: Fix list_copy_head() with empty Lists

2023-04-19 Thread David Rowley
Fix list_copy_head() with empty Lists list_copy_head() given an empty List would crash from trying to dereference the List to obtain its length. Since NIL is how we represent an empty List, we should just be returning another empty List in this case. list_copy_head() is new to v16, so let's fix

pgsql: Use nbtdesc "level" field name consistently.

2023-04-19 Thread Peter Geoghegan
Use nbtdesc "level" field name consistently. The "lev" name that appeared in NEWROOT nbtree record desc output was inconsistent with the symbol name from the underlying C struct. It was also inconsistent with nbtdesc output for other nearby record types with similar level fields. Standardize on

pgsql: Fix wal_consistency_checking enhanced desc output.

2023-04-19 Thread Peter Geoghegan
Fix wal_consistency_checking enhanced desc output. Recent enhancements to rmgr desc routines that made the output summarize certain block data (added by commits 7d8219a4 and 1c453cfd) dealt with records that lack relevant block data (and so have nothing to give a more detailed summary of) by

pgsql: Add missed case for tab completion of GRANT/REVOKE MAINTAIN.

2023-04-19 Thread Tom Lane
Add missed case for tab completion of GRANT/REVOKE MAINTAIN. We failed to offer "ON" after "GRANT MAINTAIN". Oversight in commit 60684dd83. Ken Kato Discussion: https://postgr.es/m/6afe7712991882a864d6d10003264...@oss.nttdata.com Branch -- master Details ---

pgsql: Fix errormessage for missing system CA in OpenSSL 3.1

2023-04-19 Thread Daniel Gustafsson
Fix errormessage for missing system CA in OpenSSL 3.1 The error message for a missing or invalid system CA when using sslrootcert=system differs based on the OpenSSL version used. In OpenSSL 1.0.1-3.0 it is reported as SSL Error, with varying degrees of helpfulness in the error message. With

pgsql: Remove some tabs in SQL code in C string literals

2023-04-19 Thread Peter Eisentraut
Remove some tabs in SQL code in C string literals This is not handled uniformly throughout the code, but at least nearby code can be consistent. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/77dedeb2c45745f592b504e181fa9d391d9afff0 Modified Files --