pgsql: Use elog to report unexpected action in handle_streamed_transact

2023-04-23 Thread Masahiko Sawada
Use elog to report unexpected action in handle_streamed_transaction(). An oversight in commit 216a784829c. Author: Masahiko Sawada Reviewed-by: Kyotaro Horiguchi, Amit Kapila Discussion: https://postgr.es/m/cad21aoddbm8_hjt-nmcvcjtk8k9hpzxwqjj7pyauvr4mm_n...@mail.gmail.com Branch -- master

pgsql: Display 'password_required' option for \dRs+ command.

2023-04-23 Thread Amit Kapila
Display 'password_required' option for \dRs+ command. The commit c3afe8cf5a added a new subscription option 'password_required' which should be shown with \dRs+ command. Author: Vignesh C Reviewed-by: Amit Kapila, Robert Haas Discussion: https://postgr.es/m/caa4ek1lrz5sczxwcw6otpjltwpvrwbihqom4j

pgsql: Remove new .

2023-04-23 Thread Noah Misch
Remove new . Just intagg is obsolete, and having a one-entry list gives undue weight. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/244ab8c00c427d35901a6f1eb97e4e22b2916e7e Modified Files -

Re: pgsql: Import pg_bsd_indent sources.

2023-04-23 Thread Magnus Hagander
On Sun, Apr 23, 2023, 09:39 Tom Lane wrote: > Magnus Hagander writes: > > On Sat, Apr 22, 2023 at 4:25 PM Tom Lane wrote: > >> Magnus Hagander writes: > >>> It would perhaps be a good idea to push a README update to the > >>> pg_bsd_indent repo that states this? > > >> Good point. We could ei

Re: pgsql: Import pg_bsd_indent sources.

2023-04-23 Thread Tom Lane
Magnus Hagander writes: > On Sat, Apr 22, 2023 at 4:25 PM Tom Lane wrote: >> Magnus Hagander writes: >>> It would perhaps be a good idea to push a README update to the >>> pg_bsd_indent repo that states this? >> Good point. We could either do that or just take that repo down. >> I'm happy to p

Re: pgsql: Import pg_bsd_indent sources.

2023-04-23 Thread Magnus Hagander
On Sat, Apr 22, 2023 at 4:25 PM Tom Lane wrote: > > Magnus Hagander writes: > > The plan of this import is that the standalone git version is "dead", > > correct? Given we now have a version in-tree that's newer than the one > > in that repo? > > Right. > > > It would perhaps be a good idea to pu

pgsql: Validate ltree siglen GiST option to be int-aligned

2023-04-23 Thread Alexander Korotkov
Validate ltree siglen GiST option to be int-aligned Unaligned siglen could lead to an unaligned access to subsequent key fields. Backpatch to 13, where opclass options were introduced. Reported-by: Alexander Lakhin Bug: 17847 Discussion: https://postgr.es/m/17847-171232970bea406b%40postgresql.o

pgsql: Fix custom validators call in build_local_reloptions()

2023-04-23 Thread Alexander Korotkov
Fix custom validators call in build_local_reloptions() We need to call them only when validate == true. Backpatch to 13, where opclass options were introduced. Reported-by: Tom Lane Discussion: https://postgr.es/m/2656633.1681831542%40sss.pgh.pa.us Reviewed-by: Tom Lane, Pavel Borisov Backpatch-

pgsql: Validate ltree siglen GiST option to be int-aligned

2023-04-23 Thread Alexander Korotkov
Validate ltree siglen GiST option to be int-aligned Unaligned siglen could lead to an unaligned access to subsequent key fields. Backpatch to 13, where opclass options were introduced. Reported-by: Alexander Lakhin Bug: 17847 Discussion: https://postgr.es/m/17847-171232970bea406b%40postgresql.or

pgsql: Fix custom validators call in build_local_reloptions()

2023-04-23 Thread Alexander Korotkov
Fix custom validators call in build_local_reloptions() We need to call them only when validate == true. Backpatch to 13, where opclass options were introduced. Reported-by: Tom Lane Discussion: https://postgr.es/m/2656633.1681831542%40sss.pgh.pa.us Reviewed-by: Tom Lane, Pavel Borisov Backpatch-

pgsql: Fix custom validators call in build_local_reloptions()

2023-04-23 Thread Alexander Korotkov
Fix custom validators call in build_local_reloptions() We need to call them only when validate == true. Backpatch to 13, where opclass options were introduced. Reported-by: Tom Lane Discussion: https://postgr.es/m/2656633.1681831542%40sss.pgh.pa.us Reviewed-by: Tom Lane, Pavel Borisov Backpatch-

pgsql: Validate ltree siglen GiST option to be int-aligned

2023-04-23 Thread Alexander Korotkov
Validate ltree siglen GiST option to be int-aligned Unaligned siglen could lead to an unaligned access to subsequent key fields. Backpatch to 13, where opclass options were introduced. Reported-by: Alexander Lakhin Bug: 17847 Discussion: https://postgr.es/m/17847-171232970bea406b%40postgresql.or

pgsql: Fix custom validators call in build_local_reloptions()

2023-04-23 Thread Alexander Korotkov
Fix custom validators call in build_local_reloptions() We need to call them only when validate == true. Backpatch to 13, where opclass options were introduced. Reported-by: Tom Lane Discussion: https://postgr.es/m/2656633.1681831542%40sss.pgh.pa.us Reviewed-by: Tom Lane, Pavel Borisov Backpatch-

pgsql: Validate ltree siglen GiST option to be int-aligned

2023-04-23 Thread Alexander Korotkov
Validate ltree siglen GiST option to be int-aligned Unaligned siglen could lead to an unaligned access to subsequent key fields. Backpatch to 13, where opclass options were introduced. Reported-by: Alexander Lakhin Bug: 17847 Discussion: https://postgr.es/m/17847-171232970bea406b%40postgresql.or