pgsql: Reduce the log level in 035_standby_logical_decoding.pl.

2023-04-24 Thread Amit Kapila
Reduce the log level in 035_standby_logical_decoding.pl. Reduce the log level in 035_standby_logical_decoding.pl as the test doesn't require the higher log level. This helps to shrink the output size and speed up the test a bit. Author: Bertrand Drouvot Discussion: https://postgr.es/m/2fefa454-5a

pgsql: Fix buffer refcount leak with FDW bulk inserts

2023-04-24 Thread Michael Paquier
Fix buffer refcount leak with FDW bulk inserts The leak would show up when using batch inserts with foreign tables included in a partition tree, as the slots used in the batch were not reset once processed. In order to fix this problem, some ExecClearTuple() are added to clean up the slots used o

pgsql: Fix buffer refcount leak with FDW bulk inserts

2023-04-24 Thread Michael Paquier
Fix buffer refcount leak with FDW bulk inserts The leak would show up when using batch inserts with foreign tables included in a partition tree, as the slots used in the batch were not reset once processed. In order to fix this problem, some ExecClearTuple() are added to clean up the slots used o

pgsql: Fix buffer refcount leak with FDW bulk inserts

2023-04-24 Thread Michael Paquier
Fix buffer refcount leak with FDW bulk inserts The leak would show up when using batch inserts with foreign tables included in a partition tree, as the slots used in the batch were not reset once processed. In order to fix this problem, some ExecClearTuple() are added to clean up the slots used o

pgsql: Remove vacuum_defer_cleanup_age

2023-04-24 Thread Andres Freund
Remove vacuum_defer_cleanup_age vacuum_defer_cleanup_age was introduced before hot_standby_feedback and replication slots existed. It is hard to use reasonably - commonly it will either be set too low (not preventing recovery conflicts, while still causing some bloat), or too high (causing a lot o

pgsql: Fix memory leakage in plpgsql DO blocks that use cast expression

2023-04-24 Thread Tom Lane
Fix memory leakage in plpgsql DO blocks that use cast expressions. Commit 04fe805a1 modified plpgsql so that datatype casts make use of expressions cached by plancache.c, in place of older code where these expression trees were managed by plpgsql itself. However, I (tgl) forgot that we use a sepa

pgsql: Fix memory leakage in plpgsql DO blocks that use cast expression

2023-04-24 Thread Tom Lane
Fix memory leakage in plpgsql DO blocks that use cast expressions. Commit 04fe805a1 modified plpgsql so that datatype casts make use of expressions cached by plancache.c, in place of older code where these expression trees were managed by plpgsql itself. However, I (tgl) forgot that we use a sepa

pgsql: Fix memory leakage in plpgsql DO blocks that use cast expression

2023-04-24 Thread Tom Lane
Fix memory leakage in plpgsql DO blocks that use cast expressions. Commit 04fe805a1 modified plpgsql so that datatype casts make use of expressions cached by plancache.c, in place of older code where these expression trees were managed by plpgsql itself. However, I (tgl) forgot that we use a sepa

pgsql: Fix memory leakage in plpgsql DO blocks that use cast expression

2023-04-24 Thread Tom Lane
Fix memory leakage in plpgsql DO blocks that use cast expressions. Commit 04fe805a1 modified plpgsql so that datatype casts make use of expressions cached by plancache.c, in place of older code where these expression trees were managed by plpgsql itself. However, I (tgl) forgot that we use a sepa

pgsql: Fix memory leakage in plpgsql DO blocks that use cast expression

2023-04-24 Thread Tom Lane
Fix memory leakage in plpgsql DO blocks that use cast expressions. Commit 04fe805a1 modified plpgsql so that datatype casts make use of expressions cached by plancache.c, in place of older code where these expression trees were managed by plpgsql itself. However, I (tgl) forgot that we use a sepa

pgsql: Rename ExecAggTransReparent, and improve its documentation.

2023-04-24 Thread Tom Lane
Rename ExecAggTransReparent, and improve its documentation. The name of this function suggests that it ought to reparent R/W expanded objects to be children of the persistent aggcontext, instead of copying them. In fact it does no such thing, and if you try to make it do so you will see multiple

pgsql: doc: Update SQL features names

2023-04-24 Thread Peter Eisentraut
doc: Update SQL features names Some feature names have been adjusted over time upstream. This pulls in those changes. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5a8366ad75eb70cffa791119b404c897983260c6 Modified Files -- src/backend/catalog/sql_fea

pgsql: ci: Remove OpenSSL 3.1 workaround for missing system CA

2023-04-24 Thread Daniel Gustafsson
ci: Remove OpenSSL 3.1 workaround for missing system CA Commit 0b5d1fb36 fixed the SSL test to properly handle the error message from OpenSSL when the system CA pool is missing of invalid, so with that we can remove the workaround in Cirrus for when Homebrew clears the cert from OPENSSLDIR. Autho

pgsql: Remove duplicate lines of code

2023-04-24 Thread Daniel Gustafsson
Remove duplicate lines of code Commit 6df7a9698bb accidentally included two identical prototypes for default_multirange_selectivi() and commit 086cf1458c6 added a break; statement where one was already present, thus duplicating it. While there is no bug caused by this, fix by removing the duplica

pgsql: Remove duplicate lines of code

2023-04-24 Thread Daniel Gustafsson
Remove duplicate lines of code Commit 6df7a9698bb accidentally included two identical prototypes for default_multirange_selectivi() and commit 086cf1458c6 added a break; statement where one was already present, thus duplicating it. While there is no bug caused by this, fix by removing the duplica

pgsql: Remove duplicate lines of code

2023-04-24 Thread Daniel Gustafsson
Remove duplicate lines of code Commit 6df7a9698bb accidentally included two identical prototypes for default_multirange_selectivi() and commit 086cf1458c6 added a break; statement where one was already present, thus duplicating it. While there is no bug caused by this, fix by removing the duplica

pgsql: Remove duplicate lines of code

2023-04-24 Thread Daniel Gustafsson
Remove duplicate lines of code Commit 6df7a9698bb accidentally included two identical prototypes for default_multirange_selectivi() and commit 086cf1458c6 added a break; statement where one was already present, thus duplicating it. While there is no bug caused by this, fix by removing the duplica

pgsql: Remove duplicate lines of code

2023-04-24 Thread Daniel Gustafsson
Remove duplicate lines of code Commit 6df7a9698bb accidentally included two identical prototypes for default_multirange_selectivi() and commit 086cf1458c6 added a break; statement where one was already present, thus duplicating it. While there is no bug caused by this, fix by removing the duplica

pgsql: Remove duplicate lines of code

2023-04-24 Thread Daniel Gustafsson
Remove duplicate lines of code Commit 6df7a9698bb accidentally included two identical prototypes for default_multirange_selectivi() and commit 086cf1458c6 added a break; statement where one was already present, thus duplicating it. While there is no bug caused by this, fix by removing the duplica