Re: pgsql: Refactor background psql TAP functions

2023-04-25 Thread Peter Eisentraut
On 07.04.23 22:21, Daniel Gustafsson wrote: Refactor background psql TAP functions This breaks out the background and interactive psql functionality into a new class, PostgreSQL::Test::BackgroundPsql. The new file also needs to be installed in src/test/perl/{Makefile,meson.build}.

pgsql: Remove bogus #include added by d4e71df6d75.

2023-04-25 Thread Thomas Munro
Remove bogus #include added by d4e71df6d75. The recently added inclusion of guc.h in smgr.h is not necessary and introduces more server-related stuff. Removing the directive helps avoid potential issues with including sgmr.h in frontends. Author: Kyotaro Horiguchi Discussion: https://postgr.es/

pgsql: Re-add tracking of wait event SLRUFlushSync

2023-04-25 Thread Michael Paquier
Re-add tracking of wait event SLRUFlushSync SLRUFlushSync has been accidently removed during dee663f, that has moved the flush of the SLRU files to the checkpointer, so add it back. The issue has been noticed by Thomas when checking for orphaned wait events. Author: Thomas Munro Reviewed-by: Bha

pgsql: Re-add tracking of wait event SLRUFlushSync

2023-04-25 Thread Michael Paquier
Re-add tracking of wait event SLRUFlushSync SLRUFlushSync has been accidently removed during dee663f, that has moved the flush of the SLRU files to the checkpointer, so add it back. The issue has been noticed by Thomas when checking for orphaned wait events. Author: Thomas Munro Reviewed-by: Bha

pgsql: Re-add tracking of wait event SLRUFlushSync

2023-04-25 Thread Michael Paquier
Re-add tracking of wait event SLRUFlushSync SLRUFlushSync has been accidently removed during dee663f, that has moved the flush of the SLRU files to the checkpointer, so add it back. The issue has been noticed by Thomas when checking for orphaned wait events. Author: Thomas Munro Reviewed-by: Bha

pgsql: Fix vacuum_cost_delay check for balance calculation.

2023-04-25 Thread Daniel Gustafsson
Fix vacuum_cost_delay check for balance calculation. Commit 1021bd6a89 excluded autovacuum workers from cost-limit balance calculations when per-relation options were set. The code checks for limit and cost_delay being greater than zero, but since cost_delay can be set to -1 the test needs to che

pgsql: Fix vacuum_cost_delay check for balance calculation.

2023-04-25 Thread Daniel Gustafsson
Fix vacuum_cost_delay check for balance calculation. Commit 1021bd6a89 excluded autovacuum workers from cost-limit balance calculations when per-relation options were set. The code checks for limit and cost_delay being greater than zero, but since cost_delay can be set to -1 the test needs to che

pgsql: Fix vacuum_cost_delay check for balance calculation.

2023-04-25 Thread Daniel Gustafsson
Fix vacuum_cost_delay check for balance calculation. Commit 1021bd6a89 excluded autovacuum workers from cost-limit balance calculations when per-relation options were set. The code checks for limit and cost_delay being greater than zero, but since cost_delay can be set to -1 the test needs to che

pgsql: Fix vacuum_cost_delay check for balance calculation.

2023-04-25 Thread Daniel Gustafsson
Fix vacuum_cost_delay check for balance calculation. Commit 1021bd6a89 excluded autovacuum workers from cost-limit balance calculations when per-relation options were set. The code checks for limit and cost_delay being greater than zero, but since cost_delay can be set to -1 the test needs to che

pgsql: Fix vacuum_cost_delay check for balance calculation.

2023-04-25 Thread Daniel Gustafsson
Fix vacuum_cost_delay check for balance calculation. Commit 1021bd6a89 excluded autovacuum workers from cost-limit balance calculations when per-relation options were set. The code checks for limit and cost_delay being greater than zero, but since cost_delay can be set to -1 the test needs to che

pgsql: Fix vacuum_cost_delay check for balance calculation.

2023-04-25 Thread Daniel Gustafsson
Fix vacuum_cost_delay check for balance calculation. Commit 1021bd6a89 excluded autovacuum workers from cost-limit balance calculations when per-relation options were set. The code checks for limit and cost_delay being greater than zero, but since cost_delay can be set to -1 the test needs to che