pgsql: Rework code defining default compression for dir/custom formats

2023-04-26 Thread Michael Paquier
Rework code defining default compression for dir/custom formats in pg_dump As written, pg_dump would call twice parse_compress_specification() for the custom and directory formats to build a compression specification if no compression option is defined, as these formats should be compressed by def

issue with meson builds on msys2

2023-04-26 Thread Andrew Dunstan
[redirecting to -hackers] On 2023-04-20 Th 15:37, Andrew Dunstan wrote: On 2023-04-20 Th 11:06, Andres Freund wrote: On 2023-04-17 16:22:30 -0400, Andrew Dunstan wrote: I am still having Windows issues with meson, but only with MSYS2. Any more details on that? I might be able to help out

pgsql: Fix stop condition for dumping GRANT commands

2023-04-26 Thread Daniel Gustafsson
Fix stop condition for dumping GRANT commands Commit ce6b672e44 changed dumping GRANT commands to ensure that grantors already have an ADMIN OPTION on the role for which it is granting permissions. Looping over the grants per role has a stop condition on dumping the grant statements, but accidenta

pgsql: doc: Fix grammar.

2023-04-26 Thread Etsuro Fujita
doc: Fix grammar. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4def50eba99e0a7e9b4c09fa3e33209d6d6fb834 Modified Files -- doc/src/sgml/postgres-fdw.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgsql: Fix missing installation rules for BackgroundPsql.pm

2023-04-26 Thread Daniel Gustafsson
Fix missing installation rules for BackgroundPsql.pm Commit 664d75753 added the BackgroundPsql module with helper functions for tests running interactive or background psql tasks. The new module was however not added to the install rules of the build systems. Reported-by: Peter Eisentraut Discus

Re: pgsql: Refactor background psql TAP functions

2023-04-26 Thread Daniel Gustafsson
> On 26 Apr 2023, at 08:28, Peter Eisentraut > wrote: > > On 07.04.23 22:21, Daniel Gustafsson wrote: >> Refactor background psql TAP functions >> This breaks out the background and interactive psql functionality into a >> new class, PostgreSQL::Test::BackgroundPsql. > > The new file also needs