pgsql: Add unit to vacuum_buffer_usage_limit value in postgresql.conf.s

2023-04-27 Thread Masahiko Sawada
Add unit to vacuum_buffer_usage_limit value in postgresql.conf.sample. Also adjust the indentation of the comment to the surrounding parameters. Author: Masahiko Sawada Reviewed-by: David Rowley, Daniel Gustafsson, Melanie Plageman Discussion: https://postgr.es/m/cad21aocbsqmqokvh4q256decc_ue50g

pgsql: Prevent underflow in KeepLogSeg().

2023-04-27 Thread Nathan Bossart
Prevent underflow in KeepLogSeg(). The call to XLogGetReplicationSlotMinimumLSN() might return a greater LSN than the one given to the function. Subsequent segment number calculations might then underflow, which could result in unexpected behavior when removing or recyling WAL files. This was in

pgsql: Prevent underflow in KeepLogSeg().

2023-04-27 Thread Nathan Bossart
Prevent underflow in KeepLogSeg(). The call to XLogGetReplicationSlotMinimumLSN() might return a greater LSN than the one given to the function. Subsequent segment number calculations might then underflow, which could result in unexpected behavior when removing or recyling WAL files. This was in

pgsql: Prevent underflow in KeepLogSeg().

2023-04-27 Thread Nathan Bossart
Prevent underflow in KeepLogSeg(). The call to XLogGetReplicationSlotMinimumLSN() might return a greater LSN than the one given to the function. Subsequent segment number calculations might then underflow, which could result in unexpected behavior when removing or recyling WAL files. This was in

pgsql: Prevent underflow in KeepLogSeg().

2023-04-27 Thread Nathan Bossart
Prevent underflow in KeepLogSeg(). The call to XLogGetReplicationSlotMinimumLSN() might return a greater LSN than the one given to the function. Subsequent segment number calculations might then underflow, which could result in unexpected behavior when removing or recyling WAL files. This was in

pgsql: Improve one of the test cases in 035_standby_logical_decoding.pl

2023-04-27 Thread Amit Kapila
Improve one of the test cases in 035_standby_logical_decoding.pl. The test to ensure that decoding changes via logical slot from another database will fail was incorrectly done on the primary node instead of on the standby node. In the passing, make the test to wait for replay catchup by using wa

pgsql: Fix wrong construct_array_builtin() call in GUCArrayDelete()

2023-04-27 Thread Alexander Korotkov
Fix wrong construct_array_builtin() call in GUCArrayDelete() The current code unintentionally uses the wrong datum to construct an array. The bug was introduced by 096dd80f3c, so no backpatching is needed. Reported-by: David Steele Discussion: https://postgr.es/m/d46f9265-ff3c-6743-2278-67725982

pgsql: In hstore_plpython, avoid crashing when return value isn't a map

2023-04-27 Thread Tom Lane
In hstore_plpython, avoid crashing when return value isn't a mapping. Python 3 changed the behavior of PyMapping_Check(), breaking the test in plpython_to_hstore() that verifies whether a function result to be transformed is acceptable. A backwards-compatible fix is to first verify that the objec

pgsql: In hstore_plpython, avoid crashing when return value isn't a map

2023-04-27 Thread Tom Lane
In hstore_plpython, avoid crashing when return value isn't a mapping. Python 3 changed the behavior of PyMapping_Check(), breaking the test in plpython_to_hstore() that verifies whether a function result to be transformed is acceptable. A backwards-compatible fix is to first verify that the objec

pgsql: In hstore_plpython, avoid crashing when return value isn't a map

2023-04-27 Thread Tom Lane
In hstore_plpython, avoid crashing when return value isn't a mapping. Python 3 changed the behavior of PyMapping_Check(), breaking the test in plpython_to_hstore() that verifies whether a function result to be transformed is acceptable. A backwards-compatible fix is to first verify that the objec

pgsql: In hstore_plpython, avoid crashing when return value isn't a map

2023-04-27 Thread Tom Lane
In hstore_plpython, avoid crashing when return value isn't a mapping. Python 3 changed the behavior of PyMapping_Check(), breaking the test in plpython_to_hstore() that verifies whether a function result to be transformed is acceptable. A backwards-compatible fix is to first verify that the objec

pgsql: In hstore_plpython, avoid crashing when return value isn't a map

2023-04-27 Thread Tom Lane
In hstore_plpython, avoid crashing when return value isn't a mapping. Python 3 changed the behavior of PyMapping_Check(), breaking the test in plpython_to_hstore() that verifies whether a function result to be transformed is acceptable. A backwards-compatible fix is to first verify that the objec

pgsql: In hstore_plpython, avoid crashing when return value isn't a map

2023-04-27 Thread Tom Lane
In hstore_plpython, avoid crashing when return value isn't a mapping. Python 3 changed the behavior of PyMapping_Check(), breaking the test in plpython_to_hstore() that verifies whether a function result to be transformed is acceptable. A backwards-compatible fix is to first verify that the objec

pgsql: Add a test to verify that subscription to the standby works.

2023-04-27 Thread Amit Kapila
Add a test to verify that subscription to the standby works. Author: Bertrand Drouvot Reviewed-by: Vignesh C, Alvaro Herrera, Amit Kapila Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3