pgsql: Fix incorrect TAP test ordering

2023-05-14 Thread Peter Eisentraut
Fix incorrect TAP test ordering Using a test function before a possible skip_all is incorrect. If the skip_all is called, the test output will become incorrect and the test file will fail. a4f23f9b3c introduced a new test before skip_all. After discussion, this doesn't really need to be a test.

pgsql: Fix whitespace inconsistencies

2023-05-14 Thread Peter Eisentraut
Fix whitespace inconsistencies Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1d70fb400c2c8312dac3ff19a1bb1cb5351047ce Modified Files -- src/bin/pg_amcheck/t/004_verify_heapam.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgsql: Fix wal_writer_flush_after initializer value.

2023-05-14 Thread Thomas Munro
Fix wal_writer_flush_after initializer value. Commit a73952b7956 (new in 16) required default values in guc_table.c and C variable initializers to match. This one only matched when XLOG_BLCKSZ == 8kB. Fix by using the same expression in both places with a new DEFAULT_XXX macro, as done for other

pgsql: Rename io_direct to debug_io_direct.

2023-05-14 Thread Thomas Munro
Rename io_direct to debug_io_direct. Give the new GUC introduced by d4e71df6 a name that is clearly not intended for mainstream use quite yet. Future proposals would drop the prefix only after adding infrastructure to make it efficient. Having the switch in the tree sooner is good because it mig