Re: pgsql: Fix search_path to a safe value during maintenance operations.

2023-06-09 Thread Tom Lane
Jeff Davis writes: > Attached a patch to mark those functions as PARALLEL UNSAFE, which > fixes the problem. > Alternatively, I could just take out that line, as those SQL functions > are not controlled by the MAINTAIN privilege. But for consistency I > think it's a good idea to leave it in so th

pgsql: meson: Add dependencies to perl modules to various script invoca

2023-06-09 Thread Andres Freund
meson: Add dependencies to perl modules to various script invocations Eventually it is likely worth trying to deal with this in a more expansive way, by generating dependency files generated within the scripts. But it's not entirely obvious how to do that in perl and is work more suitable for 17 a

pgsql: doc: PG 16 relnotes, add author

2023-06-09 Thread Bruce Momjian
doc: PG 16 relnotes, add author Reported-by: Masahiko Sawada Discussion: https://postgr.es/m/cad21aodp46y+1yumikywhcfkhseuoxmhq2sv8_pyqom1uwb...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b9e3f8005c99dece44d60cdfad5b904554f4d435 Modified File

Re: pgsql: Fix search_path to a safe value during maintenance operations.

2023-06-09 Thread Jeff Davis
On Fri, 2023-06-09 at 17:37 -0700, Jeff Davis wrote: > Attached a patch to mark those functions as PARALLEL UNSAFE, which > fixes the problem. On second thought, that might not be acceptable for amcheck, depending on how its run. I think it's OK if run by pg_amcheck, because that runs it on a sin

Re: pgsql: Fix search_path to a safe value during maintenance operations.

2023-06-09 Thread Jeff Davis
On Fri, 2023-06-09 at 15:16 -0700, Jeff Davis wrote: > On Fri, 2023-06-09 at 20:54 +, Jeff Davis wrote: > > Fix search_path to a safe value during maintenance operations. > > Looks like this is causing pg_amcheck failures in the buildfarm. > Investigating... It looks related to bt_index_check

Re: pgsql: Fix search_path to a safe value during maintenance operations.

2023-06-09 Thread Jeff Davis
On Fri, 2023-06-09 at 20:54 +, Jeff Davis wrote: > Fix search_path to a safe value during maintenance operations. Looks like this is causing pg_amcheck failures in the buildfarm. Investigating... Regards, Jeff Davis

pgsql: Fix search_path to a safe value during maintenance operations.

2023-06-09 Thread Jeff Davis
Fix search_path to a safe value during maintenance operations. While executing maintenance operations (ANALYZE, CLUSTER, REFRESH MATERIALIZED VIEW, REINDEX, or VACUUM), set search_path to 'pg_catalog, pg_temp' to prevent inconsistent behavior. Functions that are used for functional indexes, in in