pgsql: test_extensions: make meson.build consistent with Makefile.

2023-06-19 Thread Jeff Davis
test_extensions: make meson.build consistent with Makefile. Specify --no-locale and --encoding=UTF8 to be consistent with the Makefile, which specifies NO_LOCALE=1. Fixes test for some locales when meson is used and ICU is disabled. May have been an oversight in e6927270cd. Also switch argument o

pgsql: Enable archiving in recovery TAP test 009_twophase.pl

2023-06-19 Thread Michael Paquier
Enable archiving in recovery TAP test 009_twophase.pl This is a follow-up of f663b00, that has been committed to v13 and v14, tweaking the TAP test for two-phase transactions so as it provides coverage for the bug that has been fixed. This change is done in its own commit for clarity, as v15 and

pgsql: Enable archiving in recovery TAP test 009_twophase.pl

2023-06-19 Thread Michael Paquier
Enable archiving in recovery TAP test 009_twophase.pl This is a follow-up of f663b00, that has been committed to v13 and v14, tweaking the TAP test for two-phase transactions so as it provides coverage for the bug that has been fixed. This change is done in its own commit for clarity, as v15 and

pgsql: Enable archiving in recovery TAP test 009_twophase.pl

2023-06-19 Thread Michael Paquier
Enable archiving in recovery TAP test 009_twophase.pl This is a follow-up of f663b00, that has been committed to v13 and v14, tweaking the TAP test for two-phase transactions so as it provides coverage for the bug that has been fixed. This change is done in its own commit for clarity, as v15 and

pgsql: Enable archiving in recovery TAP test 009_twophase.pl

2023-06-19 Thread Michael Paquier
Enable archiving in recovery TAP test 009_twophase.pl This is a follow-up of f663b00, that has been committed to v13 and v14, tweaking the TAP test for two-phase transactions so as it provides coverage for the bug that has been fixed. This change is done in its own commit for clarity, as v15 and

pgsql: Fix failure at promotion with 2PC transactions and archiving ena

2023-06-19 Thread Michael Paquier
Fix failure at promotion with 2PC transactions and archiving enabled When archiving is enabled, a promotion request would fail with the following error when some 2PC transaction needs to be recovered from WAL, preventing the promotion to complete: FATAL: requested WAL segment pg_wal/00010

pgsql: Fix failure at promotion with 2PC transactions and archiving ena

2023-06-19 Thread Michael Paquier
Fix failure at promotion with 2PC transactions and archiving enabled When archiving is enabled, a promotion request would fail with the following error when some 2PC transaction needs to be recovered from WAL, preventing the promotion to complete: FATAL: requested WAL segment pg_wal/00010

Re: pgsql: Fix search_path to a safe value during maintenance operations.

2023-06-19 Thread Jeff Davis
On Mon, 2023-06-19 at 16:03 -0400, Robert Haas wrote: > I'm inclined to think that this is a real security issue and am not Can you expand on that a bit? You mean a practical security issue for the intended use cases? > very sanguine about waiting another year to fix it, but at the same > time, I

pgsql: fd.c: Retry after EINTR in more places

2023-06-19 Thread Andres Freund
fd.c: Retry after EINTR in more places Starting with 4d330a61bb1 we can use posix_fallocate() to extend files. Unfortunately in some situation, e.g. on tmpfs filesystems, EINTR may be returned. See also 4518c798b2b. To fix, add a retry path to FileFallocate(). In contrast to 4518c798b2b the amoun

Re: pgsql: Fix search_path to a safe value during maintenance operations.

2023-06-19 Thread Robert Haas
On Thu, Jun 15, 2023 at 12:59 AM Jeff Davis wrote: > On Tue, 2023-06-13 at 16:23 -0400, Tom Lane wrote: > > What I'm concerned about is making such a fundamental semantics > > change > > post-beta1. > > I have added the patch to the July CF for v17. > > If someone does feel like something should b

pgsql: pg_regress: for --no-locale, use LOCALE='C'.

2023-06-19 Thread Jeff Davis
pg_regress: for --no-locale, use LOCALE='C'. Instead of specifying LC_COLLATE='C' and LC_CTYPE='C', specify LOCALE='C' which will also affect ICU. This makes pg_regress consistent with recent changes to initdb in commit a14e75eb0b6. Fixes buildfarm failure. Discussion: https://postgr.es/m/245856