pgsql: Fix indentation in twophase.c

2023-07-17 Thread Michael Paquier
Fix indentation in twophase.c This has been missed in cb0cca1, noticed before buildfarm member koel has been able to complain while poking at a different patch. Like the other commit, backpatch all the way down to limit the odds of merge conflicts. Backpatch-through: 11 Branch -- master De

pgsql: Fix indentation in twophase.c

2023-07-17 Thread Michael Paquier
Fix indentation in twophase.c This has been missed in cb0cca1, noticed before buildfarm member koel has been able to complain while poking at a different patch. Like the other commit, backpatch all the way down to limit the odds of merge conflicts. Backpatch-through: 11 Branch -- REL_11_STA

pgsql: Fix indentation in twophase.c

2023-07-17 Thread Michael Paquier
Fix indentation in twophase.c This has been missed in cb0cca1, noticed before buildfarm member koel has been able to complain while poking at a different patch. Like the other commit, backpatch all the way down to limit the odds of merge conflicts. Backpatch-through: 11 Branch -- REL_14_STA

pgsql: Fix indentation in twophase.c

2023-07-17 Thread Michael Paquier
Fix indentation in twophase.c This has been missed in cb0cca1, noticed before buildfarm member koel has been able to complain while poking at a different patch. Like the other commit, backpatch all the way down to limit the odds of merge conflicts. Backpatch-through: 11 Branch -- REL_15_STA

pgsql: Fix indentation in twophase.c

2023-07-17 Thread Michael Paquier
Fix indentation in twophase.c This has been missed in cb0cca1, noticed before buildfarm member koel has been able to complain while poking at a different patch. Like the other commit, backpatch all the way down to limit the odds of merge conflicts. Backpatch-through: 11 Branch -- REL_13_STA

pgsql: Fix indentation in twophase.c

2023-07-17 Thread Michael Paquier
Fix indentation in twophase.c This has been missed in cb0cca1, noticed before buildfarm member koel has been able to complain while poking at a different patch. Like the other commit, backpatch all the way down to limit the odds of merge conflicts. Backpatch-through: 11 Branch -- REL_12_STA

pgsql: Fix indentation in twophase.c

2023-07-17 Thread Michael Paquier
Fix indentation in twophase.c This has been missed in cb0cca1, noticed before buildfarm member koel has been able to complain while poking at a different patch. Like the other commit, backpatch all the way down to limit the odds of merge conflicts. Backpatch-through: 11 Branch -- REL_16_STA

pgsql: Fix recovery of 2PC transaction during crash recovery

2023-07-17 Thread Michael Paquier
Fix recovery of 2PC transaction during crash recovery A crash in the middle of a checkpoint with some two-phase state data already flushed to disk by this checkpoint could cause a follow-up crash recovery to recover twice the same transaction, once from what has been found in pg_twophase/ at the b

pgsql: Fix recovery of 2PC transaction during crash recovery

2023-07-17 Thread Michael Paquier
Fix recovery of 2PC transaction during crash recovery A crash in the middle of a checkpoint with some two-phase state data already flushed to disk by this checkpoint could cause a follow-up crash recovery to recover twice the same transaction, once from what has been found in pg_twophase/ at the b

pgsql: Fix recovery of 2PC transaction during crash recovery

2023-07-17 Thread Michael Paquier
Fix recovery of 2PC transaction during crash recovery A crash in the middle of a checkpoint with some two-phase state data already flushed to disk by this checkpoint could cause a follow-up crash recovery to recover twice the same transaction, once from what has been found in pg_twophase/ at the b

pgsql: Fix recovery of 2PC transaction during crash recovery

2023-07-17 Thread Michael Paquier
Fix recovery of 2PC transaction during crash recovery A crash in the middle of a checkpoint with some two-phase state data already flushed to disk by this checkpoint could cause a follow-up crash recovery to recover twice the same transaction, once from what has been found in pg_twophase/ at the b

pgsql: Fix recovery of 2PC transaction during crash recovery

2023-07-17 Thread Michael Paquier
Fix recovery of 2PC transaction during crash recovery A crash in the middle of a checkpoint with some two-phase state data already flushed to disk by this checkpoint could cause a follow-up crash recovery to recover twice the same transaction, once from what has been found in pg_twophase/ at the b

pgsql: Fix recovery of 2PC transaction during crash recovery

2023-07-17 Thread Michael Paquier
Fix recovery of 2PC transaction during crash recovery A crash in the middle of a checkpoint with some two-phase state data already flushed to disk by this checkpoint could cause a follow-up crash recovery to recover twice the same transaction, once from what has been found in pg_twophase/ at the b

pgsql: Fix recovery of 2PC transaction during crash recovery

2023-07-17 Thread Michael Paquier
Fix recovery of 2PC transaction during crash recovery A crash in the middle of a checkpoint with some two-phase state data already flushed to disk by this checkpoint could cause a follow-up crash recovery to recover twice the same transaction, once from what has been found in pg_twophase/ at the b

pgsql: Include in fe-auth.c, to get CHAR_BIT reliably.

2023-07-17 Thread Tom Lane
Include in fe-auth.c, to get CHAR_BIT reliably. fe-auth.c references CHAR_BIT since commit 3a465cc67, but it did not #include , which per POSIX is where that symbol is defined. This escaped notice so far because (a) on most platforms, pulls in , (b) even if yours doesn't, OpenSSL pulls it in, s

pgsql: Include in fe-auth.c, to get CHAR_BIT reliably.

2023-07-17 Thread Tom Lane
Include in fe-auth.c, to get CHAR_BIT reliably. fe-auth.c references CHAR_BIT since commit 3a465cc67, but it did not #include , which per POSIX is where that symbol is defined. This escaped notice so far because (a) on most platforms, pulls in , (b) even if yours doesn't, OpenSSL pulls it in, s

pgsql: Remove db_user_namespace.

2023-07-17 Thread Nathan Bossart
Remove db_user_namespace. This feature was intended to be a temporary measure to support per-database user names. A better one hasn't materialized in the ~21 years since it was added, and nobody claims to be using it, so let's just remove it. Reviewed-by: Michael Paquier, Magnus Hagander Discuss