pgsql: Some vertical reformatting

Some vertical reformatting Remove some line breaks that have become unnecessary after some variable renaming. Discussion: https://www.postgresql.org/message-id/flat/5ed89c69-f4e6-5dab-4003-63bde7460e5e%40eisentraut.org Branch -- master Details ---

pgsql: Rename some function arguments for better clarity

Rename some function arguments for better clarity Especially make sure that array arguments have plural names. Discussion: https://www.postgresql.org/message-id/flat/5ed89c69-f4e6-5dab-4003-63bde7460e5e%40eisentraut.org Branch -- master Details ---

pgsql: Add const decorations

Add const decorations in index.c and indexcmds.c and some adjacent places. This especially makes it easier to understand for some complicated function signatures which are the input and the output arguments. Discussion:

pgsql: Introduce macros for protocol characters.

Introduce macros for protocol characters. This commit introduces descriptively-named macros for the identifiers used in wire protocol messages. These new macros are placed in a new header file so that they can be easily used by third-party code. Author: Dave Cramer Reviewed-by: Alvaro Herrera,

pgsql: ExtendBufferedWhat -> BufferManagerRelation.

ExtendBufferedWhat -> BufferManagerRelation. Commit 31966b15 invented a way for functions dealing with relation extension to accept a Relation in online code and an SMgrRelation in recovery code. It seems highly likely that future bufmgr.c interfaces will face the same problem, and need to do

pgsql: ExtendBufferedWhat -> BufferManagerRelation.

ExtendBufferedWhat -> BufferManagerRelation. Commit 31966b15 invented a way for functions dealing with relation extension to accept a Relation in online code and an SMgrRelation in recovery code. It seems highly likely that future bufmgr.c interfaces will face the same problem, and need to do

pgsql: doc: PG 16 relnotes: properly indent and word-wrap text

doc: PG 16 relnotes: properly indent and word-wrap text Backpatch-through: 16 only Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d8cd49e992eb0d0f3d447d6b41866ce1b573b01d Modified Files -- doc/src/sgml/release-16.sgml | 3469

pgsql: Fix pg_dump assertion failure when dumping pg_catalog.

Fix pg_dump assertion failure when dumping pg_catalog. Commit 396d348b04 did not account for the default collation. Also, use pg_log_warning() instead of Assert(). Discussion: https://postgr.es/m/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com Reviewed-by: Michael Paquier

pgsql: Fix pg_dump assertion failure when dumping pg_catalog.

Fix pg_dump assertion failure when dumping pg_catalog. Commit 396d348b04 did not account for the default collation. Also, use pg_log_warning() instead of Assert(). Discussion: https://postgr.es/m/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com Reviewed-by: Michael Paquier

pgsql: Fix pg_dump assertion failure when dumping pg_catalog.

Fix pg_dump assertion failure when dumping pg_catalog. Commit 396d348b04 did not account for the default collation. Also, use pg_log_warning() instead of Assert(). Discussion: https://postgr.es/m/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com Reviewed-by: Michael Paquier

pgsql: Cache by-reference missing values in a long lived context

Cache by-reference missing values in a long lived context Attribute missing values might be needed past the lifetime of the tuple descriptors from which they are extracted. To avoid possibly using pointers for by-reference values which might thus be left dangling, we cache a datumCopy'd version

pgsql: Cache by-reference missing values in a long lived context

Cache by-reference missing values in a long lived context Attribute missing values might be needed past the lifetime of the tuple descriptors from which they are extracted. To avoid possibly using pointers for by-reference values which might thus be left dangling, we cache a datumCopy'd version

pgsql: Cache by-reference missing values in a long lived context

Cache by-reference missing values in a long lived context Attribute missing values might be needed past the lifetime of the tuple descriptors from which they are extracted. To avoid possibly using pointers for by-reference values which might thus be left dangling, we cache a datumCopy'd version

pgsql: Cache by-reference missing values in a long lived context

Cache by-reference missing values in a long lived context Attribute missing values might be needed past the lifetime of the tuple descriptors from which they are extracted. To avoid possibly using pointers for by-reference values which might thus be left dangling, we cache a datumCopy'd version

pgsql: Cache by-reference missing values in a long lived context

Cache by-reference missing values in a long lived context Attribute missing values might be needed past the lifetime of the tuple descriptors from which they are extracted. To avoid possibly using pointers for by-reference values which might thus be left dangling, we cache a datumCopy'd version

pgsql: Cache by-reference missing values in a long lived context

Cache by-reference missing values in a long lived context Attribute missing values might be needed past the lifetime of the tuple descriptors from which they are extracted. To avoid possibly using pointers for by-reference values which might thus be left dangling, we cache a datumCopy'd version

pgsql: doc: PG 16 relnotes: separate out psql \drg item

doc: PG 16 relnotes: separate out psql \drg item Reported-by: Pavel Luzanov Discussion: https://postgr.es/m/29b97504-80a3-fdcc-538e-cadde3d8e...@postgrespro.ru Backpatch-through: 16 only Branch -- REL_16_STABLE Details ---

pgsql: Add comment missing in a4a232b1e702

Add comment missing in a4a232b1e702 Noticed while studying nearby code Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/757fa45c86bdadc36cae34fca383e715e73eec67 Modified Files -- src/backend/catalog/heap.c | 2 ++ 1 file changed, 2 insertions(+)

pgsql: Add list of acknowledgments to release notes

Add list of acknowledgments to release notes This contains all individuals mentioned in the commit messages during PostgreSQL 16 development. current through REL_16_BETA3 Branch -- REL_16_STABLE Details ---

Re: pgsql: Improve BRIN minmax-multi opclass test coverage

These new tests introduced a few new calls of the md5() function. This should be avoided (see commit 208bf364a9). You can replace these easily with the fipshash() function instead, but I think you then also need to change some of the constants in the tests. Could you look at this again?