pgsql: doc: Improve ICU external link

2023-08-22 Thread Peter Eisentraut
doc: Improve ICU external link It previously pointed to the collation API documentation, which our users don't need, but the containing chapter seems useful. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ed057fb68720dfeffc03e2b156c274f8ed10583a Modified Files ---

pgsql: doc: Improve ICU external link

2023-08-22 Thread Peter Eisentraut
doc: Improve ICU external link It previously pointed to the collation API documentation, which our users don't need, but the containing chapter seems useful. Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0b9127de12daf4b6eb33766a592c38fda3853bff Modified Fi

pgsql: Improve vertical spacing of documentation markup

2023-08-22 Thread Peter Eisentraut
Improve vertical spacing of documentation markup Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ed9330cff57bf38df2c38ea4d4cbb44e1378d4d4 Modified Files -- doc/src/sgml/charset.sgml | 60 --- 1 file changed, 46

pgsql: Improve vertical spacing of documentation markup

2023-08-22 Thread Peter Eisentraut
Improve vertical spacing of documentation markup Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6f168e077e4671ecc0796e9aeb7ad61fc3e5b6dd Modified Files -- doc/src/sgml/charset.sgml | 60 --- 1 file chang

pgsql: Some vertical reformatting

2023-08-22 Thread Peter Eisentraut
Some vertical reformatting Remove some line breaks that have become unnecessary after some variable renaming. Discussion: https://www.postgresql.org/message-id/flat/5ed89c69-f4e6-5dab-4003-63bde7460e5e%40eisentraut.org Branch -- master Details --- https://git.postgresql.org/pg/commitdi

pgsql: Rename some function arguments for better clarity

2023-08-22 Thread Peter Eisentraut
Rename some function arguments for better clarity Especially make sure that array arguments have plural names. Discussion: https://www.postgresql.org/message-id/flat/5ed89c69-f4e6-5dab-4003-63bde7460e5e%40eisentraut.org Branch -- master Details --- https://git.postgresql.org/pg/commitd

pgsql: Add const decorations

2023-08-22 Thread Peter Eisentraut
Add const decorations in index.c and indexcmds.c and some adjacent places. This especially makes it easier to understand for some complicated function signatures which are the input and the output arguments. Discussion: https://www.postgresql.org/message-id/flat/5ed89c69-f4e6-5dab-4003-63bde746

pgsql: Introduce macros for protocol characters.

2023-08-22 Thread Nathan Bossart
Introduce macros for protocol characters. This commit introduces descriptively-named macros for the identifiers used in wire protocol messages. These new macros are placed in a new header file so that they can be easily used by third-party code. Author: Dave Cramer Reviewed-by: Alvaro Herrera, T

pgsql: ExtendBufferedWhat -> BufferManagerRelation.

2023-08-22 Thread Thomas Munro
ExtendBufferedWhat -> BufferManagerRelation. Commit 31966b15 invented a way for functions dealing with relation extension to accept a Relation in online code and an SMgrRelation in recovery code. It seems highly likely that future bufmgr.c interfaces will face the same problem, and need to do som

pgsql: ExtendBufferedWhat -> BufferManagerRelation.

2023-08-22 Thread Thomas Munro
ExtendBufferedWhat -> BufferManagerRelation. Commit 31966b15 invented a way for functions dealing with relation extension to accept a Relation in online code and an SMgrRelation in recovery code. It seems highly likely that future bufmgr.c interfaces will face the same problem, and need to do som

pgsql: doc: PG 16 relnotes: properly indent and word-wrap text

2023-08-22 Thread Bruce Momjian
doc: PG 16 relnotes: properly indent and word-wrap text Backpatch-through: 16 only Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d8cd49e992eb0d0f3d447d6b41866ce1b573b01d Modified Files -- doc/src/sgml/release-16.sgml | 3469

pgsql: Fix pg_dump assertion failure when dumping pg_catalog.

2023-08-22 Thread Jeff Davis
Fix pg_dump assertion failure when dumping pg_catalog. Commit 396d348b04 did not account for the default collation. Also, use pg_log_warning() instead of Assert(). Discussion: https://postgr.es/m/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com Reviewed-by: Michael Paquier Backpatch

pgsql: Fix pg_dump assertion failure when dumping pg_catalog.

2023-08-22 Thread Jeff Davis
Fix pg_dump assertion failure when dumping pg_catalog. Commit 396d348b04 did not account for the default collation. Also, use pg_log_warning() instead of Assert(). Discussion: https://postgr.es/m/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com Reviewed-by: Michael Paquier Backpatch

pgsql: Fix pg_dump assertion failure when dumping pg_catalog.

2023-08-22 Thread Jeff Davis
Fix pg_dump assertion failure when dumping pg_catalog. Commit 396d348b04 did not account for the default collation. Also, use pg_log_warning() instead of Assert(). Discussion: https://postgr.es/m/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com Reviewed-by: Michael Paquier Backpatch

pgsql: Cache by-reference missing values in a long lived context

2023-08-22 Thread Andrew Dunstan
Cache by-reference missing values in a long lived context Attribute missing values might be needed past the lifetime of the tuple descriptors from which they are extracted. To avoid possibly using pointers for by-reference values which might thus be left dangling, we cache a datumCopy'd version of

pgsql: Cache by-reference missing values in a long lived context

2023-08-22 Thread Andrew Dunstan
Cache by-reference missing values in a long lived context Attribute missing values might be needed past the lifetime of the tuple descriptors from which they are extracted. To avoid possibly using pointers for by-reference values which might thus be left dangling, we cache a datumCopy'd version of

pgsql: Cache by-reference missing values in a long lived context

2023-08-22 Thread Andrew Dunstan
Cache by-reference missing values in a long lived context Attribute missing values might be needed past the lifetime of the tuple descriptors from which they are extracted. To avoid possibly using pointers for by-reference values which might thus be left dangling, we cache a datumCopy'd version of

pgsql: Cache by-reference missing values in a long lived context

2023-08-22 Thread Andrew Dunstan
Cache by-reference missing values in a long lived context Attribute missing values might be needed past the lifetime of the tuple descriptors from which they are extracted. To avoid possibly using pointers for by-reference values which might thus be left dangling, we cache a datumCopy'd version of

pgsql: Cache by-reference missing values in a long lived context

2023-08-22 Thread Andrew Dunstan
Cache by-reference missing values in a long lived context Attribute missing values might be needed past the lifetime of the tuple descriptors from which they are extracted. To avoid possibly using pointers for by-reference values which might thus be left dangling, we cache a datumCopy'd version of

pgsql: Cache by-reference missing values in a long lived context

2023-08-22 Thread Andrew Dunstan
Cache by-reference missing values in a long lived context Attribute missing values might be needed past the lifetime of the tuple descriptors from which they are extracted. To avoid possibly using pointers for by-reference values which might thus be left dangling, we cache a datumCopy'd version of

pgsql: doc: PG 16 relnotes: separate out psql \drg item

2023-08-22 Thread Bruce Momjian
doc: PG 16 relnotes: separate out psql \drg item Reported-by: Pavel Luzanov Discussion: https://postgr.es/m/29b97504-80a3-fdcc-538e-cadde3d8e...@postgrespro.ru Backpatch-through: 16 only Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e9f535463a12af2d4e7

pgsql: Add comment missing in a4a232b1e702

2023-08-22 Thread Alvaro Herrera
Add comment missing in a4a232b1e702 Noticed while studying nearby code Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/757fa45c86bdadc36cae34fca383e715e73eec67 Modified Files -- src/backend/catalog/heap.c | 2 ++ 1 file changed, 2 insertions(+)

pgsql: Add list of acknowledgments to release notes

2023-08-22 Thread Peter Eisentraut
Add list of acknowledgments to release notes This contains all individuals mentioned in the commit messages during PostgreSQL 16 development. current through REL_16_BETA3 Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8c76a556658ddb56e33be5507131874776c0090