pgsql: Avoid non-POSIX cp flags

2023-08-25 Thread Andres Freund
Avoid non-POSIX cp flags Commit 252dcb32 used cp -a, but apparently Solaris doesn't like that. Use cp -RPp instead. Author: Thomas Munro Reviewed-by: Daniel Gustafsson Discussion: https://postgr.es/m/ca+hukgl10aoqvmmqgoj8ctjoz9mlidd8ik2e8pibzlnmz0+...@mail.gmail.com Branch -- master Det

Re: pgsql: Cache by-reference missing values in a long lived context

2023-08-25 Thread Tom Lane
Andrew Dunstan writes: > On 2023-08-24 Th 16:57, Tom Lane wrote: >> I'm not sure if those arguments justify a back-patch instead of >> the localized hack you suggest. > Seems like overkill given the age of the surrounding code and the > nearness to EOL of releases 11 and 12. I agree that 11 is

Re: pgsql: Cache by-reference missing values in a long lived context

2023-08-25 Thread Andrew Dunstan
On 2023-08-24 Th 16:57, Tom Lane wrote: Andrew Dunstan writes: On 2023-08-24 Th 11:27, Tom Lane wrote: The v11 version of this patch is causing a compiler warning for me: Sorry about that, fixed. Thanks! While we're about it, let's also fix these warnings which are seen on my systems buil

pgsql: Rename test table to avoid cs_CZ locale problem

2023-08-25 Thread Alvaro Herrera
Rename test table to avoid cs_CZ locale problem Per buildfarm member Hippopotamus Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/98976d0ce0a3947427182394041f6dd0e33438b4 Modified Files -- src/test/regress/expected/inherit.out | 38 +

pgsql: Catalog not-null constraints

2023-08-25 Thread Alvaro Herrera
Catalog not-null constraints We now create contype='n' pg_constraint rows for not-null constraints. We propagate these constraints to other tables during operations such as adding inheritance relationships, creating and attaching partitions and creating tables LIKE other tables. We also spawn no