pgsql: Convert encrypted SSL test keys to PKCS#8 format

2023-08-27 Thread Peter Eisentraut
Convert encrypted SSL test keys to PKCS#8 format OpenSSL in FIPS mode rejects several encrypted private keys used in the test suites ssl and ssl_passphrase_callback. This is because they are in a "traditional" OpenSSL format that uses MD5 for key generation. The fix is to convert them to the mor

pgsql: Tighten unit parsing in internal values

2023-08-27 Thread Michael Paquier
Tighten unit parsing in internal values Interval values now generate an error when the user has multiple consecutive units or a unit without a value. Previously, it was possible to specify multiple units consecutively which is contrary to what the documentation allows, so it was possible to finis

pgsql: Tighten handling of "ago" in interval values

2023-08-27 Thread Michael Paquier
Tighten handling of "ago" in interval values This commit Restrict the unit "ago" to only appear at the end of the interval. According to the documentation, a direction can only be defined at the end of an interval, but it was possible to define it in the middle of the string or define it multiple

pgsql: Format list of catalog files in makefile vertically

2023-08-27 Thread Peter Eisentraut
Format list of catalog files in makefile vertically This makes it easier to compare the lists visually with the corresponding meson lists. In passing, copy over some relevant comments from the makefiles to meson.build. Reviewed-by: Andres Freund Reviewed-by: Alvaro Herrera Discussion: https:/

pgsql: Remove dead code in DecodeInterval()

2023-08-27 Thread Michael Paquier
Remove dead code in DecodeInterval() This commit removes some dead code related to the unit type RESERV, whose last use has been removed from the unit lookup table used for intervals ("deltatktbl" in datetime.c) in 666cbae16da4. Before that, RESERV was used as an equivalent of "invalid", but that

Re: pgsql: Use "template" data directory in tests

2023-08-27 Thread Michael Paquier
Hi Andres, On Thu, Aug 24, 2023 at 10:09:20PM +, Andres Freund wrote: > Use "template" data directory in tests > > When running all (or just many) of our tests, a significant portion of both > CPU time and IO is spent running initdb. Most of those initdb runs don't > specify any options influ

pgsql: Remove incorrect name from release notes

2023-08-27 Thread Peter Eisentraut
Remove incorrect name from release notes This name was incorrect in the underlying commit message. (The correct name is already listed.) Reported-by: Denis Laxalde Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/60d7d50f426b17b544fd8c24024d87ab8331984f Mo

pgsql: Remove incorrect/duplicate name from list of acknowledgments

2023-08-27 Thread Peter Eisentraut
Remove incorrect/duplicate name from list of acknowledgments Reported-by: Vik Fearing Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8d70eb731c43c4ccb5fa5642518a277ef3f6b860 Modified Files -- doc/src/sgml/release-16.sgml | 1 - 1 file changed, 1

pgsql: Update list of acknowledgments in release notes

2023-08-27 Thread Peter Eisentraut
Update list of acknowledgments in release notes current through a842ba407c Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ef0e7dbcbed403ba53a1d77faf96600785e57d7a Modified Files -- doc/src/sgml/release-16.sgml | 3 +++ 1 file changed, 3 insertion

Re: pgsql: Cache by-reference missing values in a long lived context

2023-08-27 Thread Andrew Dunstan
On 2023-08-26 Sa 17:41, Tom Lane wrote: Alvaro Herrera writes: On 2023-Aug-25, Tom Lane wrote: ... Were we relying on "{ 0 }" anywhere else pre-v12? We have a few occurrences of {0} in initializations in pg11, so it should work. Ah, indeed. Objection withdrawn then.

pgsql: Silence compiler warning in release 11 and 12 branches

2023-08-27 Thread Andrew Dunstan
Silence compiler warning in release 11 and 12 branches The offending code is not present in later branches. Discussion: https://postgr.es/m/ba2150c1-8485-6597-fafe-4fcd39e49...@dunslane.net Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f06e1711d2e64aa6f56

pgsql: Silence compiler warning in release 11 and 12 branches

2023-08-27 Thread Andrew Dunstan
Silence compiler warning in release 11 and 12 branches The offending code is not present in later branches. Discussion: https://postgr.es/m/ba2150c1-8485-6597-fafe-4fcd39e49...@dunslane.net Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/dd9779141eacbad0867

pgsql: Show names of DEALLOCATE as constants in pg_stat_statements

2023-08-27 Thread Michael Paquier
Show names of DEALLOCATE as constants in pg_stat_statements This commit switches query jumbling so as prepared statement names are treated as constants in DeallocateStmt. A boolean field is added to DeallocateStmt to make a distinction between ALL and named prepared statements, as "name" was used