pgsql: Fix misuse of RelOptInfo.unique_for_rels cache by SJE

2024-01-08 Thread Alexander Korotkov
Fix misuse of RelOptInfo.unique_for_rels cache by SJE When SJE uses RelOptInfo.unique_for_rels cache, it passes filtered quals to innerrel_is_unique_ext(). That might lead to an invalid match to cache entries made by previous non self-join checking calls. Add UniqueRelInfo.self_join flag to prev

pgsql: Remove excess #include "utils/wait_event.h".

2024-01-08 Thread Noah Misch
Remove excess #include "utils/wait_event.h". This simplifies copying libpq/libpq-be-fe-helpers.h into extensions, because some supported PostgreSQL versions lack the other header. Discussion: https://postgr.es/m/20231122012945...@rfd.leadboat.com Branch -- master Details --- https://git

pgsql: Fix missing word in comment.

2024-01-08 Thread Noah Misch
Fix missing word in comment. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/196799d6765706697ff9417ae85929085774b8f4 Modified Files -- src/include/libpq/libpq-be-fe-helpers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Make dblink interruptible, via new libpqsrv APIs.

2024-01-08 Thread Noah Misch
Make dblink interruptible, via new libpqsrv APIs. This replaces dblink's blocking libpq calls, allowing cancellation and allowing DROP DATABASE (of a database not involved in the query). Apart from explicit dblink_cancel_query() calls, dblink still doesn't cancel the remote side. The replacement

pgsql: Fix indentation in ExecParallelHashIncreaseNumBatches()

2024-01-08 Thread Alexander Korotkov
Fix indentation in ExecParallelHashIncreaseNumBatches() Backpatch-through: 12 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6d94cc6ca1b775335f58527ece6c12d74ec41bde Modified Files -- src/backend/executor/nodeHash.c | 1 + 1 file changed, 1 insertion(+)

pgsql: Fix indentation in ExecParallelHashIncreaseNumBatches()

2024-01-08 Thread Alexander Korotkov
Fix indentation in ExecParallelHashIncreaseNumBatches() Backpatch-through: 12 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a5e2853c38db7181a35486e1865e07f73782bc99 Modified Files -- src/backend/executor/nodeHash.c | 1 + 1 file changed, 1 inser

pgsql: Fix indentation in ExecParallelHashIncreaseNumBatches()

2024-01-08 Thread Alexander Korotkov
Fix indentation in ExecParallelHashIncreaseNumBatches() Backpatch-through: 12 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/17b6f39f19b1a54baac36f38b49067b0ce9fd7b0 Modified Files -- src/backend/executor/nodeHash.c | 1 + 1 file changed, 1 inser

pgsql: Fix indentation in ExecParallelHashIncreaseNumBatches()

2024-01-08 Thread Alexander Korotkov
Fix indentation in ExecParallelHashIncreaseNumBatches() Backpatch-through: 12 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/97e64911da34835cba5bd9c98eda608feefa9dfa Modified Files -- src/backend/executor/nodeHash.c | 1 + 1 file changed, 1 inser

pgsql: Fix indentation in ExecParallelHashIncreaseNumBatches()

2024-01-08 Thread Alexander Korotkov
Fix indentation in ExecParallelHashIncreaseNumBatches() Backpatch-through: 12 Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/20a566cd43bb45561c64315f7744282100abb7f1 Modified Files -- src/backend/executor/nodeHash.c | 1 + 1 file changed, 1 inser

pgsql: Fix indentation in ExecParallelHashIncreaseNumBatches()

2024-01-08 Thread Alexander Korotkov
Fix indentation in ExecParallelHashIncreaseNumBatches() Backpatch-through: 12 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6eecc3a622b2db39417e5457735420468b89897e Modified Files -- src/backend/executor/nodeHash.c | 1 + 1 file changed, 1 inser

pgsql: Allow examine_simple_variable() to work on INSERT RETURNING Vars

2024-01-08 Thread Tom Lane
Allow examine_simple_variable() to work on INSERT RETURNING Vars. Since commit 599b33b94, this function assumed that every RTE_RELATION RangeTblEntry would have an associated RelOptInfo. But that's not so: we only build RelOptInfos for relations that are scanned by the query. In particular the ta

pgsql: Strengthen tests for 5ef34a8fc3

2024-01-08 Thread Alexander Korotkov
Strengthen tests for 5ef34a8fc3 The test query in 5ef34a8fc3 is running over the empty emp1 table giving the same (empty) return both with and without the fix. Add one row to that table to make not just the test query plan, but also the test query result different. Reported-by: Richard Guo Bug: