pgsql: Add .gitignore to src/test/modules/gin/

2024-01-30 Thread Michael Paquier
Add .gitignore to src/test/modules/gin/ This has been forgotten in 6a1ea02c491d. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0fda3921380798897b6faca5e4fdcdc22f950f12 Modified Files -- src/test/modules/gin/.gitignore | 4 1 file changed, 4 insert

pgsql: Add tests for int4_bool() in int.c

2024-01-30 Thread Michael Paquier
Add tests for int4_bool() in int.c This cast was previously not covered at all by the regression tests. Author: Christoph Berg Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5f19412e4eae6468361f24fd20e0

pgsql: Consider the "LIMIT 1" optimization with parallel DISTINCT

2024-01-30 Thread David Rowley
Consider the "LIMIT 1" optimization with parallel DISTINCT Similar to what was done in 5543677ec for non-parallel DISTINCT, apply the same optimization when the distinct_pathkeys are empty for the partial paths too. This can be faster than the non-parallel version when the first row matching the

pgsql: Fix various issues with ALTER TEXT SEARCH CONFIGURATION

2024-01-30 Thread Michael Paquier
Fix various issues with ALTER TEXT SEARCH CONFIGURATION This commit addresses a set of issues when changing token type mappings in a text search configuration when using duplicated token names: - ADD MAPPING would fail on insertion because of a constraint failure after inserting the same mapping.

pgsql: Fix various issues with ALTER TEXT SEARCH CONFIGURATION

2024-01-30 Thread Michael Paquier
Fix various issues with ALTER TEXT SEARCH CONFIGURATION This commit addresses a set of issues when changing token type mappings in a text search configuration when using duplicated token names: - ADD MAPPING would fail on insertion because of a constraint failure after inserting the same mapping.

pgsql: Fix various issues with ALTER TEXT SEARCH CONFIGURATION

2024-01-30 Thread Michael Paquier
Fix various issues with ALTER TEXT SEARCH CONFIGURATION This commit addresses a set of issues when changing token type mappings in a text search configuration when using duplicated token names: - ADD MAPPING would fail on insertion because of a constraint failure after inserting the same mapping.

pgsql: Fix various issues with ALTER TEXT SEARCH CONFIGURATION

2024-01-30 Thread Michael Paquier
Fix various issues with ALTER TEXT SEARCH CONFIGURATION This commit addresses a set of issues when changing token type mappings in a text search configuration when using duplicated token names: - ADD MAPPING would fail on insertion because of a constraint failure after inserting the same mapping.

pgsql: Fix various issues with ALTER TEXT SEARCH CONFIGURATION

2024-01-30 Thread Michael Paquier
Fix various issues with ALTER TEXT SEARCH CONFIGURATION This commit addresses a set of issues when changing token type mappings in a text search configuration when using duplicated token names: - ADD MAPPING would fail on insertion because of a constraint failure after inserting the same mapping.

pgsql: Fix various issues with ALTER TEXT SEARCH CONFIGURATION

2024-01-30 Thread Michael Paquier
Fix various issues with ALTER TEXT SEARCH CONFIGURATION This commit addresses a set of issues when changing token type mappings in a text search configuration when using duplicated token names: - ADD MAPPING would fail on insertion because of a constraint failure after inserting the same mapping.

Re: pgsql: Temporary patch to help debug pg_walsummary test failures.

2024-01-30 Thread David Rowley
On Mon, 29 Jan 2024 at 12:40, Michael Paquier wrote: > Not sure if that's worth fixing if this should be gone at some point, > but koel has been complaining on this one: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2024-01-28%2016%3A19%3A03 I think we should as we don't know

pgsql: Use older name for test_primary_datadir

2024-01-30 Thread Andrew Dunstan
Use older name for test_primary_datadir Releases prior to 14 used the older naming scheme. This fixes a bug un the back-patches of 6ee26c6a4b in releases 12 and 13. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4c1422553bf4e1435c02a57a161c7e58f5aa9c04 Mo

pgsql: Use older name for test_primary_datadir

2024-01-30 Thread Andrew Dunstan
Use older name for test_primary_datadir Releases prior to 14 used the older naming scheme. This fixes a bug un the back-patches of 6ee26c6a4b in releases 12 and 13. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c944bf2f07f26aff9fcdfb8f4bf0e4973daeac54 Mo

pgsql: Fix 003_extrafiles.pl test for the Windows

2024-01-30 Thread Andrew Dunstan
Fix 003_extrafiles.pl test for the Windows File::Find converts backslashes to slashes in the newer Perl versions. See: https://github.com/Perl/perl5/commit/414f14df98cb1c9a20f92c5c54948b67c09f072d So, do the same conversion for Windows before comparing paths. To support all Perl versions, always

pgsql: Fix 003_extrafiles.pl test for the Windows

2024-01-30 Thread Andrew Dunstan
Fix 003_extrafiles.pl test for the Windows File::Find converts backslashes to slashes in the newer Perl versions. See: https://github.com/Perl/perl5/commit/414f14df98cb1c9a20f92c5c54948b67c09f072d So, do the same conversion for Windows before comparing paths. To support all Perl versions, always

pgsql: Fix 003_extrafiles.pl test for the Windows

2024-01-30 Thread Andrew Dunstan
Fix 003_extrafiles.pl test for the Windows File::Find converts backslashes to slashes in the newer Perl versions. See: https://github.com/Perl/perl5/commit/414f14df98cb1c9a20f92c5c54948b67c09f072d So, do the same conversion for Windows before comparing paths. To support all Perl versions, always

pgsql: Fix 003_extrafiles.pl test for the Windows

2024-01-30 Thread Andrew Dunstan
Fix 003_extrafiles.pl test for the Windows File::Find converts backslashes to slashes in the newer Perl versions. See: https://github.com/Perl/perl5/commit/414f14df98cb1c9a20f92c5c54948b67c09f072d So, do the same conversion for Windows before comparing paths. To support all Perl versions, always

pgsql: Fix 003_extrafiles.pl test for the Windows

2024-01-30 Thread Andrew Dunstan
Fix 003_extrafiles.pl test for the Windows File::Find converts backslashes to slashes in the newer Perl versions. See: https://github.com/Perl/perl5/commit/414f14df98cb1c9a20f92c5c54948b67c09f072d So, do the same conversion for Windows before comparing paths. To support all Perl versions, always

pgsql: Fix 003_extrafiles.pl test for the Windows

2024-01-30 Thread Andrew Dunstan
Fix 003_extrafiles.pl test for the Windows File::Find converts backslashes to slashes in the newer Perl versions. See: https://github.com/Perl/perl5/commit/414f14df98cb1c9a20f92c5c54948b67c09f072d So, do the same conversion for Windows before comparing paths. To support all Perl versions, always

pgsql: Simplify partial path generation in GROUP BY/ORDER BY

2024-01-30 Thread David Rowley
Simplify partial path generation in GROUP BY/ORDER BY Here we consolidate the generation of partial sort and partial incremental sort paths in a similar way to what was done in 4a29eabd1. Since the cost penalty for incremental sort was removed by that commit, there's no point in creating a sort p

pgsql: Split use of SerialSLRULock, creating SerialControlLock

2024-01-30 Thread Alvaro Herrera
Split use of SerialSLRULock, creating SerialControlLock predicate.c has been using SerialSLRULock (the control lock for its SLRU structure) to coordinate access to SerialControlData, another of its numerous shared memory structures; this is unnecessary and confuses further SLRU scalability work.

pgsql: Add a failover option to subscriptions.

2024-01-30 Thread Amit Kapila
Add a failover option to subscriptions. This commit introduces a new subscription option named 'failover', which provides users with the ability to set the failover property of the replication slot on the publisher when creating or altering a subscription. This uses the replication commands intro

pgsql: pgcrypto: Fix check for buffer size

2024-01-30 Thread Daniel Gustafsson
pgcrypto: Fix check for buffer size The code copying the PGP block into the temp buffer failed to account for the extra 2 bytes in the buffer which are needed for the prefix. If the block was oversized, subsequent checks of the prefix would have exceeded the buffer size. Since the block sizes are

pgsql: pgcrypto: Fix check for buffer size

2024-01-30 Thread Daniel Gustafsson
pgcrypto: Fix check for buffer size The code copying the PGP block into the temp buffer failed to account for the extra 2 bytes in the buffer which are needed for the prefix. If the block was oversized, subsequent checks of the prefix would have exceeded the buffer size. Since the block sizes are

pgsql: pgcrypto: Fix check for buffer size

2024-01-30 Thread Daniel Gustafsson
pgcrypto: Fix check for buffer size The code copying the PGP block into the temp buffer failed to account for the extra 2 bytes in the buffer which are needed for the prefix. If the block was oversized, subsequent checks of the prefix would have exceeded the buffer size. Since the block sizes are

pgsql: pgcrypto: Fix check for buffer size

2024-01-30 Thread Daniel Gustafsson
pgcrypto: Fix check for buffer size The code copying the PGP block into the temp buffer failed to account for the extra 2 bytes in the buffer which are needed for the prefix. If the block was oversized, subsequent checks of the prefix would have exceeded the buffer size. Since the block sizes are

pgsql: pgcrypto: Fix check for buffer size

2024-01-30 Thread Daniel Gustafsson
pgcrypto: Fix check for buffer size The code copying the PGP block into the temp buffer failed to account for the extra 2 bytes in the buffer which are needed for the prefix. If the block was oversized, subsequent checks of the prefix would have exceeded the buffer size. Since the block sizes are

pgsql: pgcrypto: Fix check for buffer size

2024-01-30 Thread Daniel Gustafsson
pgcrypto: Fix check for buffer size The code copying the PGP block into the temp buffer failed to account for the extra 2 bytes in the buffer which are needed for the prefix. If the block was oversized, subsequent checks of the prefix would have exceeded the buffer size. Since the block sizes are

pgsql: Fix incorrect format placeholders for Oid

2024-01-30 Thread Peter Eisentraut
Fix incorrect format placeholders for Oid Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4c48c0fe561c2b07831c2a296da637401cb953c6 Modified Files -- src/backend/utils/adt/jsonpath_exec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)