pgsql: Set LSN for wbuf in _hash_freeovflpage() iff wbuf is modified.

2024-02-06 Thread Amit Kapila
Set LSN for wbuf in _hash_freeovflpage() iff wbuf is modified. Commit 861f86beea used REGBUF_NO_CHANGE at one of the places in the hash index to register the clean buffers but forgot to avoid setting LSN in that case. Reported-by: Michael Paquier Author: Kuroda Hayato Reviewed-by: Amit Kapila,

pgsql: Clean-ups for 776621a5e4 and 7329240437.

2024-02-06 Thread Amit Kapila
Clean-ups for 776621a5e4 and 7329240437. Following are a few clean-ups related to failover option support in slots: 1. Improve the documentation in create_subscription.sgml. 2. Remove the spurious blank line in subscriptioncmds.c. 3. Remove the NOTICE for alter_replication_slot in

pgsql: Simplify signature of CopyAttributeOutCSV() in copyto.c

2024-02-06 Thread Michael Paquier
Simplify signature of CopyAttributeOutCSV() in copyto.c This has come up in 2889fd23be56, reverted later on, and is still useful on its own to reduce a bit the differences between the code paths dedicated to CSV and text. Discussion: https://postgr.es/m/zcckwaefrloqp...@paquier.xyz Branch

pgsql: Revert "Refactor CopyAttributeOut{CSV,Text}() to use a callback

2024-02-06 Thread Michael Paquier
Revert "Refactor CopyAttributeOut{CSV,Text}() to use a callback in COPY TO" This reverts commit 2889fd23be56, following a discussion with Andres Freund as this callback, being called once per attribute when sending a relation's row, can involve a lot of indirect function calls (more attributes to

pgsql: Change initial use of pg_atomic_write_u64 to init

2024-02-06 Thread Alvaro Herrera
Change initial use of pg_atomic_write_u64 to init This only matters when using atomics emulation with semaphores. Per buildfarm member rorqual. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e4b27b53552c19c50b3ca00b697a1f745c247d0d Modified Files --

Re: pgsql: Use atomic access for SlruShared->latest_page_number

2024-02-06 Thread Alvaro Herrera
On 2024-Feb-06, Alvaro Herrera wrote: > Use atomic access for SlruShared->latest_page_number rorqual failed (--disable-atomics --disable-spinlocks). Looking into it ... -- Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/ "Nunca se desea ardientemente lo que solo

pgsql: Use atomic access for SlruShared->latest_page_number

2024-02-06 Thread Alvaro Herrera
Use atomic access for SlruShared->latest_page_number The new concurrency model proposed for slru.c to improve performance does not include any single lock that would coordinate processes doing concurrent reads/writes on SlruShared->latest_page_number. We can instead use atomic reads and writes