Re: pgsql: Add a slot synchronization function.

2024-02-13 Thread Amit Kapila
On Wed, Feb 14, 2024 at 10:13 AM Amit Kapila wrote: > > Add a slot synchronization function. > There are a few BF failures and it seems related to this commit. I am looking into those. -- With Regards, Amit Kapila.

pgsql: Add a slot synchronization function.

2024-02-13 Thread Amit Kapila
Add a slot synchronization function. This commit introduces a new SQL function pg_sync_replication_slots() which is used to synchronize the logical replication slots from the primary server to the physical standby so that logical replication can be resumed after a failover or planned switchover.

pgsql: Revert "Refactor CopyReadAttributes{CSV,Text}() to use a callbac

2024-02-13 Thread Michael Paquier
Revert "Refactor CopyReadAttributes{CSV,Text}() to use a callback in COPY FROM" This reverts commit 95fb5b49024, for reasons similar to what led to 1aa8324b81fa. In this case, the callback was called once per row, which is less worse than the previous callback introduced for COPY TO called once

pgsql: pgcrypto: Fix incorrect argument vs PG_GETARG*() mappings

2024-02-13 Thread Michael Paquier
pgcrypto: Fix incorrect argument vs PG_GETARG*() mappings The following functions use a mix of bytea and text arguments, but their C internals always used PG_GETARG_BYTEA_PP(), creating an incorrect mix with the argument types expected by encrypt_internal(): -

pgsql: Improve comment about query_id_enabled in queryjumblefuncs.c

2024-02-13 Thread Michael Paquier
Improve comment about query_id_enabled in queryjumblefuncs.c The comment was inexact because query_id_enabled will not be switched to "true" even if compute_query_id is "on", unless a module requests for it. While on it, this adds a comment to mention that IsQueryIdEnabled() should be used to

pgsql: Catch overflow when rounding intervals in AdjustIntervalForTypmo

2024-02-13 Thread Tom Lane
Catch overflow when rounding intervals in AdjustIntervalForTypmod. Previously, an interval microseconds field close to INT64_MAX or INT64_MIN could overflow, producing a result with not even the correct sign, while being rounded to match a precision specification. This seems worth fixing, but

pgsql: Fix 'mmap' DSM implementation with allocations larger than 4 GB

2024-02-13 Thread Heikki Linnakangas
Fix 'mmap' DSM implementation with allocations larger than 4 GB Fixes bug #18341. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/18341-ce16599e7fd62...@postgresql.org Branch -- REL_15_STABLE Details ---

pgsql: Fix 'mmap' DSM implementation with allocations larger than 4 GB

2024-02-13 Thread Heikki Linnakangas
Fix 'mmap' DSM implementation with allocations larger than 4 GB Fixes bug #18341. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/18341-ce16599e7fd62...@postgresql.org Branch -- REL_13_STABLE Details ---

pgsql: Fix 'mmap' DSM implementation with allocations larger than 4 GB

2024-02-13 Thread Heikki Linnakangas
Fix 'mmap' DSM implementation with allocations larger than 4 GB Fixes bug #18341. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/18341-ce16599e7fd62...@postgresql.org Branch -- REL_12_STABLE Details ---

pgsql: Fix 'mmap' DSM implementation with allocations larger than 4 GB

2024-02-13 Thread Heikki Linnakangas
Fix 'mmap' DSM implementation with allocations larger than 4 GB Fixes bug #18341. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/18341-ce16599e7fd62...@postgresql.org Branch -- REL_16_STABLE Details ---

pgsql: Fix 'mmap' DSM implementation with allocations larger than 4 GB

2024-02-13 Thread Heikki Linnakangas
Fix 'mmap' DSM implementation with allocations larger than 4 GB Fixes bug #18341. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/18341-ce16599e7fd62...@postgresql.org Branch -- REL_14_STABLE Details ---

pgsql: Fix 'mmap' DSM implementation with allocations larger than 4 GB

2024-02-13 Thread Heikki Linnakangas
Fix 'mmap' DSM implementation with allocations larger than 4 GB Fixes bug #18341. Backpatch to all supported versions. Discussion: https://www.postgresql.org/message-id/18341-ce16599e7fd62...@postgresql.org Branch -- master Details ---

pgsql: Use a safer outfuncs/readfuncs representation for BitStrings.

2024-02-13 Thread Tom Lane
Use a safer outfuncs/readfuncs representation for BitStrings. For a long time, our outfuncs.c code has supposed that the string contents of a BitString node could just be printed literally with no concern for quoting/escaping. Now, that's okay if the string literal contains only valid binary or

pgsql: Use a safer outfuncs/readfuncs representation for BitStrings.

2024-02-13 Thread Tom Lane
Use a safer outfuncs/readfuncs representation for BitStrings. For a long time, our outfuncs.c code has supposed that the string contents of a BitString node could just be printed literally with no concern for quoting/escaping. Now, that's okay if the string literal contains only valid binary or

Re: pgsql: Skip .DS_Store files in server side utils

2024-02-13 Thread Daniel Gustafsson
> On 13 Feb 2024, at 13:54, Daniel Gustafsson > wrote: > > Skip .DS_Store files in server side utils > Backpatch-through: v12 Some BF animals for 14-12 failed, so have reverted to allow time for figuring out a proper fix. Sorry for the noice. -- Daniel Gustafsson

pgsql: Revert "Skip .DS_Store files in server side utils"

2024-02-13 Thread Daniel Gustafsson
Revert "Skip .DS_Store files in server side utils" This reverts commit 76bb6dd2e56c14e947196e638f86982424c51254. Per failure reports from the buildfarm. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/588f370b163db25ae38504088b17610123dcb315 Modified Files

pgsql: Revert "Skip .DS_Store files in server side utils"

2024-02-13 Thread Daniel Gustafsson
Revert "Skip .DS_Store files in server side utils" This reverts commit d3fdfdcd1c7f1b714a9a85b893d2c5afc60bea91. Per failure reports from the buildfarm. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/077dec8b6c19152fb3f200610a89c5f71e4045ee Modified Files

pgsql: Revert "Skip .DS_Store files in server side utils"

2024-02-13 Thread Daniel Gustafsson
Revert "Skip .DS_Store files in server side utils" This reverts commit aeee173d229232f94acc61e7bfe81d40f56e478e. Per failure reports from the buildfarm. Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/99cd749ce267fd9c0f6461b282f84f65ed9d8535 Modified Files

pgsql: Skip .DS_Store files in server side utils

2024-02-13 Thread Daniel Gustafsson
Skip .DS_Store files in server side utils The macOS Finder application creates .DS_Store files in directories when opened, which creates problems for serverside utilities which expect all files to be PostgreSQL specific files. Skip these files when encountered in pg_checksums, pg_rewind and

pgsql: Skip .DS_Store files in server side utils

2024-02-13 Thread Daniel Gustafsson
Skip .DS_Store files in server side utils The macOS Finder application creates .DS_Store files in directories when opened, which creates problems for serverside utilities which expect all files to be PostgreSQL specific files. Skip these files when encountered in pg_checksums, pg_rewind and

pgsql: Skip .DS_Store files in server side utils

2024-02-13 Thread Daniel Gustafsson
Skip .DS_Store files in server side utils The macOS Finder application creates .DS_Store files in directories when opened, which creates problems for serverside utilities which expect all files to be PostgreSQL specific files. Skip these files when encountered in pg_checksums, pg_rewind and

pgsql: Skip .DS_Store files in server side utils

2024-02-13 Thread Daniel Gustafsson
Skip .DS_Store files in server side utils The macOS Finder application creates .DS_Store files in directories when opened, which creates problems for serverside utilities which expect all files to be PostgreSQL specific files. Skip these files when encountered in pg_checksums, pg_rewind and

pgsql: Skip .DS_Store files in server side utils

2024-02-13 Thread Daniel Gustafsson
Skip .DS_Store files in server side utils The macOS Finder application creates .DS_Store files in directories when opened, which creates problems for serverside utilities which expect all files to be PostgreSQL specific files. Skip these files when encountered in pg_checksums, pg_rewind and

pgsql: Skip .DS_Store files in server side utils

2024-02-13 Thread Daniel Gustafsson
Skip .DS_Store files in server side utils The macOS Finder application creates .DS_Store files in directories when opened, which creates problems for serverside utilities which expect all files to be PostgreSQL specific files. Skip these files when encountered in pg_checksums, pg_rewind and