pgsql: Fix 004_subscription.pl to allow its usage in --link mode.

2024-02-18 Thread Amit Kapila
Fix 004_subscription.pl to allow its usage in --link mode. The test was failing when executed in --link mode and the reason was that we were using the old cluster from a previously successful upgrade test. Re-arrange the tests so that the successful test case is at the end. Reported-by: Justin

pgsql: ecpg: Fix zero-termination of string generated by intoasc()

2024-02-18 Thread Michael Paquier
ecpg: Fix zero-termination of string generated by intoasc() intoasc(), a wrapper for PGTYPESinterval_to_asc that converts an interval to its textual representation, used a plain memcpy() when copying its result. This could miss a zero-termination in the result string, leading to an incorrect

pgsql: ecpg: Fix zero-termination of string generated by intoasc()

2024-02-18 Thread Michael Paquier
ecpg: Fix zero-termination of string generated by intoasc() intoasc(), a wrapper for PGTYPESinterval_to_asc that converts an interval to its textual representation, used a plain memcpy() when copying its result. This could miss a zero-termination in the result string, leading to an incorrect

pgsql: ecpg: Fix zero-termination of string generated by intoasc()

2024-02-18 Thread Michael Paquier
ecpg: Fix zero-termination of string generated by intoasc() intoasc(), a wrapper for PGTYPESinterval_to_asc that converts an interval to its textual representation, used a plain memcpy() when copying its result. This could miss a zero-termination in the result string, leading to an incorrect

pgsql: ecpg: Fix zero-termination of string generated by intoasc()

2024-02-18 Thread Michael Paquier
ecpg: Fix zero-termination of string generated by intoasc() intoasc(), a wrapper for PGTYPESinterval_to_asc that converts an interval to its textual representation, used a plain memcpy() when copying its result. This could miss a zero-termination in the result string, leading to an incorrect

pgsql: ecpg: Fix zero-termination of string generated by intoasc()

2024-02-18 Thread Michael Paquier
ecpg: Fix zero-termination of string generated by intoasc() intoasc(), a wrapper for PGTYPESinterval_to_asc that converts an interval to its textual representation, used a plain memcpy() when copying its result. This could miss a zero-termination in the result string, leading to an incorrect

pgsql: ecpg: Fix zero-termination of string generated by intoasc()

2024-02-18 Thread Michael Paquier
ecpg: Fix zero-termination of string generated by intoasc() intoasc(), a wrapper for PGTYPESinterval_to_asc that converts an interval to its textual representation, used a plain memcpy() when copying its result. This could miss a zero-termination in the result string, leading to an incorrect

pgsql: ecpg: Fix error handling on OOMs when parsing timestamps

2024-02-18 Thread Michael Paquier
ecpg: Fix error handling on OOMs when parsing timestamps pgtypes_alloc() can return NULL when failing an allocation, which is something that PGTYPEStimestamp_defmt_asc() has forgotten about when translating a timestamp for 'D', 'r', 'R' and 'T' as these require a temporary allocation. This is