pgsql: pgindent fix

2024-02-21 Thread Peter Eisentraut
pgindent fix for commit 489072ab7a Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3d47b75546d1ef70145f58e162a96f7e0c649389 Modified Files -- src/backend/optimizer/plan/analyzejoins.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

pgsql: Fix the intermittent buildfarm failures in 031_column_list.

2024-02-21 Thread Amit Kapila
Fix the intermittent buildfarm failures in 031_column_list. The reason was that the ALTER SUBSCRIPTION .. SET PUBLICATION will lead to the restarting of apply worker and after the restart, the apply worker will use the existing slot and replication origin corresponding to the subscription. Now,

pgsql: Remove custom Constraint node read/write implementations

2024-02-21 Thread Peter Eisentraut
Remove custom Constraint node read/write implementations This is part of an effort to reduce the number of special cases in the automatically generated node support functions. Allegedly, only certain fields of the Constraint node are valid based on contype. But this has historically not been

pgsql: Improve ERROR/LOG messages added by commits ddd5f4f54a and 7a424

2024-02-21 Thread Amit Kapila
Improve ERROR/LOG messages added by commits ddd5f4f54a and 7a424ece48. Additionally, in slotsync.c, replace one StringInfoData variable usage with a constant string to avoid palloc/pfree. Also, replace the inclusion of "logical.h" with "slot.h" to prevent the exposure of unnecessary

pgsql: Speed up uuid_out() by not relying on a StringInfo

2024-02-21 Thread Michael Paquier
Speed up uuid_out() by not relying on a StringInfo Since the size of the string representation of an uuid is fixed, there is no benefit in using a StringInfo. This commit simplifies uuid_oud() to not rely on a StringInfo, where avoiding the overhead of the string manipulation makes the function

pgsql: Add lookup table for replication slot conflict reasons

2024-02-21 Thread Michael Paquier
Add lookup table for replication slot conflict reasons This commit switches the handling of the conflict cause strings for replication slots to use a table rather than being explicitly listed, using a C99-designated initializer syntax for the array elements. This makes the whole more readable

pgsql: Remove superfluous 'pgprocno' field from PGPROC

2024-02-21 Thread Heikki Linnakangas
Remove superfluous 'pgprocno' field from PGPROC It was always just the index of the PGPROC entry from the beginning of the proc array. Introduce a macro to compute it from the pointer instead. Reviewed-by: Andres Freund Discussion:

pgsql: MERGE ... DO NOTHING: require SELECT privileges

2024-02-21 Thread Alvaro Herrera
MERGE ... DO NOTHING: require SELECT privileges Verify that a user running MERGE with a DO NOTHING clause has privileges to read the table, even if no columns are referenced. Such privileges were already required if the ON clause or any of the WHEN conditions referenced any column at all, so

pgsql: Fix typo

2024-02-21 Thread Alvaro Herrera
Fix typo Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ed345c2728b3ebc160d8335464765679a08031b9 Modified Files -- src/backend/tcop/postgres.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: MERGE ... DO NOTHING: require SELECT privileges

2024-02-21 Thread Alvaro Herrera
MERGE ... DO NOTHING: require SELECT privileges Verify that a user running MERGE with a DO NOTHING clause has privileges to read the table, even if no columns are referenced. Such privileges were already required if the ON clause or any of the WHEN conditions referenced any column at all, so

pgsql: MERGE ... DO NOTHING: require SELECT privileges

2024-02-21 Thread Alvaro Herrera
MERGE ... DO NOTHING: require SELECT privileges Verify that a user running MERGE with a DO NOTHING clause has privileges to read the table, even if no columns are referenced. Such privileges were already required if the ON clause or any of the WHEN conditions referenced any column at all, so

pgsql: doc: Fix link to pg_ident_file_mappings view

2024-02-21 Thread Daniel Gustafsson
doc: Fix link to pg_ident_file_mappings view Commit a2c84990bea7 accidentally used the link for pg_hba_file_rules when linking to pg_ident_file_mappings. Backpatch to v16 where this was introduced. Author: Erik Wienhold Discussion:

pgsql: doc: Fix link to pg_ident_file_mappings view

2024-02-21 Thread Daniel Gustafsson
doc: Fix link to pg_ident_file_mappings view Commit a2c84990bea7 accidentally used the link for pg_hba_file_rules when linking to pg_ident_file_mappings. Backpatch to v16 where this was introduced. Author: Erik Wienhold Discussion:

pgsql: doc: Fix link to pg_ident_file_mappings view

2024-02-21 Thread Daniel Gustafsson
doc: Fix link to pg_ident_file_mappings view Commit a2c84990bea7 accidentally used the link for pg_hba_file_rules when linking to pg_ident_file_mappings. Backpatch to v16 where this was introduced. Author: Erik Wienhold Discussion: