pgsql: Introduce sequence_*() access functions

2024-02-25 Thread Michael Paquier
Introduce sequence_*() access functions Similarly to tables and indexes, these functions are able to open relations with a sequence relkind, which is useful to make a distinction with the other relation kinds. Previously, commands/sequence.c used a mix of table_{close,open}() and relation_{close,

pgsql: Fix incorrect format placeholder

2024-02-25 Thread Peter Eisentraut
Fix incorrect format placeholder Not only did the format placeholder not match the variable, the variable also didn't match the function it was getting its value from. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/025f0a6f9113efe89bb65b9efe0cb96a5d7c7ad1 Modified

pgsql: Back-patch test modifications that were done as part of b6df0798

2024-02-25 Thread Amit Kapila
Back-patch test modifications that were done as part of b6df0798a5. This commit fixes the intermittent buildfarm failures in 031_column_list. I missed to back-patch while committing b6df0798a5 in the HEAD. Diagnosed-by: Amit Kapila Author: Vignesh C Backpatch-through: 15 Discussion: https://postg

pgsql: Back-patch test modifications that were done as part of b6df0798

2024-02-25 Thread Amit Kapila
Back-patch test modifications that were done as part of b6df0798a5. This commit fixes the intermittent buildfarm failures in 031_column_list. I missed to back-patch while committing b6df0798a5 in the HEAD. Diagnosed-by: Amit Kapila Author: Vignesh C Backpatch-through: 15 Discussion: https://postg

pgsql: Promote assertion about !ReindexIsProcessingIndex to runtime err

2024-02-25 Thread Tom Lane
Promote assertion about !ReindexIsProcessingIndex to runtime error. When this assertion was installed (in commit d2f60a3ab), I thought it was only for catching server logic errors that caused accesses to catalogs that were undergoing index rebuilds. However, it will also fire in case of a user-de

pgsql: Promote assertion about !ReindexIsProcessingIndex to runtime err

2024-02-25 Thread Tom Lane
Promote assertion about !ReindexIsProcessingIndex to runtime error. When this assertion was installed (in commit d2f60a3ab), I thought it was only for catching server logic errors that caused accesses to catalogs that were undergoing index rebuilds. However, it will also fire in case of a user-de

pgsql: Promote assertion about !ReindexIsProcessingIndex to runtime err

2024-02-25 Thread Tom Lane
Promote assertion about !ReindexIsProcessingIndex to runtime error. When this assertion was installed (in commit d2f60a3ab), I thought it was only for catching server logic errors that caused accesses to catalogs that were undergoing index rebuilds. However, it will also fire in case of a user-de

pgsql: Promote assertion about !ReindexIsProcessingIndex to runtime err

2024-02-25 Thread Tom Lane
Promote assertion about !ReindexIsProcessingIndex to runtime error. When this assertion was installed (in commit d2f60a3ab), I thought it was only for catching server logic errors that caused accesses to catalogs that were undergoing index rebuilds. However, it will also fire in case of a user-de

pgsql: Promote assertion about !ReindexIsProcessingIndex to runtime err

2024-02-25 Thread Tom Lane
Promote assertion about !ReindexIsProcessingIndex to runtime error. When this assertion was installed (in commit d2f60a3ab), I thought it was only for catching server logic errors that caused accesses to catalogs that were undergoing index rebuilds. However, it will also fire in case of a user-de

pgsql: Promote assertion about !ReindexIsProcessingIndex to runtime err

2024-02-25 Thread Tom Lane
Promote assertion about !ReindexIsProcessingIndex to runtime error. When this assertion was installed (in commit d2f60a3ab), I thought it was only for catching server logic errors that caused accesses to catalogs that were undergoing index rebuilds. However, it will also fire in case of a user-de

pgsql: Doc: fix minor typos in two ECPG function descriptions.

2024-02-25 Thread Tom Lane
Doc: fix minor typos in two ECPG function descriptions. Noted by Aidar Imamov. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/57b28c08305a7696375eae9a0a26532f8fb84d1b Mo

pgsql: Doc: fix minor typos in two ECPG function descriptions.

2024-02-25 Thread Tom Lane
Doc: fix minor typos in two ECPG function descriptions. Noted by Aidar Imamov. Discussion: https://postgr.es/m/[email protected] Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7cbf8d3c5ef945de8c9db50639c23c2545b5b

pgsql: Doc: fix minor typos in two ECPG function descriptions.

2024-02-25 Thread Tom Lane
Doc: fix minor typos in two ECPG function descriptions. Noted by Aidar Imamov. Discussion: https://postgr.es/m/[email protected] Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/10f30873ddaf6984ebf5a87305fab0f4ae8f7

pgsql: Doc: fix minor typos in two ECPG function descriptions.

2024-02-25 Thread Tom Lane
Doc: fix minor typos in two ECPG function descriptions. Noted by Aidar Imamov. Discussion: https://postgr.es/m/[email protected] Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c3fdf13a53cee3488c07f2c8fe796c21949bc

pgsql: Doc: fix minor typos in two ECPG function descriptions.

2024-02-25 Thread Tom Lane
Doc: fix minor typos in two ECPG function descriptions. Noted by Aidar Imamov. Discussion: https://postgr.es/m/[email protected] Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b3b3effca60f11a6d95207f328c9462894b27

pgsql: Doc: fix minor typos in two ECPG function descriptions.

2024-02-25 Thread Tom Lane
Doc: fix minor typos in two ECPG function descriptions. Noted by Aidar Imamov. Discussion: https://postgr.es/m/[email protected] Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2b997d7db26e4c2be6b2474eeca801a50825f

pgsql: Improve documentation and GUC description for transaction_timeou

2024-02-25 Thread Alexander Korotkov
Improve documentation and GUC description for transaction_timeout Reported-by: Alexander Lakhin Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/28e858c0f951a5f86f43ba9b8922c64bba96d2e1 Modified Files -- doc/src/sgml/config.sgml| 4 ++-- src/b

pgsql: Remove flaky isolation tests for timeouts

2024-02-25 Thread Alexander Korotkov
Remove flaky isolation tests for timeouts 51efe38cb92f introduced bunch of tests for idle_in_transaction_session_timeout, transaction_timeout and statement_timeout. These tests were too flaky on some slow buildfarm machines, so we plan to replace them with TAP tests using injection points. This co