pgsql: Remove last NULL element in config_group_names[]

2024-02-27 Thread Michael Paquier
Remove last NULL element in config_group_names[] This has not been needed since 9d77708d83ee where there was a loop to print all the possible GUC groups, relying on the last element to be NULL. Author: Japin Li Reviewed-By: Jelte Fennema-Nio Discussion:

pgsql: Refactor AllocSetAlloc(), separating hot and cold paths

2024-02-27 Thread David Rowley
Refactor AllocSetAlloc(), separating hot and cold paths Allocating from a free list or from a block which contains enough space already, we deem to be common code paths and want to optimize for those. Having to allocate a new block, either a normal block or a dedicated one for a large allocation,

pgsql: Use C99-designated initializer syntax for more arrays

2024-02-27 Thread Michael Paquier
Use C99-designated initializer syntax for more arrays This is in the same spirit as ef5e2e90859a, updating this time some arrays in parser.c, relpath.c, guc_tables.c and pg_dump_sort.c so as the order of their elements has no need to match the enum structures they are based on anymore. Author:

pgsql: Fix comments for the dshash_parameters struct.

2024-02-27 Thread Nathan Bossart
Fix comments for the dshash_parameters struct. A recent commit added a copy_function member to the dshash_parameters struct, but it missed updating a couple of comments that refer to the function pointer members of this struct. One of those comments also refers to a tranche_name member and non-

pgsql: Rationalize and improve error messages for some jsonpath items

2024-02-27 Thread Andrew Dunstan
Rationalize and improve error messages for some jsonpath items This is a followup to commit 66ea94e8e6. Error mssages concerning incorrect formats for date-time types are unified and parameterized, instead of using a fully separate error message for each type. Similarly, error messages