pgsql: Combine headerscheck and cpluspluscheck scripts

2024-03-09 Thread Peter Eisentraut
Combine headerscheck and cpluspluscheck scripts They are mostly the same, and it is tedious to maintain two copies of essentially the same exclude list. headerscheck now has a new option --cplusplus to select the cpluspluscheck functionality. The top-level make targets are still the same. Revie

Re: pgsql: Catalog changes preparing for builtin collation provider.

2024-03-09 Thread Tom Lane
Jeff Davis writes: > On Sat, 2024-03-09 at 22:50 +, Jeff Davis wrote: >> Catalog changes preparing for builtin collation provider. > This is causing problems on a couple buildfarm members (mantid, > lapwing, snakefly) that all look like this: > ... > That's a little confusing to me: the '(?^:

Re: pgsql: Catalog changes preparing for builtin collation provider.

2024-03-09 Thread Jeff Davis
On Sat, 2024-03-09 at 22:50 +, Jeff Davis wrote: > Catalog changes preparing for builtin collation provider. This is causing problems on a couple buildfarm members (mantid, lapwing, snakefly) that all look like this: # Running: pg_upgrade --no-sync -d /home/postgres/buildroot/HEAD/pgsql.build

pgsql: Catalog changes preparing for builtin collation provider.

2024-03-09 Thread Jeff Davis
Catalog changes preparing for builtin collation provider. Rename pg_collation.colliculocale to colllocale, and pg_database.daticulocale to datlocale. These names reflects that the fields will be useful for the upcoming builtin provider as well, not just for ICU. This is purely a rename; no change

pgsql: Make contrib/tablefunc crosstab() also check typmod

2024-03-09 Thread Joe Conway
Make contrib/tablefunc crosstab() also check typmod contrib/tablefunc connectby() checks both type OID and typmod for its output columns while crosstab() only checks type OID. Fix that by makeing the crosstab() check look more like the connectby() check. Reported-by: Tom Lane Reviewed-by: Tom Lan

pgsql: Simplify and merge unwanted-module drop logic in AdjustUpgrade.p

2024-03-09 Thread Tom Lane
Simplify and merge unwanted-module drop logic in AdjustUpgrade.pm. In be7800674 and followups, we failed to notice that there was already a better way to do it: instead of using DROP DATABASE IF EXISTS, we can check the list of existing DBs. Also, there seems no reason not to merge this into the

pgsql: Improve wrong-tuple-type error reports in contrib/tablefunc.

2024-03-09 Thread Tom Lane
Improve wrong-tuple-type error reports in contrib/tablefunc. These messages were fairly confusing, and didn't match the column names used in the SGML docs. Try to improve that. Also use error codes more specific than ERRCODE_SYNTAX_ERROR. Patch by me, reviewed by Joe Conway Discussion: https://

Re: pgsql: Further further fix pg_upgrade crossversion test for adminpack.

2024-03-09 Thread Jeff Davis
On Sat, 2024-03-09 at 12:49 -0500, Tom Lane wrote: > I guess you are running that in some way that the rest of us aren't. FWIW, I am following the directions in src/bin/pg_upgrade/TESTING. > > However, we'd inevitably hit the more-than-one-DB-to-drop problem > eventually, so better to fix that n

pgsql: Run perltidy on 002_pg_upgrade.pl.

2024-03-09 Thread Jeff Davis
Run perltidy on 002_pg_upgrade.pl. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b0289574bdf1202248201a3143d1459bdf5727fd Modified Files -- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 8 1 file changed, 4 insertions(+), 4 deletions(-)

pgsql: Fix cross-version pg_upgrade test.

2024-03-09 Thread Jeff Davis
Fix cross-version pg_upgrade test. Pass each statement as a separate '-c' arg, so they don't get combined into a single transaction. Discussion: https://postgr.es/m/bca97aecb50b2026b7dbc26604bf31861c819a64.ca...@j-davis.com Reviewed-by: Tom Lane Branch -- master Details --- https://git

Re: pgsql: Further further fix pg_upgrade crossversion test for adminpack.

2024-03-09 Thread Tom Lane
Jeff Davis writes: > Ever since this commit the cross-version upgrade test is failing (for > me, at least) with: > # Running: psql -X -v ON_ERROR_STOP=1 -c drop database if exists > contrib_regression_adminpack; > drop database if exists regression_adminpack -d port=53977 > host=/tmp/EK6UT_TufI d