pgsql: Revert "Add basic TAP tests for the low-level backup method"

2024-03-13 Thread Michael Paquier
Revert "Add basic TAP tests for the low-level backup method" This reverts commit 99b4a63bef94. The test is proving to be unstable, so revert it for now. One of the failures seen involves the cluster started without the backup_label, where the archives of the primary are overwritten, causing

pgsql: Add basic TAP tests for the low-level backup method

2024-03-13 Thread Michael Paquier
Add basic TAP tests for the low-level backup method There are currently no tests for the low-level backup method where pg_backup_start() and pg_backup_stop() are involved while taking a file-system backup. The tests introduced in this commit rely on a background psql process to make sure that

pgsql: Improve documentation for pg_stat_checkpointer fields

2024-03-13 Thread Alexander Korotkov
Improve documentation for pg_stat_checkpointer fields pg_stat_checkpointer contains statistics for checkpoints and restartpoints. Before 12915a58eec9 documentation said only about checkpoints implying that restartpoint is the variation of checkpoint. 12915a58eec9 introduced new separate

pgsql: Reintroduce MAINTAIN privilege and pg_maintain predefined role.

2024-03-13 Thread Nathan Bossart
Reintroduce MAINTAIN privilege and pg_maintain predefined role. Roles with MAINTAIN on a relation may run VACUUM, ANALYZE, REINDEX, REFRESH MATERIALIZE VIEW, CLUSTER, and LOCK TABLE on the relation. Roles with privileges of pg_maintain may run those same commands on all relations. This was

pgsql: Add the system identifier to backup manifests.

2024-03-13 Thread Robert Haas
Add the system identifier to backup manifests. Before this patch, if you took a full backup on server A and then tried to use the backup manifest to take an incremental backup on server B, it wouldn't know that the manifest was from a different server and so the incremental backup operation could

pgsql: Hopefully make libpq_pipeline's new cancel test more reliable

2024-03-13 Thread Alvaro Herrera
Hopefully make libpq_pipeline's new cancel test more reliable The newly introduced cancel test in libpq_pipeline was flaky. It's not completely clear why, but one option is that the check for "active" was actually seeing the active state for the previous query. This change should address any such

pgsql: Expose new function get_controlfile_by_exact_path().

2024-03-13 Thread Robert Haas
Expose new function get_controlfile_by_exact_path(). This works just like get_controlfile(), but expects the path to the control file rather than the path to the data directory that contains the control file. This makes more sense in cases where the caller has already constructed the path to the

pgsql: Make the order of the header file includes consistent

2024-03-13 Thread Peter Eisentraut
Make the order of the header file includes consistent Similar to commit 7e735035f20. Author: Richard Guo Reviewed-by: Bharath Rupireddy Discussion: https://www.postgresql.org/message-id/flat/CAMbWs4-WhpCFMbXCjtJ%2BFzmjfPrp7Hw1pk4p%2BZpU95Kh3ofZ1A%40mail.gmail.com Branch -- master

pgsql: doc: Improve a couple of places in the MERGE docs.

2024-03-13 Thread Dean Rasheed
doc: Improve a couple of places in the MERGE docs. In the synopsis, make the syntax for merge_update consistent with the syntax for a plain UPDATE command. It was missing the optional "ROW" keyword that can be used in a multi-column assignment, and the option to assign from a multi-column

pgsql: doc: Improve a couple of places in the MERGE docs.

2024-03-13 Thread Dean Rasheed
doc: Improve a couple of places in the MERGE docs. In the synopsis, make the syntax for merge_update consistent with the syntax for a plain UPDATE command. It was missing the optional "ROW" keyword that can be used in a multi-column assignment, and the option to assign from a multi-column

pgsql: doc: Improve a couple of places in the MERGE docs.

2024-03-13 Thread Dean Rasheed
doc: Improve a couple of places in the MERGE docs. In the synopsis, make the syntax for merge_update consistent with the syntax for a plain UPDATE command. It was missing the optional "ROW" keyword that can be used in a multi-column assignment, and the option to assign from a multi-column

pgsql: meson: macos: Avoid warnings on Sonoma

2024-03-13 Thread Andres Freund
meson: macos: Avoid warnings on Sonoma Starting with the Sonoma toolchain macos' linker emits warnings when the same library is linked to twice. That's ill considered, as the same library can be used by multiple subsidiary libraries. Luckily there's a flag to suppress that warning. On Ventura

pgsql: meson: macos: Avoid warnings on Sonoma

2024-03-13 Thread Andres Freund
meson: macos: Avoid warnings on Sonoma Starting with the Sonoma toolchain macos' linker emits warnings when the same library is linked to twice. That's ill considered, as the same library can be used by multiple subsidiary libraries. Luckily there's a flag to suppress that warning. On Ventura