pgsql: Try again to add test coverage for pg_combinebackup w/tablespace

2024-04-23 Thread Robert Haas
Try again to add test coverage for pg_combinebackup w/tablespaces. My previous attempt to add this had to be reverted in commit 82023d47de9e262730b1f9b4ea77fae201a89d0a. I've revised the problematic code a bit; hopefully it is OK now. Discussion:

pgsql: Post review fixes for test_json_parser test module

2024-04-23 Thread Andrew Dunstan
Post review fixes for test_json_parser test module . Add missing copytight notices . improve code coverage . put work files in a temp directory in the standard location . improve error checking in C code . indent perl files with perltidy . add some comments per comments from Michael Paquier

pgsql: Remove some unnecessary fields from executor nodes.

2024-04-23 Thread Tom Lane
Remove some unnecessary fields from executor nodes. JsonExprState.input_finfo is only assigned to, never read, and it's really fairly useless since the value can be gotten out of the adjacent input_fcinfo field. Let's remove it before someone starts to depend on it. While here, also remove

pgsql: Fix code for probing availability of AVX-512.

2024-04-23 Thread Nathan Bossart
Fix code for probing availability of AVX-512. This commit fixes a few things: * Instead of checking for CPU support of the "xsave" extension, we need to check for OS support of XGETBV instructions via the "osxsave" flag. * We must check that additional XCR0 bits are set to be sure the ZMM

pgsql: Improve "out of range" error messages for GUCs.

2024-04-23 Thread Tom Lane
Improve "out of range" error messages for GUCs. If the GUC has a unit, label the minimum and maximum values with the unit explicitly. Per suggestion from Jian He. Discussion: https://postgr.es/m/cacjufxfjo6fyvg9w8yvnaxbjp+ej9wiee9d9vw5lppzylnl...@mail.gmail.com Branch -- master Details

Re: pgsql: Introduce "builtin" collation provider.

2024-04-23 Thread Peter Eisentraut
On 14.03.24 07:39, Jeff Davis wrote: Introduce "builtin" collation provider. Jeff, I think I found a small bug in this commit. The new code in dbcommands.c createdb() reads like this: + /* validate provider-specific parameters */ + if (dblocprovider != COLLPROVIDER_BUILTIN) + { +

pgsql: Fix the handling of the failover option in subscription commands

2024-04-23 Thread Amit Kapila
Fix the handling of the failover option in subscription commands. Do not allow ALTER SUBSCRIPTION ... SET (failover = on|off) in a transaction block as the changed failover option of the slot can't be rolled back. For the same reason, we refrain from altering the replication slot's failover