pgsql: Fix the missing table sync due to improper invalidation handling

2024-04-24 Thread Amit Kapila
Fix the missing table sync due to improper invalidation handling. We missed performing table sync if the invalidation happened while the non-ready tables list was being prepared. This occurs because the sync state was set to valid at the end of non-ready table list preparation irrespective of the

pgsql: Fix the missing table sync due to improper invalidation handling

2024-04-24 Thread Amit Kapila
Fix the missing table sync due to improper invalidation handling. We missed performing table sync if the invalidation happened while the non-ready tables list was being prepared. This occurs because the sync state was set to valid at the end of non-ready table list preparation irrespective of the

pgsql: Fix the missing table sync due to improper invalidation handling

2024-04-24 Thread Amit Kapila
Fix the missing table sync due to improper invalidation handling. We missed performing table sync if the invalidation happened while the non-ready tables list was being prepared. This occurs because the sync state was set to valid at the end of non-ready table list preparation irrespective of the

pgsql: Improve comment of DeallocateStmt->isall

2024-04-24 Thread Michael Paquier
Improve comment of DeallocateStmt->isall This field is not used directly in the code, but it is important for query jumbling to be able to make a difference between a named DEALLOCATE and DEALLOCATE ALL (see bb45156f342c). This behavior is tracked in the regression tests of pg_stat_statements,

pgsql: Doc: fix minor oversight in ALTER DEFAULT PRIVILEGES ref page.

2024-04-24 Thread Tom Lane
Doc: fix minor oversight in ALTER DEFAULT PRIVILEGES ref page. Since schemas have more than one kind of privilege, we should use the synopsis form that shows the privilege being possibly repeated. Yugo Nagata Discussion: https://postgr.es/m/20240424155052.7ac0d0773e4ae27ab723f...@sraoss.co.jp

pgsql: Doc: fix minor oversight in ALTER DEFAULT PRIVILEGES ref page.

2024-04-24 Thread Tom Lane
Doc: fix minor oversight in ALTER DEFAULT PRIVILEGES ref page. Since schemas have more than one kind of privilege, we should use the synopsis form that shows the privilege being possibly repeated. Yugo Nagata Discussion: https://postgr.es/m/20240424155052.7ac0d0773e4ae27ab723f...@sraoss.co.jp

pgsql: Doc: fix minor oversight in ALTER DEFAULT PRIVILEGES ref page.

2024-04-24 Thread Tom Lane
Doc: fix minor oversight in ALTER DEFAULT PRIVILEGES ref page. Since schemas have more than one kind of privilege, we should use the synopsis form that shows the privilege being possibly repeated. Yugo Nagata Discussion: https://postgr.es/m/20240424155052.7ac0d0773e4ae27ab723f...@sraoss.co.jp

pgsql: Doc: fix minor oversight in ALTER DEFAULT PRIVILEGES ref page.

2024-04-24 Thread Tom Lane
Doc: fix minor oversight in ALTER DEFAULT PRIVILEGES ref page. Since schemas have more than one kind of privilege, we should use the synopsis form that shows the privilege being possibly repeated. Yugo Nagata Discussion: https://postgr.es/m/20240424155052.7ac0d0773e4ae27ab723f...@sraoss.co.jp

pgsql: Doc: fix minor oversight in ALTER DEFAULT PRIVILEGES ref page.

2024-04-24 Thread Tom Lane
Doc: fix minor oversight in ALTER DEFAULT PRIVILEGES ref page. Since schemas have more than one kind of privilege, we should use the synopsis form that shows the privilege being possibly repeated. Yugo Nagata Discussion: https://postgr.es/m/20240424155052.7ac0d0773e4ae27ab723f...@sraoss.co.jp

pgsql: Doc: fix minor oversight in ALTER DEFAULT PRIVILEGES ref page.

2024-04-24 Thread Tom Lane
Doc: fix minor oversight in ALTER DEFAULT PRIVILEGES ref page. Since schemas have more than one kind of privilege, we should use the synopsis form that shows the privilege being possibly repeated. Yugo Nagata Discussion: https://postgr.es/m/20240424155052.7ac0d0773e4ae27ab723f...@sraoss.co.jp

Re: pgsql: Refactor libpq state machine for negotiating encryption

2024-04-24 Thread Peter Eisentraut
On 08.04.24 03:25, Heikki Linnakangas wrote: Refactor libpq state machine for negotiating encryption This fixes the few corner cases noted in commit 705843d294, as shown by the changes in the test. Either this or something nearby appears to have broken the error reporting from psql or libpq

pgsql: Add pg_logging_init() calls missing in commit ba3e6e2bca

2024-04-24 Thread Andrew Dunstan
Add pg_logging_init() calls missing in commit ba3e6e2bca As noticed by Michael Paquier. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cc893b82370b5d68e0a72f5bb1663644a3a0351d Modified Files --

pgsql: Doc: fix prompt in psql crosstabview example

2024-04-24 Thread Daniel Gustafsson
Doc: fix prompt in psql crosstabview example The prompt in the crosstabview example was incorrectly indicating an open parenthesis where there is none in the example query. Fix by changing to the normal multi-line prompt. Reported-by: y.sabu...@gmail.com Discussion:

pgsql: doc: Fix up spacing around verbatim DocBook elements

2024-04-24 Thread Peter Eisentraut
doc: Fix up spacing around verbatim DocBook elements Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b53d58097d7d5712d819d06e0416dec0a7db2479 Modified Files -- doc/src/sgml/func.sgml | 32

pgsql: pg_combinebackup: Add --version to --help output

2024-04-24 Thread Peter Eisentraut
pg_combinebackup: Add --version to --help output (It was already on the man page.) Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/83751691e9c89af15103220b62d78cf5be73dbfd Modified Files -- src/bin/pg_combinebackup/pg_combinebackup.c | 1 + 1 file

pgsql: doc: Correct jsonpath string literal escapes description

2024-04-24 Thread Peter Eisentraut
doc: Correct jsonpath string literal escapes description The paragraph describing the JavaScript string literals allowed in jsonpath expressions unnecessarily mentions JSON by erroneously listing \v as allowed by JSON and mentioning the \xNN and \u{N...} backslash escapes as deviations from JSON

pgsql: doc: Correct jsonpath string literal escapes description

2024-04-24 Thread Peter Eisentraut
doc: Correct jsonpath string literal escapes description The paragraph describing the JavaScript string literals allowed in jsonpath expressions unnecessarily mentions JSON by erroneously listing \v as allowed by JSON and mentioning the \xNN and \u{N...} backslash escapes as deviations from JSON

pgsql: doc: Correct jsonpath string literal escapes description

2024-04-24 Thread Peter Eisentraut
doc: Correct jsonpath string literal escapes description The paragraph describing the JavaScript string literals allowed in jsonpath expressions unnecessarily mentions JSON by erroneously listing \v as allowed by JSON and mentioning the \xNN and \u{N...} backslash escapes as deviations from JSON

pgsql: doc: Correct jsonpath string literal escapes description

2024-04-24 Thread Peter Eisentraut
doc: Correct jsonpath string literal escapes description The paragraph describing the JavaScript string literals allowed in jsonpath expressions unnecessarily mentions JSON by erroneously listing \v as allowed by JSON and mentioning the \xNN and \u{N...} backslash escapes as deviations from JSON

pgsql: doc: Correct jsonpath string literal escapes description

2024-04-24 Thread Peter Eisentraut
doc: Correct jsonpath string literal escapes description The paragraph describing the JavaScript string literals allowed in jsonpath expressions unnecessarily mentions JSON by erroneously listing \v as allowed by JSON and mentioning the \xNN and \u{N...} backslash escapes as deviations from JSON

pgsql: doc: Correct jsonpath string literal escapes description

2024-04-24 Thread Peter Eisentraut
doc: Correct jsonpath string literal escapes description The paragraph describing the JavaScript string literals allowed in jsonpath expressions unnecessarily mentions JSON by erroneously listing \v as allowed by JSON and mentioning the \xNN and \u{N...} backslash escapes as deviations from JSON

pgsql: pg_combinebackup: Put newer options in consistent order in --hel

2024-04-24 Thread Peter Eisentraut
pg_combinebackup: Put newer options in consistent order in --help and man page Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3886530caa01cac7179fed6b6e1d303710c027d9 Modified Files -- doc/src/sgml/ref/pg_combinebackup.sgml | 90

pgsql: Doc: Use past tense for things which happened in the past

2024-04-24 Thread Daniel Gustafsson
Doc: Use past tense for things which happened in the past The paragraph on SSL compression is largely describing events which took place many years ago, so reword with past tense. Reviewed-by: Peter Eisentraut Reviewed-by: Michael Paquier Discussion:

pgsql: Support disallowing SSL renegotiation when using LibreSSL

2024-04-24 Thread Daniel Gustafsson
Support disallowing SSL renegotiation when using LibreSSL LibreSSL doesn't support the SSL_OP_NO_RENEGOTIATION macro which is used by OpenSSL, instead it has invented a similar one for client- side renegotiation: SSL_OP_NO_CLIENT_RENEGOTIATION. This has been supported since LibreSSL 2.5.1 which

pgsql: Support SSL_R_VERSION_TOO_LOW when using LibreSSL

2024-04-24 Thread Daniel Gustafsson
Support SSL_R_VERSION_TOO_LOW when using LibreSSL The SSL_R_VERSION_TOO_LOW error reason is supported in LibreSSL since LibreSSL 3.6.3, shipped in OpenBSD 7.2. SSL_R_VERSION_TOO_HIGH is on the other hand not supported in any version of LibreSSL. Previously we only checked for

pgsql: pg_dump: Put new options in consistent order in --help and man p

2024-04-24 Thread Peter Eisentraut
pg_dump: Put new options in consistent order in --help and man page Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/256b4b060614f4e54e49bb43a54404af4f1ef61d Modified Files -- doc/src/sgml/ref/pg_dump.sgml | 42 +-

pgsql: doc: Fix order of options on pg_createsubscriber man page

2024-04-24 Thread Peter Eisentraut
doc: Fix order of options on pg_createsubscriber man page Some options were listed in an order that was inconsistent with the --help output and everything else. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/286eea5d3ae33a8c22d46a051f8ac6069c8b779d Modified Files

pgsql: pg_walsummary: Document --version option

2024-04-24 Thread Peter Eisentraut
pg_walsummary: Document --version option It was working, but it was not shown in the --help output or on the man page. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f994ed89a98b9aed405c760f157a10125eb8d567 Modified Files --

pgsql: Remove obsolete symbol from ecpg_config.h.in

2024-04-24 Thread Peter Eisentraut
Remove obsolete symbol from ecpg_config.h.in HAVE_LONG_LONG_INT was not added to ecpg_config.h.in by the meson build system, but rather than add it there, we decided to remove it from the makefile build system, to make both consistent that way. There is no documentation or examples that suggest