pgsql: Doc: fix misleading syntax synopses for targetlists.

2024-07-25 Thread Tom Lane
Doc: fix misleading syntax synopses for targetlists. In the syntax synopses for SELECT, INSERT, UPDATE, etc, SELECT ... and RETURNING ... targetlists were missing { ... } braces around an OR (|) operator. That allows misinterpretation which could lead to confusion. David G. Johnston, per gripe f

pgsql: Doc: fix misleading syntax synopses for targetlists.

2024-07-25 Thread Tom Lane
Doc: fix misleading syntax synopses for targetlists. In the syntax synopses for SELECT, INSERT, UPDATE, etc, SELECT ... and RETURNING ... targetlists were missing { ... } braces around an OR (|) operator. That allows misinterpretation which could lead to confusion. David G. Johnston, per gripe f

pgsql: Doc: fix misleading syntax synopses for targetlists.

2024-07-25 Thread Tom Lane
Doc: fix misleading syntax synopses for targetlists. In the syntax synopses for SELECT, INSERT, UPDATE, etc, SELECT ... and RETURNING ... targetlists were missing { ... } braces around an OR (|) operator. That allows misinterpretation which could lead to confusion. David G. Johnston, per gripe f

pgsql: Doc: fix misleading syntax synopses for targetlists.

2024-07-25 Thread Tom Lane
Doc: fix misleading syntax synopses for targetlists. In the syntax synopses for SELECT, INSERT, UPDATE, etc, SELECT ... and RETURNING ... targetlists were missing { ... } braces around an OR (|) operator. That allows misinterpretation which could lead to confusion. David G. Johnston, per gripe f

pgsql: Doc: fix misleading syntax synopses for targetlists.

2024-07-25 Thread Tom Lane
Doc: fix misleading syntax synopses for targetlists. In the syntax synopses for SELECT, INSERT, UPDATE, etc, SELECT ... and RETURNING ... targetlists were missing { ... } braces around an OR (|) operator. That allows misinterpretation which could lead to confusion. David G. Johnston, per gripe f

pgsql: Doc: fix misleading syntax synopses for targetlists.

2024-07-25 Thread Tom Lane
Doc: fix misleading syntax synopses for targetlists. In the syntax synopses for SELECT, INSERT, UPDATE, etc, SELECT ... and RETURNING ... targetlists were missing { ... } braces around an OR (|) operator. That allows misinterpretation which could lead to confusion. David G. Johnston, per gripe f

pgsql: Doc: fix misleading syntax synopses for targetlists.

2024-07-25 Thread Tom Lane
Doc: fix misleading syntax synopses for targetlists. In the syntax synopses for SELECT, INSERT, UPDATE, etc, SELECT ... and RETURNING ... targetlists were missing { ... } braces around an OR (|) operator. That allows misinterpretation which could lead to confusion. David G. Johnston, per gripe f

pgsql: Doc: update some HTTP links to point to canonical URLs.

2024-07-25 Thread Tom Lane
Doc: update some HTTP links to point to canonical URLs. These aren't actually broken at present, but we might as well avoid redirects. Joel Jacobson Discussion: https://postgr.es/m/8ccc96c7-0515-491b-be98-cfacdaeda...@app.fastmail.com Branch -- master Details --- https://git.postgresq

pgsql: Document restrictions regarding incremental backups and standbys

2024-07-25 Thread Robert Haas
Document restrictions regarding incremental backups and standbys. If you try to take an incremental backup on a standby and there hasn't been much system activity, it might fail. Document why this happens. Also add a hint to the error message you get, to make it more likely that users will underst

pgsql: Document restrictions regarding incremental backups and standbys

2024-07-25 Thread Robert Haas
Document restrictions regarding incremental backups and standbys. If you try to take an incremental backup on a standby and there hasn't been much system activity, it might fail. Document why this happens. Also add a hint to the error message you get, to make it more likely that users will underst

pgsql: Add argument names to the regexp_XXX functions.

2024-07-25 Thread Tom Lane
Add argument names to the regexp_XXX functions. This change allows these functions to be called using named-argument notation, which can be helpful for readability, particularly for the ones with many arguments. There was considerable debate about exactly which names to use, but in the end we set

pgsql: pg_createsubscriber: Message improvements

2024-07-25 Thread Peter Eisentraut
pg_createsubscriber: Message improvements Objects are typically "in" a database, not "on". Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6622da8d3c7153fce58a35448f37a8869681625c Modified Files -- src/bin/pg_basebackup/pg_createsubscriber.c

pgsql: pg_createsubscriber: Message improvements

2024-07-25 Thread Peter Eisentraut
pg_createsubscriber: Message improvements Objects are typically "in" a database, not "on". Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/05faf06e9c21f012355e7095435a5bfb013f5eec Modified Files -- src/bin/pg_basebackup/pg_createsubscriber.c| 26

pgsql: pg_upgrade: Remove unused macro

2024-07-25 Thread Daniel Gustafsson
pg_upgrade: Remove unused macro Commit f06b1c598 removed validate_exec from pg_upgrade and instead exported it from src/common, but the macro for checking executable suffix on Windows was accidentally left. Fix by removing. Author: Alexander Lakhin Discussion: https://postgr.es/m/c1d63754-cb85-

pgsql: pgcrypto: Remove unused binary from clean target

2024-07-25 Thread Daniel Gustafsson
pgcrypto: Remove unused binary from clean target Generation of the gen-rtab binary was removed in db7d1a7b0 but it was accidentally left in the cleaning target. Remove since it is no longer built. Author: Alexander Lakhin Discussion: https://postgr.es/m/c1d63754-cb85-2d8a-8409-bde2c4d2d...@gmai

pgsql: Remove useless unconstify() call

2024-07-25 Thread Peter Eisentraut
Remove useless unconstify() call This should have been part of 67c0ef9752 but was apparently forgotten there. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c5c71830267b42098add2862df4b15bc25ae0103 Modified Files -- src/bin/pg_dump/compress_gzip.c | 2

pgsql: Remove useless unconstify() call

2024-07-25 Thread Peter Eisentraut
Remove useless unconstify() call This should have been part of 67c0ef9752 but was apparently forgotten there. Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b5006abcdc18f19b6f2d5a2dfa99302666aa6d63 Modified Files -- src/bin/pg_dump/compress_gzip

pgsql: Fix -Wmissing-variable-declarations warnings for float.c special

2024-07-25 Thread Peter Eisentraut
Fix -Wmissing-variable-declarations warnings for float.c special case This adds extern declarations for the global variables defined in float.c but not meant for external use. This is a workaround to be able to add -Wmissing-variable-declarations to the global set of warning options in the near f

pgsql: Add extern declarations for Bison global variables

2024-07-25 Thread Peter Eisentraut
Add extern declarations for Bison global variables This adds extern declarations for some global variables produced by Bison that are not already declared in its generated header file. This is a workaround to be able to add -Wmissing-variable-declarations to the global set of warning options in th