On Mon, Sep 02, 2024 at 02:55:50AM +0300, Alexander Korotkov wrote:
> Could you, please, check the attached patch?
The patch moving the code looks correct at quick glance.
Now, I've been staring at this line, wondering why this is required
while WaitForLSNReplay() does not return any status:
+
On Mon, Sep 2, 2024 at 2:28 AM Michael Paquier wrote:
> On Sun, Sep 01, 2024 at 10:35:27PM +0300, Alexander Korotkov wrote:
> > This path hasn't changes since the patch revision when it was a
> > utility command. I agree that this doesn't look like proper path for
> > stored procedure. But I don
On Sun, Sep 01, 2024 at 10:35:27PM +0300, Alexander Korotkov wrote:
> This path hasn't changes since the patch revision when it was a
> utility command. I agree that this doesn't look like proper path for
> stored procedure. But I don't think src/backend/utils/adt is
> appropriate path either, be
Rename enum labels of PG_Locale_Strategy
PG_REGEX_BUILTIN was added in f69319f2f1fb but it did not follow the
same pattern as the previous labels, i.e. PG_LOCALE_*. In addition to
this, the two libc strategies did not include in the name that they were
related to this library.
The enum labels ar
On Fri, Aug 30, 2024 at 10:42 PM Peter Eisentraut wrote:
> On 02.08.24 20:22, Alexander Korotkov wrote:
> > Implement pg_wal_replay_wait() stored procedure
>
> Why is this under src/backend/command/? Wouldn't it belong under
> src/backend/utils/adt/?
This path hasn't changes since the patch revi