pgsql: Remove lc_ctype_is_c().

2024-09-06 Thread Jeff Davis
Remove lc_ctype_is_c(). Instead always fetch the locale and look at the ctype_is_c field. hba.c relies on regexes working for the C locale without needing catalog access, which worked before due to a special case for C_COLLATION_OID in lc_ctype_is_c(). Move the special case to pg_set_regex_collat

pgsql: Fix incorrect pg_stat_io output on 32-bit machines.

2024-09-06 Thread Tom Lane
Fix incorrect pg_stat_io output on 32-bit machines. pg_stat_get_io() applied TimestampTzGetDatum twice to the stat_reset_timestamp value. On 64-bit builds that's harmless because TimestampTzGetDatum is a no-op, but on 32-bit builds it results in displaying garbage in the stats_reset column of the

pgsql: Fix incorrect pg_stat_io output on 32-bit machines.

2024-09-06 Thread Tom Lane
Fix incorrect pg_stat_io output on 32-bit machines. pg_stat_get_io() applied TimestampTzGetDatum twice to the stat_reset_timestamp value. On 64-bit builds that's harmless because TimestampTzGetDatum is a no-op, but on 32-bit builds it results in displaying garbage in the stats_reset column of the

pgsql: Fix incorrect pg_stat_io output on 32-bit machines.

2024-09-06 Thread Tom Lane
Fix incorrect pg_stat_io output on 32-bit machines. pg_stat_get_io() applied TimestampTzGetDatum twice to the stat_reset_timestamp value. On 64-bit builds that's harmless because TimestampTzGetDatum is a no-op, but on 32-bit builds it results in displaying garbage in the stats_reset column of the

pgsql: Remove useless unconstify

2024-09-06 Thread Peter Eisentraut
Remove useless unconstify Digging into the history, this was not necessary even when it was added, but might have been some time before that. In any case, there is no use for this now. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9e43ab3dd79ddb5a6a3f7cdb5b1d6dff

pgsql: SQL/JSON: Fix default ON ERROR behavior for JSON_TABLE

2024-09-06 Thread Amit Langote
SQL/JSON: Fix default ON ERROR behavior for JSON_TABLE Use EMPTY ARRAY instead of EMPTY. This change does not affect the runtime behavior of JSON_TABLE(), which continues to return an empty relation ON ERROR. It only alters whether the default ON ERROR behavior is shown in the deparsed output. R

pgsql: SQL/JSON: Fix JSON_TABLE() column deparsing

2024-09-06 Thread Amit Langote
SQL/JSON: Fix JSON_TABLE() column deparsing The deparsing code in get_json_expr_options() unnecessarily emitted the default column-specific ON ERROR / EMPTY behavior when the top-level ON ERROR behavior in JSON_TABLE was set to ERROR. Fix that by not overriding the column-specific default, determi

pgsql: SQL/JSON: Fix JSON_TABLE() column deparsing

2024-09-06 Thread Amit Langote
SQL/JSON: Fix JSON_TABLE() column deparsing The deparsing code in get_json_expr_options() unnecessarily emitted the default column-specific ON ERROR / EMPTY behavior when the top-level ON ERROR behavior in JSON_TABLE was set to ERROR. Fix that by not overriding the column-specific default, determi

pgsql: SQL/JSON: Fix default ON ERROR behavior for JSON_TABLE

2024-09-06 Thread Amit Langote
SQL/JSON: Fix default ON ERROR behavior for JSON_TABLE Use EMPTY ARRAY instead of EMPTY. This change does not affect the runtime behavior of JSON_TABLE(), which continues to return an empty relation ON ERROR. It only alters whether the default ON ERROR behavior is shown in the deparsed output. R