pgsql: Add parameter "connstr" to PostgreSQL::Test::Cluster::background

Add parameter "connstr" to PostgreSQL::Test::Cluster::background_psql Like for Cluster::psql, this can be handy to force the use of a connection string with some values overriden, like a "host". Author: Aidar Imamov Discussion: https://postgr.es/m/ecacb079efc533aed3c234cbcb5b0...@postgrespro.ru

pgsql: Restore relmapper state early enough in parallel workers.

Restore relmapper state early enough in parallel workers. We need to do RestoreRelationMap before loading catalog-derived state, else the worker may end up with catalog relcache entries containing stale relfilenode data. Move up RestoreReindexState too, on the principle that that should also happ

pgsql: psql: Add tests for repeated calls of \bind[_named]

psql: Add tests for repeated calls of \bind[_named] The implementation assumes that on multiple calls of these meta-commands the last one wins. Multiple \g calls in-between mean multiple executions. There were no tests to check these properties, hence let's add something. Author: Jelte Fennema-

Re: pgsql: Convert some extern variables to static

On Fri, Sep 20, 2024 at 11:15 AM Tom Lane wrote: > Peter Eisentraut writes: > > Convert some extern variables to static > > I'm surprised it took me so long to notice, but this commit > makes headerscheck unhappy: Also discussed at: https://www.postgresql.org/message-id/flat/CA%2BhUKG%2BYVt5MBD

Re: pgsql: Convert some extern variables to static

Peter Eisentraut writes: > Convert some extern variables to static I'm surprised it took me so long to notice, but this commit makes headerscheck unhappy: $ src/tools/pginclude/headerscheck In file included from /tmp/headerscheck.40tbNq/test.c:2: ./contrib/isn/EAN13.h:26:20: warning: 'EAN13_ran

pgsql: doc PG relnotes: remove warning about commit links in PDF build

doc PG relnotes: remove warning about commit links in PDF build Make paragraph empty instead of removing it. Discussion: https://postgr.es/m/2029579.1726779...@sss.pgh.pa.us Backpatch-through: 12 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/658fc6c6af4fa209af6

pgsql: doc PG relnotes: remove warning about commit links in PDF build

doc PG relnotes: remove warning about commit links in PDF build Make paragraph empty instead of removing it. Discussion: https://postgr.es/m/2029579.1726779...@sss.pgh.pa.us Backpatch-through: 12 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6aed7c49ce17

pgsql: doc PG relnotes: remove warning about commit links in PDF build

doc PG relnotes: remove warning about commit links in PDF build Make paragraph empty instead of removing it. Discussion: https://postgr.es/m/2029579.1726779...@sss.pgh.pa.us Backpatch-through: 12 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/785c53d91d85

pgsql: doc PG relnotes: remove warning about commit links in PDF build

doc PG relnotes: remove warning about commit links in PDF build Make paragraph empty instead of removing it. Discussion: https://postgr.es/m/2029579.1726779...@sss.pgh.pa.us Backpatch-through: 12 Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5a56bd4ed0f9

pgsql: doc PG relnotes: remove warning about commit links in PDF build

doc PG relnotes: remove warning about commit links in PDF build Make paragraph empty instead of removing it. Discussion: https://postgr.es/m/2029579.1726779...@sss.pgh.pa.us Backpatch-through: 12 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/92a6cc5acbe0

pgsql: doc PG relnotes: remove warning about commit links in PDF build

doc PG relnotes: remove warning about commit links in PDF build Make paragraph empty instead of removing it. Discussion: https://postgr.es/m/2029579.1726779...@sss.pgh.pa.us Backpatch-through: 12 Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a24cd4bf5d0f

pgsql: doc PG relnotes: remove warning about commit links in PDF build

doc PG relnotes: remove warning about commit links in PDF build Make paragraph empty instead of removing it. Discussion: https://postgr.es/m/2029579.1726779...@sss.pgh.pa.us Backpatch-through: 12 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/940bcf80aa76

Re: pgsql: doc PG relnotes: document "Unresolved ID reference found" cause

On Thu, Sep 19, 2024 at 05:37:36PM -0400, Bruce Momjian wrote: > On Thu, Sep 19, 2024 at 04:52:19PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > doc PG relnotes: document "Unresolved ID reference found" cause > > > > I'm really not happy with this. We've sweated blood to get rid > > o

Re: pgsql: doc PG relnotes: document "Unresolved ID reference found" cause

On Thu, Sep 19, 2024 at 04:52:19PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > doc PG relnotes: document "Unresolved ID reference found" cause > > I'm really not happy with this. We've sweated blood to get rid > of all those PDF warnings. Introducing one on a permanent basis > is not ac

Re: pgsql: doc PG relnotes: document "Unresolved ID reference found" cause

Bruce Momjian writes: > doc PG relnotes: document "Unresolved ID reference found" cause I'm really not happy with this. We've sweated blood to get rid of all those PDF warnings. Introducing one on a permanent basis is not acceptable. regards, tom lane

pgsql: doc PG relnotes: document "Unresolved ID reference found" cause

doc PG relnotes: document "Unresolved ID reference found" cause Backpatch-through: 12 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6c5d9b3f53510f710e62f175a822c96617a724db Modified Files -- doc/src/sgml/stylesheet-fo.xsl | 6 +- 1 file cha

pgsql: doc PG relnotes: document "Unresolved ID reference found" cause

doc PG relnotes: document "Unresolved ID reference found" cause Backpatch-through: 12 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/468501b17a3a371ee9337ab8965568e6f76770fb Modified Files -- doc/src/sgml/stylesheet-fo.xsl | 6 +- 1 file cha

pgsql: doc PG relnotes: document "Unresolved ID reference found" cause

doc PG relnotes: document "Unresolved ID reference found" cause Backpatch-through: 12 Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ff25193e5623bf458bc19fc71f25f7ce02ffccef Modified Files -- doc/src/sgml/stylesheet-fo.xsl | 6 +- 1 file cha

pgsql: doc PG relnotes: document "Unresolved ID reference found" cause

doc PG relnotes: document "Unresolved ID reference found" cause Backpatch-through: 12 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a7d2ec87a0e4a534df6dd3a2913a1a43847de1c7 Modified Files -- doc/src/sgml/stylesheet-fo.xsl | 6 +- 1 file cha

pgsql: doc PG relnotes: document "Unresolved ID reference found" cause

doc PG relnotes: document "Unresolved ID reference found" cause Backpatch-through: 12 Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/80c8184dc30b3667147f4dc03001ad9138a12248 Modified Files -- doc/src/sgml/stylesheet-fo.xsl | 6 +- 1 file cha

pgsql: doc PG relnotes: document "Unresolved ID reference found" cause

doc PG relnotes: document "Unresolved ID reference found" cause Backpatch-through: 12 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a979f2894c3d436b17a9de2655e4237de1c7df20 Modified Files -- doc/src/sgml/stylesheet-fo.xsl | 6 +- 1 file cha

pgsql: doc PG relnotes: document "Unresolved ID reference found" cause

doc PG relnotes: document "Unresolved ID reference found" cause Backpatch-through: 12 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c6b1506f71324d0bacfab17c6688e8fc2a79b1dc Modified Files -- doc/src/sgml/stylesheet-fo.xsl | 6 +- 1 file changed, 5

pgsql: doc PG relnotes: rename commit link paragraph for clarity

doc PG relnotes: rename commit link paragraph for clarity FYI, during PDF builds, this link type generates a "Unresolved ID reference found" warning because it is suppressed from the PDF output. Backpatch-through: 12 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: doc PG relnotes: rename commit link paragraph for clarity

doc PG relnotes: rename commit link paragraph for clarity FYI, during PDF builds, this link type generates a "Unresolved ID reference found" warning because it is suppressed from the PDF output. Backpatch-through: 12 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/com

pgsql: doc PG relnotes: rename commit link paragraph for clarity

doc PG relnotes: rename commit link paragraph for clarity FYI, during PDF builds, this link type generates a "Unresolved ID reference found" warning because it is suppressed from the PDF output. Backpatch-through: 12 Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/com

pgsql: doc PG relnotes: rename commit link paragraph for clarity

doc PG relnotes: rename commit link paragraph for clarity FYI, during PDF builds, this link type generates a "Unresolved ID reference found" warning because it is suppressed from the PDF output. Backpatch-through: 12 Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/com

pgsql: doc PG relnotes: rename commit link paragraph for clarity

doc PG relnotes: rename commit link paragraph for clarity FYI, during PDF builds, this link type generates a "Unresolved ID reference found" warning because it is suppressed from the PDF output. Backpatch-through: 12 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/com

pgsql: doc PG relnotes: rename commit link paragraph for clarity

doc PG relnotes: rename commit link paragraph for clarity FYI, during PDF builds, this link type generates a "Unresolved ID reference found" warning because it is suppressed from the PDF output. Backpatch-through: 12 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/com

pgsql: doc PG relnotes: rename commit link paragraph for clarity

doc PG relnotes: rename commit link paragraph for clarity FYI, during PDF builds, this link type generates a "Unresolved ID reference found" warning because it is suppressed from the PDF output. Backpatch-through: 12 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/com

Re: pgsql: Implement pg_wal_replay_wait() stored procedure

On Tue, Sep 3, 2024 at 4:07 PM Alexander Korotkov wrote: > On the other hand, I see that returning status could make sense for > certain use cases. I think I could write two patches to provide that. > 1. Make WaitForLSNReplay() return status, and make pg_wal_replay_wal() > be responsible for thro

pgsql: Improve Perl script which adds commit links to release notes

Improve Perl script which adds commit links to release notes Reported-by: Andrew Dunstan Discussion: https://postgr.es/m/b2465837-56df-4794-a0b5-5e6ed44ed...@dunslane.net Author: Andrew Dunstan Backpatch-through: 12 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/co

pgsql: Improve Perl script which adds commit links to release notes

Improve Perl script which adds commit links to release notes Reported-by: Andrew Dunstan Discussion: https://postgr.es/m/b2465837-56df-4794-a0b5-5e6ed44ed...@dunslane.net Author: Andrew Dunstan Backpatch-through: 12 Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/co

pgsql: Improve Perl script which adds commit links to release notes

Improve Perl script which adds commit links to release notes Reported-by: Andrew Dunstan Discussion: https://postgr.es/m/b2465837-56df-4794-a0b5-5e6ed44ed...@dunslane.net Author: Andrew Dunstan Backpatch-through: 12 Branch -- master Details --- https://git.postgresql.org/pg/commitdif

pgsql: Improve Perl script which adds commit links to release notes

Improve Perl script which adds commit links to release notes Reported-by: Andrew Dunstan Discussion: https://postgr.es/m/b2465837-56df-4794-a0b5-5e6ed44ed...@dunslane.net Author: Andrew Dunstan Backpatch-through: 12 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/co

pgsql: Improve Perl script which adds commit links to release notes

Improve Perl script which adds commit links to release notes Reported-by: Andrew Dunstan Discussion: https://postgr.es/m/b2465837-56df-4794-a0b5-5e6ed44ed...@dunslane.net Author: Andrew Dunstan Backpatch-through: 12 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/co

pgsql: Improve Perl script which adds commit links to release notes

Improve Perl script which adds commit links to release notes Reported-by: Andrew Dunstan Discussion: https://postgr.es/m/b2465837-56df-4794-a0b5-5e6ed44ed...@dunslane.net Author: Andrew Dunstan Backpatch-through: 12 Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/co

pgsql: Improve Perl script which adds commit links to release notes

Improve Perl script which adds commit links to release notes Reported-by: Andrew Dunstan Discussion: https://postgr.es/m/b2465837-56df-4794-a0b5-5e6ed44ed...@dunslane.net Author: Andrew Dunstan Backpatch-through: 12 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/co

Re: pgsql: scripts: add Perl script to add links to release notes

On Tue, Sep 17, 2024 at 09:47:57AM -0400, Andrew Dunstan wrote: > > On 2024-09-16 Mo 1:27 PM, Bruce Momjian wrote: > > scripts: add Perl script to add links to release notes > > Reported-by: jian he > > Discussion: https://postgr.es/m/zuyss5xda7hvc...@momjian.us > > > I realize I

pgsql: Add UpgradeTaskProcessCB to typedefs.list

Add UpgradeTaskProcessCB to typedefs.list While it doesn't directly influence indentation right now, add it for uniformity. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4c57facbb16ec5f7002f0b87427897f6f9fa49ae Modified Files -- src/tools/pgindent/typ

pgsql: Fix order of includes in src/bin/pg_upgrade/info.c

Fix order of includes in src/bin/pg_upgrade/info.c Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a094e8b9e43e350798ea0c95b8967b8caf64bcbd Modified Files -- src/bin/pg_upgrade/info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Move pg_wal_replay_wait() to xlogfuncs.c

Move pg_wal_replay_wait() to xlogfuncs.c This commit moves pg_wal_replay_wait() procedure to be a neighbor of WAL-related functions in xlogfuncs.c. The implementation of LSN waiting continues to reside in the same place. By proposal from Michael Paquier. Reported-by: Peter Eisentraut Discussion

pgsql: psql: Fix memory leak with repeated calls of \bind

psql: Fix memory leak with repeated calls of \bind Calling \bind repeatedly would cause the memory allocated for the list of bind parameters to be leaked after each call, as the list is reset when beginning a single call. This issue is fixed by making the cleanup of the bind parameter list more a

pgsql: psql: Fix memory leak with repeated calls of \bind

psql: Fix memory leak with repeated calls of \bind Calling \bind repeatedly would cause the memory allocated for the list of bind parameters to be leaked after each call, as the list is reset when beginning a single call. This issue is fixed by making the cleanup of the bind parameter list more a