pgsql: psql: Remove PARTITION BY clause in tab completion for unlogged

2025-06-10 Thread Michael Paquier
psql: Remove PARTITION BY clause in tab completion for unlogged tables CREATE UNLOGGED TABLE was still being recommended by psql's tab completion as a possible pattern, but the backend is rejecting this option since e2bab2d79204. Reported-by: Shinya Kato Reviewed-by: Nathan Bossart Reviewed-by:

pgsql: Don't reduce output request size on non-Unix-socket connections.

2025-06-10 Thread Tom Lane
Don't reduce output request size on non-Unix-socket connections. Traditionally, libpq's pqPutMsgEnd has rounded down the amount-to-send to be a multiple of 8K when it is eagerly writing some data. This still seems like a good idea when sending through a Unix socket, as pipes typically have a buff

pgsql: Don't reduce output request size on non-Unix-socket connections.

2025-06-10 Thread Tom Lane
Don't reduce output request size on non-Unix-socket connections. Traditionally, libpq's pqPutMsgEnd has rounded down the amount-to-send to be a multiple of 8K when it is eagerly writing some data. This still seems like a good idea when sending through a Unix socket, as pipes typically have a buff

pgsql: Don't reduce output request size on non-Unix-socket connections.

2025-06-10 Thread Tom Lane
Don't reduce output request size on non-Unix-socket connections. Traditionally, libpq's pqPutMsgEnd has rounded down the amount-to-send to be a multiple of 8K when it is eagerly writing some data. This still seems like a good idea when sending through a Unix socket, as pipes typically have a buff

pgsql: Don't reduce output request size on non-Unix-socket connections.

2025-06-10 Thread Tom Lane
Don't reduce output request size on non-Unix-socket connections. Traditionally, libpq's pqPutMsgEnd has rounded down the amount-to-send to be a multiple of 8K when it is eagerly writing some data. This still seems like a good idea when sending through a Unix socket, as pipes typically have a buff

pgsql: Don't reduce output request size on non-Unix-socket connections.

2025-06-10 Thread Tom Lane
Don't reduce output request size on non-Unix-socket connections. Traditionally, libpq's pqPutMsgEnd has rounded down the amount-to-send to be a multiple of 8K when it is eagerly writing some data. This still seems like a good idea when sending through a Unix socket, as pipes typically have a buff

pgsql: Don't reduce output request size on non-Unix-socket connections.

2025-06-10 Thread Tom Lane
Don't reduce output request size on non-Unix-socket connections. Traditionally, libpq's pqPutMsgEnd has rounded down the amount-to-send to be a multiple of 8K when it is eagerly writing some data. This still seems like a good idea when sending through a Unix socket, as pipes typically have a buff

Re: pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower().

2025-06-10 Thread Heikki Linnakangas
On 10 June 2025 13:31:50 GMT-07:00, Tom Lane wrote: >Jeff Davis writes: >> On Tue, 2025-06-10 at 18:24 +, Jeff Davis wrote: >>> inet_net_pton.c: use pg_ascii_tolower() rather than tolower(). > >> These 4 small patches were somewhat of a "false start" on 19 -- sorry >> about that. Not sure

Re: pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower().

2025-06-10 Thread Tom Lane
Jeff Davis writes: > On Tue, 2025-06-10 at 18:24 +, Jeff Davis wrote: >> inet_net_pton.c: use pg_ascii_tolower() rather than tolower(). > These 4 small patches were somewhat of a "false start" on 19 -- sorry > about that. Not sure if it's worth it to revert them and reapply in a > couple week

Re: pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower().

2025-06-10 Thread Jeff Davis
On Tue, 2025-06-10 at 18:24 +, Jeff Davis wrote: > inet_net_pton.c: use pg_ascii_tolower() rather than tolower(). These 4 small patches were somewhat of a "false start" on 19 -- sorry about that. Not sure if it's worth it to revert them and reapply in a couple weeks, as they look pretty harmle

pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower().

2025-06-10 Thread Jeff Davis
copyfromparse.c: use pg_ascii_tolower() rather than tolower(). Avoid dependence on setlocale(). No behavior change. Discussion: https://postgr.es/m/9875f7f9-50f1-4b5d-86fc-ee8b03e8c...@eisentraut.org Reviewed-by: Peter Eisentraut Branch -- master Details --- https://git.postgresql.org

pgsql: isn.c: use pg_ascii_toupper() instead of toupper().

2025-06-10 Thread Jeff Davis
isn.c: use pg_ascii_toupper() instead of toupper(). Avoid dependence on setlocale(). No behavior change. Discussion: https://postgr.es/m/9875f7f9-50f1-4b5d-86fc-ee8b03e8c...@eisentraut.org Reviewed-by: Peter Eisentraut Branch -- master Details --- https://git.postgresql.org/pg/commitd

pgsql: contrib/spi/refint.c: use pg_ascii_tolower() instead.

2025-06-10 Thread Jeff Davis
contrib/spi/refint.c: use pg_ascii_tolower() instead. Avoid dependence on setlocale(). No behavior change. Discussion: https://postgr.es/m/9875f7f9-50f1-4b5d-86fc-ee8b03e8c...@eisentraut.org Reviewed-by: Peter Eisentraut Branch -- master Details --- https://git.postgresql.org/pg/commi

pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower().

2025-06-10 Thread Jeff Davis
inet_net_pton.c: use pg_ascii_tolower() rather than tolower(). Avoid dependence on setlocale(). No behavior change. Discussion: https://postgr.es/m/9875f7f9-50f1-4b5d-86fc-ee8b03e8c...@eisentraut.org Reviewed-by: Peter Eisentraut Branch -- master Details --- https://git.postgresql.org