pgsql: Correct list of files in src/backend/lib/README

2025-06-26 Thread Michael Paquier
Correct list of files in src/backend/lib/README binaryheap.c and stringinfo.c have been moved to src/common/ by respectively 5af0263afd7b and 26aaf97b683d, and the README patched here still mentioned these two files as available in src/backend/lib/. Author: Aleksander Alekseev Discussion: https

pgsql: libpq: Message style improvements

2025-06-26 Thread Peter Eisentraut
libpq: Message style improvements Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7fb3c38e7d7d12a742e1e7600879570251e1886a Modified Files -- src/interfaces/libpq/fe-connect.c| 2 +- src/interfaces/libpq/fe-protocol3.c | 7 --- src/interfac

pgsql: Correct misleading error messages

2025-06-26 Thread Peter Eisentraut
Correct misleading error messages Commit 7d6d2c4bbd7 dropped opcintype from the index AM strategy translation API. But some error messages about failed lookups still mentioned it, even though it was not used for the lookup. Fix by removing ipcintype from the error messages as well. Branch -

pgsql: Remove unused check in heap_xlog_insert()

2025-06-26 Thread Melanie Plageman
Remove unused check in heap_xlog_insert() 8e03eb92e9a reverted the commit 39b66a91bd which allowed freezing in the heap_insert() code path but forgot to remove the corresponding check in heap_xlog_insert(). This code is extraneous but not harmful. However, cleaning it up makes it very clear that,

pgsql: Remove unused check in heap_xlog_insert()

2025-06-26 Thread Melanie Plageman
Remove unused check in heap_xlog_insert() 8e03eb92e9a reverted the commit 39b66a91bd which allowed freezing in the heap_insert() code path but forgot to remove the corresponding check in heap_xlog_insert(). This code is extraneous but not harmful. However, cleaning it up makes it very clear that,

pgsql: Remove unused check in heap_xlog_insert()

2025-06-26 Thread Melanie Plageman
Remove unused check in heap_xlog_insert() 8e03eb92e9a reverted the commit 39b66a91bd which allowed freezing in the heap_insert() code path but forgot to remove the corresponding check in heap_xlog_insert(). This code is extraneous but not harmful. However, cleaning it up makes it very clear that,

pgsql: Remove unused check in heap_xlog_insert()

2025-06-26 Thread Melanie Plageman
Remove unused check in heap_xlog_insert() 8e03eb92e9a reverted the commit 39b66a91bd which allowed freezing in the heap_insert() code path but forgot to remove the corresponding check in heap_xlog_insert(). This code is extraneous but not harmful. However, cleaning it up makes it very clear that,

pgsql: Remove unused check in heap_xlog_insert()

2025-06-26 Thread Melanie Plageman
Remove unused check in heap_xlog_insert() 8e03eb92e9a reverted the commit 39b66a91bd which allowed freezing in the heap_insert() code path but forgot to remove the corresponding check in heap_xlog_insert(). This code is extraneous but not harmful. However, cleaning it up makes it very clear that,

pgsql: Simplify vacuum VM update logging counters

2025-06-26 Thread Melanie Plageman
Simplify vacuum VM update logging counters We can simplify the VM counters added in dc6acfd910b8 to lazy_vacuum_heap_page() and lazy_scan_new_or_empty(). We won't invoke lazy_vacuum_heap_page() unless there are dead line pointers, so we know the page can't be all-visible. In lazy_scan_new_or_emp

pgsql: Fix typo in comment

2025-06-26 Thread Álvaro Herrera
Fix typo in comment Introduced by c2da1a5d6325 Reported-by: Michael Paquier Discussion: https://postgr.es/m/aft4qerwrv-3q...@paquier.xyz Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a3994ec6acb27545300ce1e336e4d119d8000ba9 Modified Files -- contrib

pgsql: pg_dump: include comments on valid not-null constraints, too

2025-06-26 Thread Álvaro Herrera
pg_dump: include comments on valid not-null constraints, too We were missing collecting comments for not-null constraints that are dumped inline with the table definition (i.e., valid ones), because they aren't represented by a separately dumpable object. Fix by creating separate TocEntries for t

pgsql: docs: fix typo

2025-06-26 Thread Álvaro Herrera
docs: fix typo Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/48c80aba7538d7c515d0c89f4d11f88974fee851 Modified Files -- doc/src/sgml/ref/pg_dump.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Make CREATE TABLE LIKE copy comments on NOT NULL constraints whe

2025-06-26 Thread Fujii Masao
Make CREATE TABLE LIKE copy comments on NOT NULL constraints when requested. Commit 14e87ffa5c5 introduced support for adding comments to NOT NULL constraints. However, CREATE TABLE LIKE INCLUDING COMMENTS did not copy these comments to the new table. This was an oversight in that commit. This co

pgsql: doc: Updates for RETURNING OLD/NEW.

2025-06-26 Thread Dean Rasheed
doc: Updates for RETURNING OLD/NEW. Fix a couple of sentences in the documentation that were missed in commit 80feb727c8. Author: Dean Rasheed Reviewed-by: Robert Treat Discussion: https://postgr.es/m/caezatcucqadjuapzsjpf2b6hfj6agouwefrvh8ht3uzoqqw...@mail.gmail.com Branch -- master Det

pgsql: doc: Fix indentation of MERGE synopsis.

2025-06-26 Thread Dean Rasheed
doc: Fix indentation of MERGE synopsis. The convention in the documentation for other SQL commands is to indent continuation lines and sub-clauses in the "Synopsis" section by 4 spaces, so do the same for MERGE. Author: Dean Rasheed Reviewed-by: Nathan Bossart Discussion: https://postgr.es/m/c

pgsql: doc: Fix indentation of MERGE synopsis.

2025-06-26 Thread Dean Rasheed
doc: Fix indentation of MERGE synopsis. The convention in the documentation for other SQL commands is to indent continuation lines and sub-clauses in the "Synopsis" section by 4 spaces, so do the same for MERGE. Author: Dean Rasheed Reviewed-by: Nathan Bossart Discussion: https://postgr.es/m/c

pgsql: doc: Fix indentation of MERGE synopsis.

2025-06-26 Thread Dean Rasheed
doc: Fix indentation of MERGE synopsis. The convention in the documentation for other SQL commands is to indent continuation lines and sub-clauses in the "Synopsis" section by 4 spaces, so do the same for MERGE. Author: Dean Rasheed Reviewed-by: Nathan Bossart Discussion: https://postgr.es/m/c

pgsql: doc: Fix indentation of MERGE synopsis.

2025-06-26 Thread Dean Rasheed
doc: Fix indentation of MERGE synopsis. The convention in the documentation for other SQL commands is to indent continuation lines and sub-clauses in the "Synopsis" section by 4 spaces, so do the same for MERGE. Author: Dean Rasheed Reviewed-by: Nathan Bossart Discussion: https://postgr.es/m/c