pgsql: doc: Fix descriptions of some PGC_POSTMASTER parameters.

2025-11-06 Thread Fujii Masao
doc: Fix descriptions of some PGC_POSTMASTER parameters. The following parameters can only be set at server start because their context is PGC_POSTMASTER, but this information was missing or incorrectly documented. This commit adds or corrects that information for the following parameters: * debu

pgsql: doc: Fix descriptions of some PGC_POSTMASTER parameters.

2025-11-06 Thread Fujii Masao
doc: Fix descriptions of some PGC_POSTMASTER parameters. The following parameters can only be set at server start because their context is PGC_POSTMASTER, but this information was missing or incorrectly documented. This commit adds or corrects that information for the following parameters: * debu

pgsql: doc: Fix descriptions of some PGC_POSTMASTER parameters.

2025-11-06 Thread Fujii Masao
doc: Fix descriptions of some PGC_POSTMASTER parameters. The following parameters can only be set at server start because their context is PGC_POSTMASTER, but this information was missing or incorrectly documented. This commit adds or corrects that information for the following parameters: * debu

pgsql: doc: Fix descriptions of some PGC_POSTMASTER parameters.

2025-11-06 Thread Fujii Masao
doc: Fix descriptions of some PGC_POSTMASTER parameters. The following parameters can only be set at server start because their context is PGC_POSTMASTER, but this information was missing or incorrectly documented. This commit adds or corrects that information for the following parameters: * debu

pgsql: doc: Fix descriptions of some PGC_POSTMASTER parameters.

2025-11-06 Thread Fujii Masao
doc: Fix descriptions of some PGC_POSTMASTER parameters. The following parameters can only be set at server start because their context is PGC_POSTMASTER, but this information was missing or incorrectly documented. This commit adds or corrects that information for the following parameters: * debu

pgsql: doc: Fix descriptions of some PGC_POSTMASTER parameters.

2025-11-06 Thread Fujii Masao
doc: Fix descriptions of some PGC_POSTMASTER parameters. The following parameters can only be set at server start because their context is PGC_POSTMASTER, but this information was missing or incorrectly documented. This commit adds or corrects that information for the following parameters: * debu

pgsql: doc: Fix descriptions of some PGC_POSTMASTER parameters.

2025-11-06 Thread Fujii Masao
doc: Fix descriptions of some PGC_POSTMASTER parameters. The following parameters can only be set at server start because their context is PGC_POSTMASTER, but this information was missing or incorrectly documented. This commit adds or corrects that information for the following parameters: * debu

pgsql: doc: Clarify units for io_combine_limit and io_max_combine_limit

2025-11-06 Thread Fujii Masao
doc: Clarify units for io_combine_limit and io_max_combine_limit. If these parameters are set without units, the values are interpreted as blocks. This detail was previously missing from the documentation, so this commit adds it. Backpatch to v17 where io_combine_limit was added. Author: Karina

pgsql: doc: Clarify units for io_combine_limit and io_max_combine_limit

2025-11-06 Thread Fujii Masao
doc: Clarify units for io_combine_limit and io_max_combine_limit. If these parameters are set without units, the values are interpreted as blocks. This detail was previously missing from the documentation, so this commit adds it. Backpatch to v17 where io_combine_limit was added. Author: Karina

pgsql: doc: Clarify units for io_combine_limit and io_max_combine_limit

2025-11-06 Thread Fujii Masao
doc: Clarify units for io_combine_limit and io_max_combine_limit. If these parameters are set without units, the values are interpreted as blocks. This detail was previously missing from the documentation, so this commit adds it. Backpatch to v17 where io_combine_limit was added. Author: Karina

pgsql: bufmgr: Use atomic sub for unpinning buffers

2025-11-06 Thread Andres Freund
bufmgr: Use atomic sub for unpinning buffers The prior commit made it legal to modify BufferDesc.state while the buffer header spinlock is held. This allows us to replace the CAS loop inUnpinBufferNoOwner() with an atomic sub. This improves scalability significantly. See the prior commits for more

pgsql: bufmgr: Allow some buffer state modifications while holding head

2025-11-06 Thread Andres Freund
bufmgr: Allow some buffer state modifications while holding header lock Until now BufferDesc.state was not allowed to be modified while the buffer header spinlock was held. This meant that operations like unpinning buffers needed to use a CAS loop, waiting for the buffer header spinlock to be rele

pgsql: Tidyup WARNING ereports in subscriptioncmds.c

2025-11-06 Thread David Rowley
Tidyup WARNING ereports in subscriptioncmds.c A couple of ereports were making use of StringInfos as temporary storage for the portions of the WARNING message. One was doing this to avoid having 2 separate ereports. This was all fairly unnecessary and resulted in more code rather than less code.

pgsql: Use XLogRecPtrIsValid() in various places

2025-11-06 Thread Álvaro Herrera
Use XLogRecPtrIsValid() in various places Now that commit 06edbed47862 has introduced XLogRecPtrIsValid(), we can use that instead of: - XLogRecPtrIsInvalid() - direct comparisons with InvalidXLogRecPtr - direct comparisons with literal 0 This makes the code more consistent. Author: Bertrand Dr

pgsql: Introduce XLogRecPtrIsValid()

2025-11-06 Thread Álvaro Herrera
Introduce XLogRecPtrIsValid() XLogRecPtrIsInvalid() is inconsistent with the affirmative form of macros used for other datatypes, and leads to awkward double negatives in a few places. This commit introduces XLogRecPtrIsValid(), which allows code to be written more naturally. This patch only add

pgsql: Introduce XLogRecPtrIsValid()

2025-11-06 Thread Álvaro Herrera
Introduce XLogRecPtrIsValid() XLogRecPtrIsInvalid() is inconsistent with the affirmative form of macros used for other datatypes, and leads to awkward double negatives in a few places. This commit introduces XLogRecPtrIsValid(), which allows code to be written more naturally. This patch only add

pgsql: Introduce XLogRecPtrIsValid()

2025-11-06 Thread Álvaro Herrera
Introduce XLogRecPtrIsValid() XLogRecPtrIsInvalid() is inconsistent with the affirmative form of macros used for other datatypes, and leads to awkward double negatives in a few places. This commit introduces XLogRecPtrIsValid(), which allows code to be written more naturally. This patch only add

pgsql: Introduce XLogRecPtrIsValid()

2025-11-06 Thread Álvaro Herrera
Introduce XLogRecPtrIsValid() XLogRecPtrIsInvalid() is inconsistent with the affirmative form of macros used for other datatypes, and leads to awkward double negatives in a few places. This commit introduces XLogRecPtrIsValid(), which allows code to be written more naturally. This patch only add

pgsql: Introduce XLogRecPtrIsValid()

2025-11-06 Thread Álvaro Herrera
Introduce XLogRecPtrIsValid() XLogRecPtrIsInvalid() is inconsistent with the affirmative form of macros used for other datatypes, and leads to awkward double negatives in a few places. This commit introduces XLogRecPtrIsValid(), which allows code to be written more naturally. This patch only add

pgsql: Introduce XLogRecPtrIsValid()

2025-11-06 Thread Álvaro Herrera
Introduce XLogRecPtrIsValid() XLogRecPtrIsInvalid() is inconsistent with the affirmative form of macros used for other datatypes, and leads to awkward double negatives in a few places. This commit introduces XLogRecPtrIsValid(), which allows code to be written more naturally. This patch only add

pgsql: Introduce XLogRecPtrIsValid()

2025-11-06 Thread Álvaro Herrera
Introduce XLogRecPtrIsValid() XLogRecPtrIsInvalid() is inconsistent with the affirmative form of macros used for other datatypes, and leads to awkward double negatives in a few places. This commit introduces XLogRecPtrIsValid(), which allows code to be written more naturally. This patch only add

pgsql: Refer readers of \? to "\? variables" for pset options

2025-11-06 Thread Álvaro Herrera
Refer readers of \? to "\? variables" for pset options ... and remove the list of \pset options from the general \? output. That list was getting out of hand, both for developers to keep up to date as well as for users to read. Author: Álvaro Herrera Reviewed-by: Tom Lane Discussion: https://po

pgsql: Disallow generated columns in COPY WHERE clause

2025-11-06 Thread Peter Eisentraut
Disallow generated columns in COPY WHERE clause Stored generated columns are not yet computed when the filtering happens, so we need to prohibit them to avoid incorrect behavior. Co-authored-by: jian he Reviewed-by: Kirill Reshke Reviewed-by: Masahiko Sawada Discussion: https://www.postgresql

pgsql: Disallow generated columns in COPY WHERE clause

2025-11-06 Thread Peter Eisentraut
Disallow generated columns in COPY WHERE clause Stored generated columns are not yet computed when the filtering happens, so we need to prohibit them to avoid incorrect behavior. Virtual generated columns currently error out ("unexpected virtual generated column reference"). They could probably

pgsql: Disallow generated columns in COPY WHERE clause

2025-11-06 Thread Peter Eisentraut
Disallow generated columns in COPY WHERE clause Stored generated columns are not yet computed when the filtering happens, so we need to prohibit them to avoid incorrect behavior. Co-authored-by: jian he Reviewed-by: Kirill Reshke Reviewed-by: Masahiko Sawada Discussion: https://www.postgresql

pgsql: Disallow generated columns in COPY WHERE clause

2025-11-06 Thread Peter Eisentraut
Disallow generated columns in COPY WHERE clause Stored generated columns are not yet computed when the filtering happens, so we need to prohibit them to avoid incorrect behavior. Co-authored-by: jian he Reviewed-by: Kirill Reshke Reviewed-by: Masahiko Sawada Discussion: https://www.postgresql

pgsql: Disallow generated columns in COPY WHERE clause

2025-11-06 Thread Peter Eisentraut
Disallow generated columns in COPY WHERE clause Stored generated columns are not yet computed when the filtering happens, so we need to prohibit them to avoid incorrect behavior. Co-authored-by: jian he Reviewed-by: Kirill Reshke Reviewed-by: Masahiko Sawada Discussion: https://www.postgresql

pgsql: Disallow generated columns in COPY WHERE clause

2025-11-06 Thread Peter Eisentraut
Disallow generated columns in COPY WHERE clause Stored generated columns are not yet computed when the filtering happens, so we need to prohibit them to avoid incorrect behavior. Co-authored-by: jian he Reviewed-by: Kirill Reshke Reviewed-by: Masahiko Sawada Discussion: https://www.postgresql

pgsql: Disallow generated columns in COPY WHERE clause

2025-11-06 Thread Peter Eisentraut
Disallow generated columns in COPY WHERE clause Stored generated columns are not yet computed when the filtering happens, so we need to prohibit them to avoid incorrect behavior. Virtual generated columns currently error out ("unexpected virtual generated column reference"). They could probably

Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing

2025-11-06 Thread Álvaro Herrera
On 2025-Nov-06, Peter Eisentraut wrote: > On 04.11.25 11:40, Peter Eisentraut wrote: > > Maybe that message has one "subscriber" too many? > > I have fixed this. Thanks. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "I can see support will not be a problem.

pgsql: Refactor shared memory allocation for semaphores

2025-11-06 Thread Heikki Linnakangas
Refactor shared memory allocation for semaphores Before commit e25626677f, spinlocks were implemented using semaphores on some platforms (--disable-spinlocks). That made it necessary to initialize semaphores early, before any spinlocks could be used. Now that we don't support --disable-spinlocks a

pgsql: Add comment to explain why PGReserveSemaphores() is called early

2025-11-06 Thread Heikki Linnakangas
Add comment to explain why PGReserveSemaphores() is called early Before commit e25626677f, PGReserveSemaphores() had to be called before SpinlockSemaInit() because spinlocks were implemented using semaphores on some platforms (--disable-spinlocks). Add a comment explaining that. Author: Ashutosh

pgsql: Add comment to explain why PGReserveSemaphores() is called early

2025-11-06 Thread Heikki Linnakangas
Add comment to explain why PGReserveSemaphores() is called early Before commit e25626677f, PGReserveSemaphores() had to be called before SpinlockSemaInit() because spinlocks were implemented using semaphores on some platforms (--disable-spinlocks). Add a comment explaining that. Author: Ashutosh

pgsql: Fix redundancy in error message

2025-11-06 Thread Peter Eisentraut
Fix redundancy in error message Discussion: https://www.postgresql.org/message-id/flat/E1vEsbx-004QDO-0o%40gemulon.postgresql.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/150e24501bc218057a7b9a24b19a145fa8b5c678 Modified Files -- src/bin/pg_base

pgsql: Fix redundancy in error message

2025-11-06 Thread Peter Eisentraut
Fix redundancy in error message Discussion: https://www.postgresql.org/message-id/flat/E1vEsbx-004QDO-0o%40gemulon.postgresql.org Branch -- REL_18_STABLE Details --- https://git.postgresql.org/pg/commitdiff/83122538f2f0354970cd5209a90abc677f32384e Modified Files -- src/bin/

pgsql: Fix redundancy in error message

2025-11-06 Thread Peter Eisentraut
Fix redundancy in error message Discussion: https://www.postgresql.org/message-id/flat/E1vEsbx-004QDO-0o%40gemulon.postgresql.org Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/726e77d7a94fd6d6ad99e439351ae6d4a48d3441 Modified Files -- src/bin/

Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing

2025-11-06 Thread Peter Eisentraut
On 04.11.25 11:40, Peter Eisentraut wrote: On 31.10.25 18:08, Álvaro Herrera wrote: pg_createsubscriber: Fix error complaining about the wrong thing The code updates the system identifier, then runs pg_walreset; if the latter fails, it complains about the former, which makes no sense. Change th

pgsql: Cosmetic fixes in GiST README

2025-11-06 Thread John Naylor
Cosmetic fixes in GiST README Fix a typo, add some missing conjunctions, and make a sentence flow more smoothly. Author: Paul A. Jungwirth Discussion: https://postgr.es/m/CA%2BrenyXZgwzegmO5t%3DUSU%3D9Wo5bc-YqNf-6E7Nv7e577DCmYXA%40mail.gmail.com Branch -- master Details --- https://gi

pgsql: Fix few issues in commit 5509055d69.

2025-11-06 Thread Amit Kapila
Fix few issues in commit 5509055d69. Test failure on buildfarm member prion: The test failed due to an unexpected LOCATION: line appearing between the WARNING and ERROR messages. This occurred because the prion machine uses log_error_verbosity = verbose, which includes additional context in error

pgsql: ci: Improve OpenBSD core dump backtrace handling.

2025-11-06 Thread Thomas Munro
ci: Improve OpenBSD core dump backtrace handling. Since OpenBSD core dumps do not embed executable paths, the script now searches for the corresponding binary manually within the specified directory before invoking LLDB. This is imperfect but should find the right executable in practice, as neede

pgsql: ci: Improve OpenBSD core dump backtrace handling.

2025-11-06 Thread Thomas Munro
ci: Improve OpenBSD core dump backtrace handling. Since OpenBSD core dumps do not embed executable paths, the script now searches for the corresponding binary manually within the specified directory before invoking LLDB. This is imperfect but should find the right executable in practice, as neede