pgsql: Update obsolete comments in ResultRelInfo struct.

2025-08-17 Thread Etsuro Fujita
route tuples into), but failed to update these comments. Author: Etsuro Fujita Reviewed-by: Dean Rasheed Discussion: https://postgr.es/m/CAPmGK14NF5CcdCmTZpxrvpvBiT0y4EqKikW1r_wAu1CEHeOmUA%40mail.gmail.com Backpatch-through: 14 Branch -- REL_18_STABLE Details --- https://git.postgresql.org

pgsql: Update obsolete comments in ResultRelInfo struct.

2025-08-17 Thread Etsuro Fujita
route tuples into), but failed to update these comments. Author: Etsuro Fujita Reviewed-by: Dean Rasheed Discussion: https://postgr.es/m/CAPmGK14NF5CcdCmTZpxrvpvBiT0y4EqKikW1r_wAu1CEHeOmUA%40mail.gmail.com Backpatch-through: 14 Branch -- master Details --- https://git.postgresql.org/pg

pgsql: Update obsolete comments in ResultRelInfo struct.

2025-08-17 Thread Etsuro Fujita
route tuples into), but failed to update these comments. Author: Etsuro Fujita Reviewed-by: Dean Rasheed Discussion: https://postgr.es/m/CAPmGK14NF5CcdCmTZpxrvpvBiT0y4EqKikW1r_wAu1CEHeOmUA%40mail.gmail.com Backpatch-through: 14 Branch -- REL_16_STABLE Details --- https://git.postgresql.org

pgsql: Update obsolete comments in ResultRelInfo struct.

2025-08-17 Thread Etsuro Fujita
route tuples into), but failed to update these comments. Author: Etsuro Fujita Reviewed-by: Dean Rasheed Discussion: https://postgr.es/m/CAPmGK14NF5CcdCmTZpxrvpvBiT0y4EqKikW1r_wAu1CEHeOmUA%40mail.gmail.com Backpatch-through: 14 Branch -- REL_14_STABLE Details --- https://git.postgresql.org

pgsql: Update obsolete comments in ResultRelInfo struct.

2025-08-17 Thread Etsuro Fujita
route tuples into), but failed to update these comments. Author: Etsuro Fujita Reviewed-by: Dean Rasheed Discussion: https://postgr.es/m/CAPmGK14NF5CcdCmTZpxrvpvBiT0y4EqKikW1r_wAu1CEHeOmUA%40mail.gmail.com Backpatch-through: 14 Branch -- REL_17_STABLE Details --- https://git.postgresql.org

pgsql: Update obsolete comments in ResultRelInfo struct.

2025-08-17 Thread Etsuro Fujita
route tuples into), but failed to update these comments. Author: Etsuro Fujita Reviewed-by: Dean Rasheed Discussion: https://postgr.es/m/CAPmGK14NF5CcdCmTZpxrvpvBiT0y4EqKikW1r_wAu1CEHeOmUA%40mail.gmail.com Backpatch-through: 14 Branch -- REL_15_STABLE Details --- https://git.postgresql.org

pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance.

2025-08-08 Thread Etsuro Fujita
table, but failed to check if a found trigger is row-level, causing the caller functions to needlessly prevent a table with only a statement-level trigger with transition tables from becoming a partition or inheritance child. Repair. Oversight in commit 501ed02cf. Author: Etsuro Fujita Discussion

pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance.

2025-08-08 Thread Etsuro Fujita
table, but failed to check if a found trigger is row-level, causing the caller functions to needlessly prevent a table with only a statement-level trigger with transition tables from becoming a partition or inheritance child. Repair. Oversight in commit 501ed02cf. Author: Etsuro Fujita Discussion

pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance.

2025-08-08 Thread Etsuro Fujita
table, but failed to check if a found trigger is row-level, causing the caller functions to needlessly prevent a table with only a statement-level trigger with transition tables from becoming a partition or inheritance child. Repair. Oversight in commit 501ed02cf. Author: Etsuro Fujita Discussion

pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance.

2025-08-08 Thread Etsuro Fujita
table, but failed to check if a found trigger is row-level, causing the caller functions to needlessly prevent a table with only a statement-level trigger with transition tables from becoming a partition or inheritance child. Repair. Oversight in commit 501ed02cf. Author: Etsuro Fujita Discussion

pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance.

2025-08-08 Thread Etsuro Fujita
table, but failed to check if a found trigger is row-level, causing the caller functions to needlessly prevent a table with only a statement-level trigger with transition tables from becoming a partition or inheritance child. Repair. Oversight in commit 501ed02cf. Author: Etsuro Fujita Discussion

pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance.

2025-08-08 Thread Etsuro Fujita
table, but failed to check if a found trigger is row-level, causing the caller functions to needlessly prevent a table with only a statement-level trigger with transition tables from becoming a partition or inheritance child. Repair. Oversight in commit 501ed02cf. Author: Etsuro Fujita Discussion

pgsql: Fix oversight in FindTriggerIncompatibleWithInheritance.

2025-08-08 Thread Etsuro Fujita
table, but failed to check if a found trigger is row-level, causing the caller functions to needlessly prevent a table with only a statement-level trigger with transition tables from becoming a partition or inheritance child. Repair. Oversight in commit 501ed02cf. Author: Etsuro Fujita Discussion

pgsql: Disallow collecting transition tuples from child foreign tables.

2025-08-07 Thread Etsuro Fujita
ables, not DirectModify; which is needed because they would otherwise skip the calls to ExecAR*Triggers at execution, causing unexpected behavior. Author: Etsuro Fujita Reviewed-by: Amit Langote Discussion: https://postgr.es/m/CAPmGK14QJYikKzBDCe3jMbpGENnQ7popFmbEgm-XTNuk55oyHg%40mail.gmail.com Back

pgsql: Disallow collecting transition tuples from child foreign tables.

2025-08-07 Thread Etsuro Fujita
ables, not DirectModify; which is needed because they would otherwise skip the calls to ExecAR*Triggers at execution, causing unexpected behavior. Author: Etsuro Fujita Reviewed-by: Amit Langote Discussion: https://postgr.es/m/CAPmGK14QJYikKzBDCe3jMbpGENnQ7popFmbEgm-XTNuk55oyHg%40mail.gmail.com Back

pgsql: Disallow collecting transition tuples from child foreign tables.

2025-08-07 Thread Etsuro Fujita
ables, not DirectModify; which is needed because they would otherwise skip the calls to ExecAR*Triggers at execution, causing unexpected behavior. Author: Etsuro Fujita Reviewed-by: Amit Langote Discussion: https://postgr.es/m/CAPmGK14QJYikKzBDCe3jMbpGENnQ7popFmbEgm-XTNuk55oyHg%40mail.gmail.com Back

pgsql: Disallow collecting transition tuples from child foreign tables.

2025-08-07 Thread Etsuro Fujita
ables, not DirectModify; which is needed because they would otherwise skip the calls to ExecAR*Triggers at execution, causing unexpected behavior. Author: Etsuro Fujita Reviewed-by: Amit Langote Discussion: https://postgr.es/m/CAPmGK14QJYikKzBDCe3jMbpGENnQ7popFmbEgm-XTNuk55oyHg%40mail.gmail.com Back

pgsql: Disallow collecting transition tuples from child foreign tables.

2025-08-07 Thread Etsuro Fujita
ables, not DirectModify; which is needed because they would otherwise skip the calls to ExecAR*Triggers at execution, causing unexpected behavior. Author: Etsuro Fujita Reviewed-by: Amit Langote Discussion: https://postgr.es/m/CAPmGK14QJYikKzBDCe3jMbpGENnQ7popFmbEgm-XTNuk55oyHg%40mail.gmail.com Back

pgsql: Disallow collecting transition tuples from child foreign tables.

2025-08-07 Thread Etsuro Fujita
ables, not DirectModify; which is needed because they would otherwise skip the calls to ExecAR*Triggers at execution, causing unexpected behavior. Author: Etsuro Fujita Reviewed-by: Amit Langote Discussion: https://postgr.es/m/CAPmGK14QJYikKzBDCe3jMbpGENnQ7popFmbEgm-XTNuk55oyHg%40mail.gmail.com Back

pgsql: Disallow collecting transition tuples from child foreign tables.

2025-08-07 Thread Etsuro Fujita
ables, not DirectModify; which is needed because they would otherwise skip the calls to ExecAR*Triggers at execution, causing unexpected behavior. Author: Etsuro Fujita Reviewed-by: Amit Langote Discussion: https://postgr.es/m/CAPmGK14QJYikKzBDCe3jMbpGENnQ7popFmbEgm-XTNuk55oyHg%40mail.gmail.com Back

pgsql: Doc: clarify the restrictions of AFTER triggers with transition

2025-08-02 Thread Etsuro Fujita
Doc: clarify the restrictions of AFTER triggers with transition tables. It was not very clear that the triggers are only allowed on plain tables (not foreign tables). Also, rephrase the documentation for better readability. Follow up to commit 9e6104c66. Reported-by: Etsuro Fujita Author

pgsql: Doc: clarify the restrictions of AFTER triggers with transition

2025-08-02 Thread Etsuro Fujita
Doc: clarify the restrictions of AFTER triggers with transition tables. It was not very clear that the triggers are only allowed on plain tables (not foreign tables). Also, rephrase the documentation for better readability. Follow up to commit 9e6104c66. Reported-by: Etsuro Fujita Author

pgsql: Doc: clarify the restrictions of AFTER triggers with transition

2025-08-02 Thread Etsuro Fujita
Doc: clarify the restrictions of AFTER triggers with transition tables. It was not very clear that the triggers are only allowed on plain tables (not foreign tables). Also, rephrase the documentation for better readability. Follow up to commit 9e6104c66. Reported-by: Etsuro Fujita Author

pgsql: Doc: clarify the restrictions of AFTER triggers with transition

2025-08-02 Thread Etsuro Fujita
Doc: clarify the restrictions of AFTER triggers with transition tables. It was not very clear that the triggers are only allowed on plain tables (not foreign tables). Also, rephrase the documentation for better readability. Follow up to commit 9e6104c66. Reported-by: Etsuro Fujita Author

pgsql: Doc: clarify the restrictions of AFTER triggers with transition

2025-08-02 Thread Etsuro Fujita
Doc: clarify the restrictions of AFTER triggers with transition tables. It was not very clear that the triggers are only allowed on plain tables (not foreign tables). Also, rephrase the documentation for better readability. Follow up to commit 9e6104c66. Reported-by: Etsuro Fujita Author

pgsql: Doc: clarify the restrictions of AFTER triggers with transition

2025-08-02 Thread Etsuro Fujita
Doc: clarify the restrictions of AFTER triggers with transition tables. It was not very clear that the triggers are only allowed on plain tables (not foreign tables). Also, rephrase the documentation for better readability. Follow up to commit 9e6104c66. Reported-by: Etsuro Fujita Author

pgsql: Doc: clarify the restrictions of AFTER triggers with transition

2025-08-02 Thread Etsuro Fujita
Doc: clarify the restrictions of AFTER triggers with transition tables. It was not very clear that the triggers are only allowed on plain tables (not foreign tables). Also, rephrase the documentation for better readability. Follow up to commit 9e6104c66. Reported-by: Etsuro Fujita Author

pgsql: postgres_fdw: Add Assert to estimate_path_cost_size().

2025-07-06 Thread Etsuro Fujita
is guaranteed to be non-NULL in that case; to avoid confusion, add an Assert to ensure that it is not NULL before dereferencing it. Reported-by: Ranier Vilela Author: Etsuro Fujita Reviewed-by: Ranier Vilela Discussion: https://postgr.es/m/CAEudQArgiALbV1akQpeZOgim7XP05n%3DbDP1%3DTcOYLA43nRX_vA

pgsql: Revert "postgres_fdw: Inherit the local transaction's access/def

2025-06-08 Thread Etsuro Fujita
Revert "postgres_fdw: Inherit the local transaction's access/deferrable modes." We concluded that commit e5a3c9d9b is a feature rather than a fix; since it was added after feature freeze, revert it. Reported-by: Fujii Masao Reported-by: Michael Paquier Reported-by: Robert Haas Discussion: htt

pgsql: postgres_fdw: Inherit the local transaction's access/deferrable

2025-06-01 Thread Etsuro Fujita
on of postgres_fdw, there have been no reports from the field. So it seems fine to just fix them in master only. Author: Etsuro Fujita Reviewed-by: Ashutosh Bapat Reviewed-by: Tom Lane Discussion: https://postgr.es/m/CAPmGK16n_hcUUWuOdmeUS%2Bw4Q6dZvTEDHb%3DOP%3D5JBzo-M3QmpQ%40mail.gmail.com B

pgsql: Fix typos in comments.

2025-05-03 Thread Etsuro Fujita
Fix typos in comments. Also adjust the phrasing in the comments. Author: Etsuro Fujita Author: Heikki Linnakangas Reviewed-by: Tender Wang Reviewed-by: Gurjeet Singh Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CAPmGK17%3DPHSDZ%2B0G6jcj12buyyE1bQQc3sbp1Wxri7tODT-SDw

pgsql: Fix memory allocation/copy mistakes.

2025-05-03 Thread Etsuro Fujita
have been no reports from the field. So for now, it seems sufficient to fix them in master. Author: Etsuro Fujita Reviewed-by: Heikki Linnakangas Reviewed-by: Gurjeet Singh Discussion: https://postgr.es/m/CAPmGK15eTRCZTnfgQ4EuBNo%3DQLYGFEbXS_7m2dXqtkcT7L8qrQ%40mail.gmail.com Branch

pgsql: Fix typos in comments.

2025-05-03 Thread Etsuro Fujita
Fix typos in comments. Also adjust the phrasing in the comments. Author: Etsuro Fujita Author: Heikki Linnakangas Reviewed-by: Tender Wang Reviewed-by: Gurjeet Singh Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CAPmGK17%3DPHSDZ%2B0G6jcj12buyyE1bQQc3sbp1Wxri7tODT-SDw

pgsql: Fix typos in comments.

2025-05-03 Thread Etsuro Fujita
Fix typos in comments. Also adjust the phrasing in the comments. Author: Etsuro Fujita Author: Heikki Linnakangas Reviewed-by: Tender Wang Reviewed-by: Gurjeet Singh Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CAPmGK17%3DPHSDZ%2B0G6jcj12buyyE1bQQc3sbp1Wxri7tODT-SDw

pgsql: Fix typos in comments.

2025-05-03 Thread Etsuro Fujita
Fix typos in comments. Also adjust the phrasing in the comments. Author: Etsuro Fujita Author: Heikki Linnakangas Reviewed-by: Tender Wang Reviewed-by: Gurjeet Singh Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CAPmGK17%3DPHSDZ%2B0G6jcj12buyyE1bQQc3sbp1Wxri7tODT-SDw

pgsql: Update comment in portal.h.

2024-08-01 Thread Etsuro Fujita
Update comment in portal.h. We store tuples into the portal's tuple store for a PORTAL_ONE_MOD_WITH query as well. Back-patch to all supported branches. Reviewed by Andy Fan. Discussion: https://postgr.es/m/CAPmGK14HVYBZYZtHabjeCd-e31VT%3Dwx6rQNq8QfehywLcpZ2Hw%40mail.gmail.com Branch -- R

pgsql: Update comment in portal.h.

2024-08-01 Thread Etsuro Fujita
Update comment in portal.h. We store tuples into the portal's tuple store for a PORTAL_ONE_MOD_WITH query as well. Back-patch to all supported branches. Reviewed by Andy Fan. Discussion: https://postgr.es/m/CAPmGK14HVYBZYZtHabjeCd-e31VT%3Dwx6rQNq8QfehywLcpZ2Hw%40mail.gmail.com Branch -- R

pgsql: Update comment in portal.h.

2024-08-01 Thread Etsuro Fujita
Update comment in portal.h. We store tuples into the portal's tuple store for a PORTAL_ONE_MOD_WITH query as well. Back-patch to all supported branches. Reviewed by Andy Fan. Discussion: https://postgr.es/m/CAPmGK14HVYBZYZtHabjeCd-e31VT%3Dwx6rQNq8QfehywLcpZ2Hw%40mail.gmail.com Branch -- m

pgsql: Update comment in portal.h.

2024-08-01 Thread Etsuro Fujita
Update comment in portal.h. We store tuples into the portal's tuple store for a PORTAL_ONE_MOD_WITH query as well. Back-patch to all supported branches. Reviewed by Andy Fan. Discussion: https://postgr.es/m/CAPmGK14HVYBZYZtHabjeCd-e31VT%3Dwx6rQNq8QfehywLcpZ2Hw%40mail.gmail.com Branch -- R

pgsql: Update comment in portal.h.

2024-08-01 Thread Etsuro Fujita
Update comment in portal.h. We store tuples into the portal's tuple store for a PORTAL_ONE_MOD_WITH query as well. Back-patch to all supported branches. Reviewed by Andy Fan. Discussion: https://postgr.es/m/CAPmGK14HVYBZYZtHabjeCd-e31VT%3Dwx6rQNq8QfehywLcpZ2Hw%40mail.gmail.com Branch -- R

pgsql: Update comment in portal.h.

2024-08-01 Thread Etsuro Fujita
Update comment in portal.h. We store tuples into the portal's tuple store for a PORTAL_ONE_MOD_WITH query as well. Back-patch to all supported branches. Reviewed by Andy Fan. Discussion: https://postgr.es/m/CAPmGK14HVYBZYZtHabjeCd-e31VT%3Dwx6rQNq8QfehywLcpZ2Hw%40mail.gmail.com Branch -- R

pgsql: Update comment in portal.h.

2024-08-01 Thread Etsuro Fujita
Update comment in portal.h. We store tuples into the portal's tuple store for a PORTAL_ONE_MOD_WITH query as well. Back-patch to all supported branches. Reviewed by Andy Fan. Discussion: https://postgr.es/m/CAPmGK14HVYBZYZtHabjeCd-e31VT%3Dwx6rQNq8QfehywLcpZ2Hw%40mail.gmail.com Branch -- R

pgsql: postgres_fdw: Avoid "cursor can only scan forward" error.

2024-07-18 Thread Etsuro Fujita
postgres_fdw: Avoid "cursor can only scan forward" error. Commit d844cd75a disallowed rewind in a non-scrollable cursor to resolve anomalies arising from such a cursor operation. However, this failed to take into account the assumption in postgres_fdw that when rescanning a foreign relation, it c

pgsql: postgres_fdw: Avoid "cursor can only scan forward" error.

2024-07-18 Thread Etsuro Fujita
postgres_fdw: Avoid "cursor can only scan forward" error. Commit d844cd75a disallowed rewind in a non-scrollable cursor to resolve anomalies arising from such a cursor operation. However, this failed to take into account the assumption in postgres_fdw that when rescanning a foreign relation, it c

pgsql: postgres_fdw: Avoid "cursor can only scan forward" error.

2024-07-18 Thread Etsuro Fujita
postgres_fdw: Avoid "cursor can only scan forward" error. Commit d844cd75a disallowed rewind in a non-scrollable cursor to resolve anomalies arising from such a cursor operation. However, this failed to take into account the assumption in postgres_fdw that when rescanning a foreign relation, it c

pgsql: postgres_fdw: Avoid "cursor can only scan forward" error.

2024-07-18 Thread Etsuro Fujita
postgres_fdw: Avoid "cursor can only scan forward" error. Commit d844cd75a disallowed rewind in a non-scrollable cursor to resolve anomalies arising from such a cursor operation. However, this failed to take into account the assumption in postgres_fdw that when rescanning a foreign relation, it c

pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser

2024-06-07 Thread Etsuro Fujita
postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote servers. Previously, when considering LIMIT pushdown, postgres_fdw failed to check whether the query has this clause, which led to pushing false LIMIT clauses, causing incorrect results. This clause has been supported since v13, so we n

pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser

2024-06-07 Thread Etsuro Fujita
postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote servers. Previously, when considering LIMIT pushdown, postgres_fdw failed to check whether the query has this clause, which led to pushing false LIMIT clauses, causing incorrect results. This clause has been supported since v13, so we n

pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser

2024-06-07 Thread Etsuro Fujita
postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote servers. Previously, when considering LIMIT pushdown, postgres_fdw failed to check whether the query has this clause, which led to pushing false LIMIT clauses, causing incorrect results. This clause has been supported since v13, so we n

pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser

2024-06-07 Thread Etsuro Fujita
postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote servers. Previously, when considering LIMIT pushdown, postgres_fdw failed to check whether the query has this clause, which led to pushing false LIMIT clauses, causing incorrect results. This clause has been supported since v13, so we n

pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser

2024-06-07 Thread Etsuro Fujita
postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote servers. Previously, when considering LIMIT pushdown, postgres_fdw failed to check whether the query has this clause, which led to pushing false LIMIT clauses, causing incorrect results. This clause has been supported since v13, so we n

pgsql: Fix typo in src/backend/utils/resowner/README.

2024-05-08 Thread Etsuro Fujita
Fix typo in src/backend/utils/resowner/README. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4364e0126ec7663363cf2dff86a0f6da949fc002 Modified Files -- src/backend/utils/resowner/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: postgres_fdw: Improve comment about handling of asynchronous req

2024-04-11 Thread Etsuro Fujita
postgres_fdw: Improve comment about handling of asynchronous requests. We updated this comment in back branches (see commit f6f61a4bd et al); let's do so in HEAD as well for consistency. Discussion: https://postgr.es/m/CAPmGK142V1kqDfjo2H%2Bb54JTn2woVBrisFq%2B%3D9jwXwxr0VvbgA%40mail.gmail.com B

pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket().

2024-04-11 Thread Etsuro Fujita
Fix WaitEventSet resource leak in WaitLatchOrSocket(). This function would have the same issue we solved in commit 501cfd07d: If an error is thrown after calling CreateWaitEventSet(), the file descriptor (on epoll- or kqueue-based systems) or handles (on Windows) that the WaitEventSet contains are

pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket().

2024-04-11 Thread Etsuro Fujita
Fix WaitEventSet resource leak in WaitLatchOrSocket(). This function would have the same issue we solved in commit 501cfd07d: If an error is thrown after calling CreateWaitEventSet(), the file descriptor (on epoll- or kqueue-based systems) or handles (on Windows) that the WaitEventSet contains are

pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket().

2024-04-11 Thread Etsuro Fujita
Fix WaitEventSet resource leak in WaitLatchOrSocket(). This function would have the same issue we solved in commit 501cfd07d: If an error is thrown after calling CreateWaitEventSet(), the file descriptor (on epoll- or kqueue-based systems) or handles (on Windows) that the WaitEventSet contains are

pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket().

2024-04-11 Thread Etsuro Fujita
Fix WaitEventSet resource leak in WaitLatchOrSocket(). This function would have the same issue we solved in commit 501cfd07d: If an error is thrown after calling CreateWaitEventSet(), the file descriptor (on epoll- or kqueue-based systems) or handles (on Windows) that the WaitEventSet contains are

pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket().

2024-04-11 Thread Etsuro Fujita
Fix WaitEventSet resource leak in WaitLatchOrSocket(). This function would have the same issue we solved in commit 501cfd07d: If an error is thrown after calling CreateWaitEventSet(), the file descriptor (on epoll- or kqueue-based systems) or handles (on Windows) that the WaitEventSet contains are

pgsql: postgres_fdw: Remove useless ternary expression.

2024-04-04 Thread Etsuro Fujita
postgres_fdw: Remove useless ternary expression. There is no case where we would call pgfdw_exec_cleanup_query or pgfdw_exec_cleanup_query_{begin,end} with a NULL query string, so this expression is pointless; remove it and instead add to the latter functions an assertion ensuring the given query

pgsql: Fix bogus coding in ExecAppendAsyncEventWait().

2024-04-04 Thread Etsuro Fujita
Fix bogus coding in ExecAppendAsyncEventWait(). No configured-by-FDW events would result in "return" directly out of a PG_TRY block, making the exception stack dangling. Repair. Oversight in commit 501cfd07d; back-patch to v14, like that commit, but as we do not have this issue in HEAD (cf. comm

pgsql: Fix bogus coding in ExecAppendAsyncEventWait().

2024-04-04 Thread Etsuro Fujita
Fix bogus coding in ExecAppendAsyncEventWait(). No configured-by-FDW events would result in "return" directly out of a PG_TRY block, making the exception stack dangling. Repair. Oversight in commit 501cfd07d; back-patch to v14, like that commit, but as we do not have this issue in HEAD (cf. comm

pgsql: Fix bogus coding in ExecAppendAsyncEventWait().

2024-04-04 Thread Etsuro Fujita
Fix bogus coding in ExecAppendAsyncEventWait(). No configured-by-FDW events would result in "return" directly out of a PG_TRY block, making the exception stack dangling. Repair. Oversight in commit 501cfd07d; back-patch to v14, like that commit, but as we do not have this issue in HEAD (cf. comm

pgsql: Remove incorrect file reference in comment.

2023-11-13 Thread Etsuro Fujita
Remove incorrect file reference in comment. Commit b7eda3e0e moved XidInMVCCSnapshot() from tqual.c into snapmgr.c, but follow-up commit c91560def incorrectly updated this reference. We could fix it, but as pointed out by Daniel Gustafsson, 1) the reader can easily find the file that contains the

pgsql: Remove incorrect file reference in comment.

2023-11-13 Thread Etsuro Fujita
Remove incorrect file reference in comment. Commit b7eda3e0e moved XidInMVCCSnapshot() from tqual.c into snapmgr.c, but follow-up commit c91560def incorrectly updated this reference. We could fix it, but as pointed out by Daniel Gustafsson, 1) the reader can easily find the file that contains the

pgsql: Remove incorrect file reference in comment.

2023-11-13 Thread Etsuro Fujita
Remove incorrect file reference in comment. Commit b7eda3e0e moved XidInMVCCSnapshot() from tqual.c into snapmgr.c, but follow-up commit c91560def incorrectly updated this reference. We could fix it, but as pointed out by Daniel Gustafsson, 1) the reader can easily find the file that contains the

pgsql: Remove incorrect file reference in comment.

2023-11-13 Thread Etsuro Fujita
Remove incorrect file reference in comment. Commit b7eda3e0e moved XidInMVCCSnapshot() from tqual.c into snapmgr.c, but follow-up commit c91560def incorrectly updated this reference. We could fix it, but as pointed out by Daniel Gustafsson, 1) the reader can easily find the file that contains the

pgsql: Remove incorrect file reference in comment.

2023-11-13 Thread Etsuro Fujita
Remove incorrect file reference in comment. Commit b7eda3e0e moved XidInMVCCSnapshot() from tqual.c into snapmgr.c, but follow-up commit c91560def incorrectly updated this reference. We could fix it, but as pointed out by Daniel Gustafsson, 1) the reader can easily find the file that contains the

pgsql: Remove incorrect file reference in comment.

2023-11-13 Thread Etsuro Fujita
Remove incorrect file reference in comment. Commit b7eda3e0e moved XidInMVCCSnapshot() from tqual.c into snapmgr.c, but follow-up commit c91560def incorrectly updated this reference. We could fix it, but as pointed out by Daniel Gustafsson, 1) the reader can easily find the file that contains the

pgsql: Remove extra parenthesis from comment.

2023-10-06 Thread Etsuro Fujita
Remove extra parenthesis from comment. Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3ed98ed88a06f368c700d2ce03ff46d6d415dde3 Modified Files -- src/backend/storage/ipc/procarray.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Remove extra parenthesis from comment.

2023-10-06 Thread Etsuro Fujita
Remove extra parenthesis from comment. Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bb912563059c789932efc423ad2092b7638249be Modified Files -- src/backend/storage/ipc/procarray.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Remove extra parenthesis from comment.

2023-10-06 Thread Etsuro Fujita
Remove extra parenthesis from comment. Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6e331c4a4faaf445f5a060b7aacd5da42b69740a Modified Files -- src/backend/storage/ipc/procarray.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Remove extra parenthesis from comment.

2023-10-06 Thread Etsuro Fujita
Remove extra parenthesis from comment. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/aec684ff0fb979d0245985fc0f84c07345a29e18 Modified Files -- src/backend/storage/ipc/procarray.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in src/backend/access/transam/README.

2023-09-28 Thread Etsuro Fujita
Fix typo in src/backend/access/transam/README. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c68f78538f93803b5c4f879da12918762eb43482 Modified Files -- src/backend/access/transam/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in src/backend/access/transam/README.

2023-09-28 Thread Etsuro Fujita
Fix typo in src/backend/access/transam/README. Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0db39e633812e8bda24067904ee8bc262e9eae25 Modified Files -- src/backend/access/transam/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in src/backend/access/transam/README.

2023-09-28 Thread Etsuro Fujita
Fix typo in src/backend/access/transam/README. Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8bdfc53be48ae99109a05df1dfd203d35207733f Modified Files -- src/backend/access/transam/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in src/backend/access/transam/README.

2023-09-28 Thread Etsuro Fujita
Fix typo in src/backend/access/transam/README. Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c33d42d2e95d7994582ea3b811826088b76ce4e2 Modified Files -- src/backend/access/transam/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Update comment about set_join_pathlist_hook().

2023-09-21 Thread Etsuro Fujita
Update comment about set_join_pathlist_hook(). The comment introduced by commit e7cb7ee14 was a bit too terse, which could lead to extensions doing different things within the hook function than we intend to allow. Extend the comment to explain what they can do within the hook function. Back-pat

pgsql: Update comment about set_join_pathlist_hook().

2023-09-21 Thread Etsuro Fujita
Update comment about set_join_pathlist_hook(). The comment introduced by commit e7cb7ee14 was a bit too terse, which could lead to extensions doing different things within the hook function than we intend to allow. Extend the comment to explain what they can do within the hook function. Back-pat

pgsql: Update comment about set_join_pathlist_hook().

2023-09-21 Thread Etsuro Fujita
Update comment about set_join_pathlist_hook(). The comment introduced by commit e7cb7ee14 was a bit too terse, which could lead to extensions doing different things within the hook function than we intend to allow. Extend the comment to explain what they can do within the hook function. Back-pat

pgsql: Update comment about set_join_pathlist_hook().

2023-09-21 Thread Etsuro Fujita
Update comment about set_join_pathlist_hook(). The comment introduced by commit e7cb7ee14 was a bit too terse, which could lead to extensions doing different things within the hook function than we intend to allow. Extend the comment to explain what they can do within the hook function. Back-pat

pgsql: Update comment about set_join_pathlist_hook().

2023-09-21 Thread Etsuro Fujita
Update comment about set_join_pathlist_hook(). The comment introduced by commit e7cb7ee14 was a bit too terse, which could lead to extensions doing different things within the hook function than we intend to allow. Extend the comment to explain what they can do within the hook function. Back-pat

pgsql: Update comment about set_join_pathlist_hook().

2023-09-21 Thread Etsuro Fujita
Update comment about set_join_pathlist_hook(). The comment introduced by commit e7cb7ee14 was a bit too terse, which could lead to extensions doing different things within the hook function than we intend to allow. Extend the comment to explain what they can do within the hook function. Back-pat

pgsql: Update comment about set_join_pathlist_hook().

2023-09-21 Thread Etsuro Fujita
Update comment about set_join_pathlist_hook(). The comment introduced by commit e7cb7ee14 was a bit too terse, which could lead to extensions doing different things within the hook function than we intend to allow. Extend the comment to explain what they can do within the hook function. Back-pat

pgsql: Doc: Improve documentation for creating custom scan paths.

2023-08-30 Thread Etsuro Fujita
Doc: Improve documentation for creating custom scan paths. This improves the documentation related to parallel query a little bit. Reviewed by Richard Guo. Discussion: https://postgr.es/m/CAPmGK159eJShAR4ek4Db8oHD4%2BZ18zwJkisEWkqRN-80BdDGFQ%40mail.gmail.com Branch -- master Details -

pgsql: postgres_fdw: Fix test for parameterized foreign scan.

2023-08-30 Thread Etsuro Fujita
postgres_fdw: Fix test for parameterized foreign scan. Commit e4106b252 should have updated this test, but did not; back-patch to all supported branches. Reviewed by Richard Guo. Discussion: http://postgr.es/m/CAPmGK15nR0NXLSCKQAcqbZbTzrzd5MozowWnTnGfPkayndF43Q%40mail.gmail.com Branch -- R

pgsql: postgres_fdw: Fix test for parameterized foreign scan.

2023-08-30 Thread Etsuro Fujita
postgres_fdw: Fix test for parameterized foreign scan. Commit e4106b252 should have updated this test, but did not; back-patch to all supported branches. Reviewed by Richard Guo. Discussion: http://postgr.es/m/CAPmGK15nR0NXLSCKQAcqbZbTzrzd5MozowWnTnGfPkayndF43Q%40mail.gmail.com Branch -- m

pgsql: postgres_fdw: Fix test for parameterized foreign scan.

2023-08-30 Thread Etsuro Fujita
postgres_fdw: Fix test for parameterized foreign scan. Commit e4106b252 should have updated this test, but did not; back-patch to all supported branches. Reviewed by Richard Guo. Discussion: http://postgr.es/m/CAPmGK15nR0NXLSCKQAcqbZbTzrzd5MozowWnTnGfPkayndF43Q%40mail.gmail.com Branch -- R

pgsql: postgres_fdw: Fix test for parameterized foreign scan.

2023-08-30 Thread Etsuro Fujita
postgres_fdw: Fix test for parameterized foreign scan. Commit e4106b252 should have updated this test, but did not; back-patch to all supported branches. Reviewed by Richard Guo. Discussion: http://postgr.es/m/CAPmGK15nR0NXLSCKQAcqbZbTzrzd5MozowWnTnGfPkayndF43Q%40mail.gmail.com Branch -- R

pgsql: postgres_fdw: Fix test for parameterized foreign scan.

2023-08-30 Thread Etsuro Fujita
postgres_fdw: Fix test for parameterized foreign scan. Commit e4106b252 should have updated this test, but did not; back-patch to all supported branches. Reviewed by Richard Guo. Discussion: http://postgr.es/m/CAPmGK15nR0NXLSCKQAcqbZbTzrzd5MozowWnTnGfPkayndF43Q%40mail.gmail.com Branch -- R

pgsql: postgres_fdw: Fix test for parameterized foreign scan.

2023-08-30 Thread Etsuro Fujita
postgres_fdw: Fix test for parameterized foreign scan. Commit e4106b252 should have updated this test, but did not; back-patch to all supported branches. Reviewed by Richard Guo. Discussion: http://postgr.es/m/CAPmGK15nR0NXLSCKQAcqbZbTzrzd5MozowWnTnGfPkayndF43Q%40mail.gmail.com Branch -- R

pgsql: postgres_fdw: Fix test for parameterized foreign scan.

2023-08-30 Thread Etsuro Fujita
postgres_fdw: Fix test for parameterized foreign scan. Commit e4106b252 should have updated this test, but did not; back-patch to all supported branches. Reviewed by Richard Guo. Discussion: http://postgr.es/m/CAPmGK15nR0NXLSCKQAcqbZbTzrzd5MozowWnTnGfPkayndF43Q%40mail.gmail.com Branch -- R

Re: pgsql: Re-allow FDWs and custom scan providers to replace joins with ps

2023-08-15 Thread Etsuro Fujita
I CCed Andrew. On Tue, Aug 15, 2023 at 4:50 PM Etsuro Fujita wrote: > Re-allow FDWs and custom scan providers to replace joins with pseudoconstant > quals. This broke blackhole_fdw, which is tested in buildfarm member crake, because it changed the argument list for create_foreignsca

pgsql: Fix code indentation vioaltion introduced in commit 9e9931d2b.

2023-08-15 Thread Etsuro Fujita
Fix code indentation vioaltion introduced in commit 9e9931d2b. Per buildfarm member koel Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/89be0b89ae60c63856fd26d82a104781540e2312 Modified Files -- contrib/postgres_fdw/postgres_fdw.c | 11 +++ 1 fi

pgsql: Re-allow FDWs and custom scan providers to replace joins with ps

2023-08-15 Thread Etsuro Fujita
Re-allow FDWs and custom scan providers to replace joins with pseudoconstant quals. This was disabled in commit 6f80a8d9c due to the lack of support for handling of pseudoconstant quals assigned to replaced joins in createplan.c. To re-allow it, this patch adds the support by 1) modifying the Fo

pgsql: Doc: update documentation for creating custom scan paths.

2023-08-03 Thread Etsuro Fujita
Doc: update documentation for creating custom scan paths. Commit f49842d1e added a new callback for custom scan paths, but missed updating the documentation. Back-patch to all supported branches. Discussion: https://postgr.es/m/CAPmGK15ODkN%2B%3DhkBCufj1HBW0x5OTb65Xuy7ryXchMdiCMpx_g%40mail.gmai

pgsql: Doc: update documentation for creating custom scan paths.

2023-08-03 Thread Etsuro Fujita
Doc: update documentation for creating custom scan paths. Commit f49842d1e added a new callback for custom scan paths, but missed updating the documentation. Back-patch to all supported branches. Discussion: https://postgr.es/m/CAPmGK15ODkN%2B%3DhkBCufj1HBW0x5OTb65Xuy7ryXchMdiCMpx_g%40mail.gmai

pgsql: Doc: update documentation for creating custom scan paths.

2023-08-03 Thread Etsuro Fujita
Doc: update documentation for creating custom scan paths. Commit f49842d1e added a new callback for custom scan paths, but missed updating the documentation. Back-patch to all supported branches. Discussion: https://postgr.es/m/CAPmGK15ODkN%2B%3DhkBCufj1HBW0x5OTb65Xuy7ryXchMdiCMpx_g%40mail.gmai

pgsql: Doc: update documentation for creating custom scan paths.

2023-08-03 Thread Etsuro Fujita
Doc: update documentation for creating custom scan paths. Commit f49842d1e added a new callback for custom scan paths, but missed updating the documentation. Back-patch to all supported branches. Discussion: https://postgr.es/m/CAPmGK15ODkN%2B%3DhkBCufj1HBW0x5OTb65Xuy7ryXchMdiCMpx_g%40mail.gmai

pgsql: Doc: update documentation for creating custom scan paths.

2023-08-03 Thread Etsuro Fujita
Doc: update documentation for creating custom scan paths. Commit f49842d1e added a new callback for custom scan paths, but missed updating the documentation. Back-patch to all supported branches. Discussion: https://postgr.es/m/CAPmGK15ODkN%2B%3DhkBCufj1HBW0x5OTb65Xuy7ryXchMdiCMpx_g%40mail.gmai

pgsql: Doc: update documentation for creating custom scan paths.

2023-08-03 Thread Etsuro Fujita
Doc: update documentation for creating custom scan paths. Commit f49842d1e added a new callback for custom scan paths, but missed updating the documentation. Back-patch to all supported branches. Discussion: https://postgr.es/m/CAPmGK15ODkN%2B%3DhkBCufj1HBW0x5OTb65Xuy7ryXchMdiCMpx_g%40mail.gmai

  1   2   3   4   >