Re: pgsql: Add some regression tests that exercise hash join code.

2017-12-05 Thread Thomas Munro
On Wed, Dec 6, 2017 at 8:03 AM, Andres Freund wrote: > On 2017-12-05 12:59:21 +1300, Thomas Munro wrote: >> src/backend/commands/explain.c | 58 ++-- > > This didn't actually include nodeHash.h, ... Ugh, I'd lost -Werror from my COPT. Back in there it goes. > Pushed, thank

Re: pgsql: Add some regression tests that exercise hash join code.

2017-12-05 Thread Andres Freund
Hi, On 2017-12-05 12:59:21 +1300, Thomas Munro wrote: > src/backend/commands/explain.c | 58 ++-- This didn't actually include nodeHash.h, therefore ExecHashGetInstrumentation() didn't have a prototype. I added the relevant include and remove the hashjoin.h include which isn

Re: pgsql: Add some regression tests that exercise hash join code.

2017-12-04 Thread Thomas Munro
On Tue, Dec 5, 2017 at 9:21 AM, Andres Freund wrote: > On 2017-12-04 12:28:56 +1300, Thomas Munro wrote: >> From 43eeea0bc35204440d262224b56efca958b33428 Mon Sep 17 00:00:00 2001 >> From: Thomas Munro >> Date: Mon, 4 Dec 2017 11:52:11 +1300 >> Subject: [PATCH] Fix EXPLAIN ANALYZE of hash join whe

Re: pgsql: Add some regression tests that exercise hash join code.

2017-12-04 Thread Andres Freund
On 2017-12-04 12:28:56 +1300, Thomas Munro wrote: > From 43eeea0bc35204440d262224b56efca958b33428 Mon Sep 17 00:00:00 2001 > From: Thomas Munro > Date: Mon, 4 Dec 2017 11:52:11 +1300 > Subject: [PATCH] Fix EXPLAIN ANALYZE of hash join when the leader doesn't > execute. > > If a hash join appears

Re: pgsql: Add some regression tests that exercise hash join code.

2017-12-03 Thread Thomas Munro
On Mon, Dec 4, 2017 at 12:18 PM, Thomas Munro wrote: > On Mon, Dec 4, 2017 at 9:12 AM, Thomas Munro > wrote: >> On Mon, Dec 4, 2017 at 7:39 AM, Andres Freund wrote: >>> On 2017-11-30 08:06:44 -0800, Andres Freund wrote: At the current rate of failure I'm slightly inclined to just leave the

Re: pgsql: Add some regression tests that exercise hash join code.

2017-12-03 Thread Thomas Munro
On Mon, Dec 4, 2017 at 9:12 AM, Thomas Munro wrote: > On Mon, Dec 4, 2017 at 7:39 AM, Andres Freund wrote: >> On 2017-11-30 08:06:44 -0800, Andres Freund wrote: >>> At the current rate of failure I'm slightly inclined to just leave the >>> occasionally failing test, which sounds like an actual bu

Re: pgsql: Add some regression tests that exercise hash join code.

2017-12-03 Thread Thomas Munro
On Mon, Dec 4, 2017 at 7:39 AM, Andres Freund wrote: > On 2017-11-30 08:06:44 -0800, Andres Freund wrote: >> At the current rate of failure I'm slightly inclined to just leave the >> occasionally failing test, which sounds like an actual bug imo, in place >> till we have the fix. But if there's a

Re: pgsql: Add some regression tests that exercise hash join code.

2017-12-03 Thread Andres Freund
On 2017-11-30 08:06:44 -0800, Andres Freund wrote: > Hi, > > On 2017-11-30 23:53:55 +1300, Thomas Munro wrote: > > On Thu, Nov 30, 2017 at 4:47 PM, Thomas Munro > > wrote: > > > On Thu, Nov 30, 2017 at 4:13 PM, Tom Lane wrote: > > >> Andres Freund writes: > > >>> Add some regression tests that

Re: pgsql: Add some regression tests that exercise hash join code.

2017-11-30 Thread Andres Freund
Hi, On 2017-11-30 23:53:55 +1300, Thomas Munro wrote: > On Thu, Nov 30, 2017 at 4:47 PM, Thomas Munro > wrote: > > On Thu, Nov 30, 2017 at 4:13 PM, Tom Lane wrote: > >> Andres Freund writes: > >>> Add some regression tests that exercise hash join code. > >> > >> At least one buildfarm member do

Re: pgsql: Add some regression tests that exercise hash join code.

2017-11-30 Thread Thomas Munro
On Thu, Nov 30, 2017 at 4:47 PM, Thomas Munro wrote: > On Thu, Nov 30, 2017 at 4:13 PM, Tom Lane wrote: >> Andres Freund writes: >>> Add some regression tests that exercise hash join code. >> >> At least one buildfarm member doesn't like this ... > > $$); >initially_multibatch | increased_

Re: pgsql: Add some regression tests that exercise hash join code.

2017-11-29 Thread Thomas Munro
On Thu, Nov 30, 2017 at 4:13 PM, Tom Lane wrote: > Andres Freund writes: >> Add some regression tests that exercise hash join code. > > At least one buildfarm member doesn't like this ... $$); initially_multibatch | increased_batches --+--- ! t

Re: pgsql: Add some regression tests that exercise hash join code.

2017-11-29 Thread Tom Lane
Andres Freund writes: > Add some regression tests that exercise hash join code. At least one buildfarm member doesn't like this ... regards, tom lane