Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines.

2022-07-14 Thread Tom Lane
Peter Eisentraut writes: > It seems that -fkeep-inline-functions is more demanding than what wrasse > is running on. I need the attached patch to get it to build cleanly. Interesting. I'm not entirely clear on which external references cause wrasse to spit up. > I think this would be good to

Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines.

2022-07-14 Thread Peter Eisentraut
On 14.07.22 12:05, Peter Eisentraut wrote: On 13.07.22 20:24, Tom Lane wrote: Peter Eisentraut writes: What platforms did this fail on?  How can one observe the failure locally? wrasse at least: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=wrasse&dt=2022-07-13%2014%3A49%3A17

Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines.

2022-07-14 Thread Peter Eisentraut
On 13.07.22 20:24, Tom Lane wrote: Peter Eisentraut writes: What platforms did this fail on? How can one observe the failure locally? wrasse at least: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=wrasse&dt=2022-07-13%2014%3A49%3A17 I think possibly you could duplicate the proble

Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines.

2022-07-13 Thread Tom Lane
Peter Eisentraut writes: > What platforms did this fail on? How can one observe the failure locally? wrasse at least: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=wrasse&dt=2022-07-13%2014%3A49%3A17 I think possibly you could duplicate the problem with gcc by using -fkeep-inline-fun

Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines.

2022-07-13 Thread Peter Eisentraut
On 13.07.22 19:37, Tom Lane wrote: Avoid unsatisfied-external-reference errors in static inlines. Commit 9c727360b neglected the lesson we've learned before: protect references to backend global variables with #ifndef FRONTEND. What platforms did this fail on? How can one observe the failure