Re: pgsql: Change ThisTimeLineID from a global variable to a local variable

2021-11-07 Thread Robert Haas
On Sun, Nov 7, 2021 at 4:39 PM Tom Lane wrote: > Based on this data point, we can speculate that the number of such > variables matters, too. Yeah, apparently. Well, at least I don't feel bad about not guessing that that would happen. That's pretty magical. -- Robert Haas EDB: http://www.enterp

Re: pgsql: Change ThisTimeLineID from a global variable to a local variable

2021-11-07 Thread Tom Lane
Robert Haas writes: > On Sun, Nov 7, 2021 at 12:23 PM Tom Lane wrote: >> Yeah. I've seen some older compilers complain about that code before, >> but now there are over a dozen buildfarm members warning about it. >> It's clearly a false positive, since checkPointLoc does get set in >> the read_b

Re: pgsql: Change ThisTimeLineID from a global variable to a local variable

2021-11-07 Thread Robert Haas
On Sun, Nov 7, 2021 at 12:23 PM Tom Lane wrote: > Yeah. I've seen some older compilers complain about that code before, > but now there are over a dozen buildfarm members warning about it. > It's clearly a false positive, since checkPointLoc does get set in > the read_backup_label()-failure-retur

Re: pgsql: Change ThisTimeLineID from a global variable to a local variable

2021-11-07 Thread Tom Lane
Michael Paquier writes: > On Fri, Nov 05, 2021 at 04:55:52PM +, Robert Haas wrote: >> Change ThisTimeLineID from a global variable to a local variable. > lapwing looks unhappy after this commit: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lapwing&dt=2021-11-05%2022%3A40%3A10 > x

Re: pgsql: Change ThisTimeLineID from a global variable to a local variable

2021-11-05 Thread Michael Paquier
Hi Robert, On Fri, Nov 05, 2021 at 04:55:52PM +, Robert Haas wrote: > Change ThisTimeLineID from a global variable to a local variable. > > StartupXLOG() still has ThisTimeLineID as a local variable, but the > remaining code in xlog.c now needs to the relevant TimeLineID by some > other means