Re: pgsql: Emit parameter values during query bind/execute errors

2019-12-30 Thread Alvaro Herrera
On 2019-Dec-12, Tom Lane wrote: > Alvaro Herrera writes: > > Hmm, the affected ones (jacana and fairywren only AFAICS) seem to be > > gcc-based, which presumably work differently than the msvc-based in how > > newlines are interpreted in the test script. I pushed an attempted > > blind fix. > >

Re: pgsql: Emit parameter values during query bind/execute errors

2019-12-12 Thread Tom Lane
Alvaro Herrera writes: > Hmm, the affected ones (jacana and fairywren only AFAICS) seem to be > gcc-based, which presumably work differently than the msvc-based in how > newlines are interpreted in the test script. I pushed an attempted > blind fix. > I *hope* that those two are not the only Win

Re: pgsql: Emit parameter values during query bind/execute errors

2019-12-12 Thread Alvaro Herrera
On 2019-Dec-12, Tom Lane wrote: > Alvaro Herrera writes: > > Emit parameter values during query bind/execute errors > > (Some of?) the Windows buildfarm critters don't like the test > case you added. I speculate that the test pattern is neglecting > to allow for Windows-style newlines. Hmm, th

Re: pgsql: Emit parameter values during query bind/execute errors

2019-12-12 Thread Tom Lane
Alvaro Herrera writes: > Emit parameter values during query bind/execute errors (Some of?) the Windows buildfarm critters don't like the test case you added. I speculate that the test pattern is neglecting to allow for Windows-style newlines. regards, tom lane