Re: pgsql: Fix incorrect format placeholder.

2021-11-09 Thread Michael Paquier
On Tue, Nov 09, 2021 at 09:40:47AM -0500, Tom Lane wrote: > OK by me, but probably should raise the issue in -hackers not just > -committers. Also, please back-patch once the release freeze lifts. Sure. -- Michael signature.asc Description: PGP signature

Re: pgsql: Fix incorrect format placeholder.

2021-11-09 Thread Tom Lane
Michael Paquier writes: > Yeah, you have a point here. -Wcompound-token-split-by-macro is new > as of clang-12 from last April, so I am a bit surprised that it is > that present in the buildfarm TBH. > The attached is sufficient to remove those warnings. Debian provides > clang-12, so it is eas

Re: pgsql: Fix incorrect format placeholder.

2021-11-09 Thread Michael Paquier
On Tue, Nov 09, 2021 at 01:06:26AM -0500, Tom Lane wrote: > I figured the Perl guys would do something about it, but it will be a > very long time before that propagates everywhere. Maybe we should > teach configure to add -Wno-compound-token-split-by-macro? By my > count there are now five build

Re: pgsql: Fix incorrect format placeholder.

2021-11-08 Thread Tom Lane
Michael Paquier writes: > On Tue, Nov 09, 2021 at 12:19:36AM -0500, Tom Lane wrote: >> Umm ... florican and dangomushi spotted it. Maybe we need a 32-bit >> machine with -Werror? > Indeed, I can see it in the logs of dangomushi. I could add a -Werror > there, but there are also a bunch of warni

Re: pgsql: Fix incorrect format placeholder.

2021-11-08 Thread Michael Paquier
On Tue, Nov 09, 2021 at 12:19:36AM -0500, Tom Lane wrote: > Umm ... florican and dangomushi spotted it. Maybe we need a 32-bit > machine with -Werror? Indeed, I can see it in the logs of dangomushi. I could add a -Werror there, but there are also a bunch of warnings generated by plperl. I'd rath

Re: pgsql: Fix incorrect format placeholder.

2021-11-08 Thread Tom Lane
Michael Paquier writes: > Thanks, that's embarassing. The last time I bumped into this issue, > the report came from lapwing which would directly report a failure, > but it did not happen this time. Which animal has reported that? Umm ... florican and dangomushi spotted it. Maybe we need a 32-

Re: pgsql: Fix incorrect format placeholder.

2021-11-08 Thread Michael Paquier
On Mon, Nov 08, 2021 at 07:32:41PM +, Tom Lane wrote: > Fix incorrect format placeholder. > > Per buildfarm warnings. Thanks, that's embarassing. The last time I bumped into this issue, the report came from lapwing which would directly report a failure, but it did not happen this time. Whic