Re: pgsql: Fix unlink() for STATUS_DELETE_PENDING on Windows.

2022-10-26 Thread Andres Freund
Hi, On 2022-10-25 18:57:54 -0500, Justin Pryzby wrote: > It'd be swell if we could use a separate device in CI, to be used for > running tests. Bonus points if it supports COW. My colleague Bilal just got the generation of windows VMs and running the test with cirrus working, not done by any mea

Re: pgsql: Fix unlink() for STATUS_DELETE_PENDING on Windows.

2022-10-25 Thread Thomas Munro
On Wed, Oct 26, 2022 at 12:57 PM Justin Pryzby wrote: > On Wed, Oct 26, 2022 at 11:15:16AM +1300, Thomas Munro wrote: > > On Wed, Oct 26, 2022 at 10:31 AM Justin Pryzby wrote: > > > > If I'm not wrong, this didn't fix the issue you said it fixed. > > > > > > s/said/hoped/sorry > > > > Drat. More

Re: pgsql: Fix unlink() for STATUS_DELETE_PENDING on Windows.

2022-10-25 Thread Justin Pryzby
On Wed, Oct 26, 2022 at 11:15:16AM +1300, Thomas Munro wrote: > On Wed, Oct 26, 2022 at 10:31 AM Justin Pryzby wrote: > > On Tue, Oct 25, 2022 at 04:21:02PM -0500, Justin Pryzby wrote: > > > > Restore that behavior with an explicit check, to see if it fixes the > > > > occasional 'directory not em

Re: pgsql: Fix unlink() for STATUS_DELETE_PENDING on Windows.

2022-10-25 Thread Thomas Munro
On Wed, Oct 26, 2022 at 10:31 AM Justin Pryzby wrote: > On Tue, Oct 25, 2022 at 04:21:02PM -0500, Justin Pryzby wrote: > > > Restore that behavior with an explicit check, to see if it fixes the > > > occasional 'directory not empty' failures seen in the pg_upgrade tests > > > on CI. Further impro

Re: pgsql: Fix unlink() for STATUS_DELETE_PENDING on Windows.

2022-10-25 Thread Justin Pryzby
On Tue, Oct 25, 2022 at 04:21:02PM -0500, Justin Pryzby wrote: > > Restore that behavior with an explicit check, to see if it fixes the > > occasional 'directory not empty' failures seen in the pg_upgrade tests > > on CI. Further improvements are possible with proposed upgrades to > > modern Windo

Re: pgsql: Fix unlink() for STATUS_DELETE_PENDING on Windows.

2022-10-25 Thread Justin Pryzby
On Tue, Oct 25, 2022 at 03:29:42AM +, Thomas Munro wrote: > Fix unlink() for STATUS_DELETE_PENDING on Windows. > > Commit f357233c assumed that it was OK to return ENOENT directly if > lstat() failed that way. If we got STATUS_DELETE_PENDING while trying > to unlink a file that we had already